[HOLD for payment 2025-02-04] [HOLD for payment 2025-01-28] [$250] Web - Trip - Payment with Expensify button shown next to submit button on Open trip report

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.78-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail: #52823
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Windows 11 / Chrome
App Component: Chat Report View

Action Performed:

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823

1. Go to staging.new.expensify.com
2. Go to trip room.
3. Click on the expense preview.

Expected Result:

There should only be a Submit button at the top of the report page.

Actual Result:

There are two buttons - "Pay with Expensify" and "Submit"

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6701759_1735043098180.bandicam_2024-12-24_20-22-00-193.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021876334627155535758
• Upwork Job ID: 1876334627155535758
• Last Price Increase: 2025-01-06
• Automatic offers:
• shubham1206agra | Contributor | 105583255

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[sakluger]

The actual bug here is that the expense report shows a Pay with expensify button at all. The report is still open, so it shouldn't have a Pay option, in fact, I can't think of any scenario where we would show both a submit and pay button at the same time.

@rojiphil @jacobkim9881 do you think this is related to #53226 at all?

[jacobkim9881]

@sakluger I not sure if it is related. I have tried Action Performed but I couldn't because I can't enable travel. I can test if I get a company email.

[melvin-bot]

@sakluger Huh... This is 4 days overdue. Who can take care of this?

[sakluger]

@jacobkim9881 we can't get you a company email, but I can add your testing email to the travel beta. What email are you using to test?

[sakluger]

Actually, it looks like you would have to actually book travel to test, which would require you to spend real money. I'm going to ask around internally first.

[jacobkim9881]

Actually, it looks like you would have to actually book travel to test, which would require you to spend real money. I'm going to ask around internally first.

I understood. I will wait for internal team.

[jacobkim9881]

we can't get you a company email, but I can add your testing email to the travel beta. What email are you using to test?

I know I should actually book travel to test but in case my email is like below:

[sakluger]

I asked for help in Slack here to see if this is external or internal: https://expensify.slack.com/archives/C05S5EV2JTX/p1735839407611239

[sakluger]

Hey @jacobkim9881 - I set [email protected] as a Travel test account. Please go to your account settings in Expensify Classic and add a first and last name.

Then, to book fake travel:

1. Go to Travel in the LHN
2. Click the "Book or manage Travel" button
3. Check the checkbox to accept terms
4. Enter an address (it can be fake)
5. Click confirm and wait
6. You will then be logged into Spotnana

Then, Inside of Spotnana:

1. Search for a new booking
   1. For flights:
      • This can be flaky, so it is recommended to use the following flight
      • One way from SEA to SFO
      • Alaska Airlines
      • At least 1 month in the future
   2. For hotels:
      1. Search for any major airport (usually SFO, NYC, LHR)
      2. Book any of top chains (usually Marriott, Hilton)
2. Select the flight
3. Add the other required information and click save at the top of the panel
4. Click "next" on the right side
5. Click "select a trip" and create a new trip
6. Add the stripe test card ending in 4444. All data such as address, name etc. can be fake, as long as the expiration is after the current date
7. Book the trip

[sakluger]

Once you book the fake travel, you should see the trip report in NewDot.

[jacobkim9881]

@sakluger I understood and let me test these step.

[jacobkim9881]

@sakluger Thanks for guiding me with the steps. I have added a first and last name at account setting in OD. I couldn't find "Book or manage Travel" button at Travel in LHN of OD but I have this screen.

[sakluger]

Sorry @jacobkim9881 - I forgot to add you to the Travel beta. I've added you now, and so the button should show up within the next hour (betas can take up to 1 hour to be applied). Let me know if you run into any other issues.

[jacobkim9881]

@sakluger Indeed, there occurs enable button. It still needs company email account though. I hope I got to know any workaround to enable.

[shubham1206agra]

@sakluger It will be easier if you assign this to me and @blazejkustra since we have trip rooms present.

[sakluger]

@jacobkim9881 thanks for trying! Sorry you weren't able to get it working without a company email.

@shubham1206agra and @blazejkustra I will assign you two as suggested.

[melvin-bot]

Triggered auto assignment to @blimpich, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide pay button if submit button is visible #55150

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@shubham1206agra @sakluger @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.89-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Hide pay button if submit button is visible #55503

If no regressions arise, payment will be issued on 2025-02-04. 🎊

For reference, here are some details about the assignees on this issue:

• @blazejkustra does not require payment (Contractor)
• @shubham1206agra requires payment automatic offer (Contributor)

[melvin-bot]

@shubham1206agra @sakluger @shubham1206agra The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sakluger]

Hey @shubham1206agra - please complete the BZ checklist so that I can complete payment. Thanks!

[shubham1206agra]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment: https://github.com/Expensify/App/pull/41859/files#r1943324139

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue:

Regression Test Proposal

Precondition:

• Create a trip with steps from this PR [vip-travel] Create Trip Details Screen #52823

Test:

1. Open App
2. Go to trip room.
3. Click on the expense preview.
4. Verify that only Submit button is visible

Do we agree 👍 or 👎

[sakluger]

Thanks!

Summarizing payment on this issue:

Contributor: @blazejkustra - No payment needed
Contributor+: @shubham1206agra $250, paid via Upwork