[HOLD for payment 2025-01-24] [$250] Compose box > Create - Pay {userName} emit no sound after click on Pay elsewhere

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.80-1
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/5396692
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: macOS Sequoia 15.2, Desktop/Web | iOS Hybrid/mWeb Safari, iOS 18.2 | Samsung A22 mWeb Chrome
App Component: Other

Action Performed:

1. Open the desktop app or go to: https://staging.new.expensify.com/
2. Log in
3. Go to 1:1 convo
4. Click on '+' button in the compose box
5. Click on 'Pay {userName}'
6. Type any valid amount, click next
7. Click on button 'Pay elsewhere'

Expected Result:

A success sound should be emitted right after clicking on ‘Pay elsewhere’.

Actual Result:

No sound is emitted after clicking on ‘Pay elsewhere’.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6704803_1735745205628.Screen_Recording_2025-01-01_at_12.10.48_PM.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021875191938779375502
• Upwork Job ID: 1875191938779375502
• Last Price Increase: 2025-01-03
• Automatic offers:
• rojiphil | Reviewer | 105611285
• nkdengineer | Contributor | 105611286

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[nkdengineer]

Edited by proposal-police: This proposal was edited at 2025-01-01 17:18:50 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

No sound is emitted after clicking on ‘Pay elsewhere’.

What is the root cause of that problem?

We pass shouldPlaySound as false in here

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 666 in 701c68d

shouldPlaySound={false}

What changes do you think we should make in order to solve the problem?

We can pass shouldPlaySound as true or in case iouType === 'pay' or only in case paymentMethod === CONST.IOU.PAYMENT_TYPE.ELSEWHERE

App/src/pages/iou/request/step/IOURequestStepConfirmation.tsx

Line 666 in 701c68d

shouldPlaySound={false}

And add update logic here to play sound

        if (shouldPlaySound) {
            playSound(SOUNDS.DONE);
        }
        onSendMoney?.(paymentMethod);

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

What alternative solutions did you explore? (Optional)

NA

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[MitchExpensify]

Clarifying what's expected here: https://expensify.slack.com/archives/C03U7DCU4/p1735914966075309

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021875191938779375502

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rojiphil (External)

[rojiphil]

Reviewing now

[rojiphil]

@nkdengineer proposal to play the sound based on shouldPlaySound LGTM
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @arosiclair, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[arosiclair]

@rojiphil @nkdengineer do we know why shouldPlaySound was set to false to begin with? I see it was supposed to fix a duplicate sound issue here. Are we sure changing this won't cause other issues?

[nkdengineer]

@arosiclair In this case it will not run into the createTransaction function, it will call the sendMoney function here and we don't play sound in sendMoney function

[arosiclair]

Alright be sure to test well 👍

[melvin-bot]

📣 @rojiphil 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.86-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Pay userName emit no sound #54986

If no regressions arise, payment will be issued on 2025-01-24. 🎊

For reference, here are some details about the assignees on this issue:

• @rojiphil requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

@rojiphil @MitchExpensify @rojiphil The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[MitchExpensify]

Payment summary:

• $250 @rojiphil requires payment automatic offer (Reviewer)
• $250 @nkdengineer requires payment automatic offer (Contributor)

@rojiphil reminder on BZ steps

[MitchExpensify]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
• 2b. Reported on staging (eg. found during regression or PR testing)
• 2d. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion:

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal Template

• [BugZero Assignee] Create a GH issue for creating/updating the regression test once above steps have been agreed upon.

  Link to issue: https://github.com/Expensify/Expensify/issues/464308

Regression Test Proposal

Precondition:

Test:

Do we agree 👍 or 👎

[rojiphil]

BugZero Checklist:

• [Contributor] Classify the bug:

Bug classification

Source of bug:

• 1a. Result of the original design (eg. a case wasn't considered)
• 1b. Mistake during implementation
• 1c. Backend bug
• 1z. Other:

Where bug was reported:

• 2a. Reported on production
• 2b. Reported on staging (deploy blocker)
• 2c. Reported on a PR
• 2z. Other:

Who reported the bug:

• 3a. Expensify user
• 3b. Expensify employee
• 3c. Contributor
• 3d. QA
• 3z. Other:

• [Contributor] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake.

  Link to comment:

• [Contributor] If the regression was CRITICAL (e.g. interrupts a core flow) A discussion in #expensify-open-source has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner.

  Link to discussion: Not Required. The existing checklist is good enough to capture such issues.

• [Contributor] If it was decided to create a regression test for the bug, please propose the regression test steps using the template below to ensure the same bug will not reach production again.

Regression Test Proposal

Precondition:

Test:

1. Go to 1:1 chat
2. Click on '+' button in the compose box
3. Click on 'Pay {userName}'
4. Type any valid amount, click next
5. Click on button 'Pay elsewhere'
6. Verify that: A success sound should be emitted right after clicking on ‘Pay elsewhere’.

Do we agree 👍 or 👎

[rojiphil]

@MitchExpensify BZ checklist done. Just the payment is pending. Thanks.

[MitchExpensify]

@rojiphil please accept this offer as a next step: https://www.upwork.com/nx/wm/offer/105611285
@nkdengineer - paid!

[rojiphil]

please accept this offer as a next step: https://www.upwork.com/nx/wm/offer/105611285

@MitchExpensify Oh! I missed this. I just accepted the offer. Thanks.

[MitchExpensify]

Paid, thanks!