-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type #54893
Comments
Triggered auto assignment to @isabelastisser ( |
I'm Fábio from Callstack - expert agency contributor - and I would like to work on this issue. |
PR was merged, will proceed with the small follow up soon |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-17. 🎊 For reference, here are some details about the assignees on this issue:
|
@mountiny @isabelastisser @fabioh8010 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Updates:
|
Updates:
|
Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO. |
@fabioh8010 anymore left? |
For now, no. We're all set here! |
$250 to @eVoloshchak |
Offer sent to @eVoloshchak in Upwork. All set! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-01-28. 🎊 For reference, here are some details about the assignees on this issue:
|
@eVoloshchak @isabelastisser @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
Problem
Similarly, as we had to do in this PR #40418, we are again running into an issue with an excess of string unions in the Route type. You can see full explanation in the PR there.
### Solution
Update the types to reduce the number of unions so the TS is working fine.
Issue Owner
Current Issue Owner: @isabelastisserThe text was updated successfully, but these errors were encountered: