Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type #54893

Closed
mountiny opened this issue Jan 7, 2025 · 16 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2

Comments

@mountiny
Copy link
Contributor

mountiny commented Jan 7, 2025

Problem

Similarly, as we had to do in this PR #40418, we are again running into an issue with an excess of string unions in the Route type. You can see full explanation in the PR there.

### Solution

Update the types to reduce the number of unions so the TS is working fine.

Issue OwnerCurrent Issue Owner: @isabelastisser
@mountiny mountiny added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Jan 7, 2025
@mountiny mountiny self-assigned this Jan 7, 2025
Copy link

melvin-bot bot commented Jan 7, 2025

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@fabioh8010
Copy link
Contributor

I'm Fábio from Callstack - expert agency contributor - and I would like to work on this issue.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jan 7, 2025
@fabioh8010
Copy link
Contributor

PR was merged, will proceed with the small follow up soon

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jan 10, 2025
@melvin-bot melvin-bot bot changed the title Reduce string unions in Route type [HOLD for payment 2025-01-17] Reduce string unions in Route type Jan 10, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 10, 2025
Copy link

melvin-bot bot commented Jan 10, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 10, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.82-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 10, 2025

@mountiny @isabelastisser @fabioh8010 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@fabioh8010
Copy link
Contributor

Updates:

  • Created the follow-up PR to improve some typings, will proceed with testing.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jan 13, 2025
@fabioh8010
Copy link
Contributor

Updates:

  • PR opened to review!

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jan 16, 2025
Copy link

melvin-bot bot commented Jan 17, 2025

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

@mountiny
Copy link
Contributor Author

@fabioh8010 anymore left?

@fabioh8010
Copy link
Contributor

For now, no. We're all set here!

@mountiny
Copy link
Contributor Author

$250 to @eVoloshchak

@isabelastisser
Copy link
Contributor

Offer sent to @eVoloshchak in Upwork. All set!

@github-project-automation github-project-automation bot moved this from LOW to Done in [#whatsnext] #quality Jan 17, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Jan 21, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-01-17] Reduce string unions in Route type [HOLD for payment 2025-01-28] [HOLD for payment 2025-01-17] Reduce string unions in Route type Jan 21, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jan 21, 2025
Copy link

melvin-bot bot commented Jan 21, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jan 21, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.87-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-01-28. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jan 21, 2025

@eVoloshchak @isabelastisser @eVoloshchak The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Weekly KSv2
Projects
Status: Done
Development

No branches or pull requests

4 participants