Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invoices - Bank account row is missing currency after reset and restart app #55674

Closed
4 of 8 tasks
lanitochka17 opened this issue Jan 23, 2025 · 15 comments
Closed
4 of 8 tasks
Assignees
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review

Comments

@lanitochka17
Copy link

lanitochka17 commented Jan 23, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.89-2
Reproducible in staging?: Y
Reproducible in production?: No, new feature
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team
Component: Workspace Settings

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace settings > Invoices
  3. Click Add bank account
  4. Select any non-US country (eg, India)
  5. Go through the setup to add an India bank account
  6. Note that it shows INR before the dot separator in the bank account row
  7. Go to account settings > Troubleshoot > Clear cache and restart
  8. Click Reset and restart
  9. Do not go to Wallet
  10. Go to workspace settings > Invoices
  11. Note that the bank account row is missing currency before the dot separator
  12. Go to account settings > Wallet
  13. Go back to workspace settings > Invoices
  14. Now it shows INR before the dot separator in the bank account row

Expected Result:

In Step 11, the bank account row should show the currency after reset and restart the app

Actual Result:

In Step 11, the bank account row is missing currency after reset and restart the app.
The currency only appears after opening Wallet page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence
Bug6722176_1737666816318.20250124_050434.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Jan 23, 2025
Copy link

melvin-bot bot commented Jan 23, 2025

Triggered auto assignment to @tgolen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 23, 2025

💬 A slack conversation has been started in #expensify-open-source

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@lanitochka17
Copy link
Author

A new feature (different behavior on prod)

bandicam.2025-01-24.00-28-40-328.mp4

@mkzie2
Copy link
Contributor

mkzie2 commented Jan 24, 2025

OpenApp API is missing bankCurrency in bankAccountList:

Image

This also happens when you sign out and sign in again.

However, we can apply an improvement in the FE to only show the currency (and the dot separator) when it exists as mentioned in my proposal here #55675 (comment).

@Beamanator
Copy link
Contributor

@MonilBhavsar @shubham1206agra @DylanDylann is this NAB b/c of the same beta as #55672 (comment)?

@shubham1206agra
Copy link
Contributor

@Beamanator This is a BE bug. Can you mark this internal?

@Beamanator
Copy link
Contributor

Okkk @shubham1206agra can you explain a bit more why you say so? I may be able to help fix if i know the prob :D

@shubham1206agra
Copy link
Contributor

@Beamanator See #55674 (comment) for explanation.

@Beamanator Beamanator added the Internal Requires API changes or must be handled by Expensify staff label Jan 24, 2025
@Beamanator
Copy link
Contributor

Shmart!

@Beamanator
Copy link
Contributor

Looks like @MonilBhavsar worked that in the backend recently, maybe you want to take this over

@MonilBhavsar MonilBhavsar added Daily KSv2 and removed DeployBlockerCash This issue or pull request should block deployment Hourly KSv2 labels Jan 24, 2025
@MonilBhavsar MonilBhavsar assigned MonilBhavsar and unassigned tgolen Jan 24, 2025
@MonilBhavsar
Copy link
Contributor

Yep, feature is under beta and looks backend. I'll take over

@melvin-bot melvin-bot bot added the Overdue label Jan 27, 2025
@MonilBhavsar
Copy link
Contributor

Sent a PR

@melvin-bot melvin-bot bot removed the Overdue label Jan 28, 2025
@MonilBhavsar MonilBhavsar added the Reviewing Has a PR in review label Jan 28, 2025
Copy link

melvin-bot bot commented Feb 4, 2025

@MonilBhavsar Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@MonilBhavsar
Copy link
Contributor

PR was deployed. Closing this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Internal Requires API changes or must be handled by Expensify staff Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

6 participants