[$250] Expensify Card - Back button on Not so fast page closes RHP instead of returning to profile page

[vincdargento]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.89-2
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A https://expensify.testrail.io/index.php?/tests/view/5509731
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

• User A has a workspace with Expensify Card enabled. The workspace has at least one Expensify card.
• User B has "Limited" access (copilot) to User A account.

1. Go to staging.new.expensify.com
2. Log in as User B.
3. Go to Account settings.
4. Click on the account switcher.
5. Select User A.
6. Go to workspace settings > Members.
7. Click on any member.
8. Click + New card.
9. Click RHP back button.

Expected Result:

RHP will return to the previous page which is the member profile page.

Actual Result:

RHP closes.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021884359401351246492
• Upwork Job ID: 1884359401351246492
• Last Price Increase: 2025-01-28
• Automatic offers:
• FitseTLT | Contributor | 105969436

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[FitseTLT]

🚨 Edited by proposal-police: This proposal was edited at 2025-01-24 14:11:42 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Expensify Card - Back button on Not so fast page closes RHP instead of returning to profile page

What is the root cause of that problem?

We are dismissing modal for narrow layout case here

App/src/components/DelegateNoAccessWrapper.tsx

Lines 52 to 55 in fc199fa

	if (shouldUseNarrowLayout) {
	Navigation.dismissModal();
	return;
	}

What changes do you think we should make in order to solve the problem?

We should remove it to always goback as the default behaviour

App/src/components/DelegateNoAccessWrapper.tsx

Lines 51 to 57 in fc199fa

	onBackButtonPress={() => {
	if (shouldUseNarrowLayout) {
	Navigation.dismissModal();
	return;
	}
	Navigation.goBack();
	}}

optionally we can also goBack to the route backTo param if needed and to achieve that we can pass the backTo as a prop to DelegateNoAccessWrapper wherever needed or generally get it from the route inside DelegateNoAccessWrapper via useRoute

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

N/A

What alternative solutions did you explore? (Optional)

[melvin-bot]

@sonialiap Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021884359401351246492

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

[allroundexperts]

@FitseTLT's proposal looks good to me. The RCA is correct, and the proposed solution works fine.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @mjasikowski, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[mjasikowski]

Proposal looks good!

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

This issue has not been updated in over 15 days. @mjasikowski, @sonialiap, @allroundexperts, @FitseTLT eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[FitseTLT]

@sonialiap Can you pleas issue the payment? THX