Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page #55933

Closed
2 of 8 tasks
mitarachim opened this issue Jan 29, 2025 · 10 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2

Comments

@mitarachim
Copy link

mitarachim commented Jan 29, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

  1. Go to staging.new.expensify.com
  2. Go to workspace chat.
  3. Click + > Create expense > Scan.
  4. Upload a receipt.
  5. On confirmation page, drag and drop a file to the scan confirmation page.
  6. Repeat Step 2 to 5 with distance expense, and all the split expenses.

Expected Result:

The pointer should not have a + icon when drag and drop file to the scan and distance confirmation page when receipt cannot be added to the page.

Actual Result:

The pointer has a + icon when drag and drop file to the scan and distance confirmation page when receipt cannot be added to the page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Image
Bug6727166_1738142464689.pointer.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @strepanier03
@mitarachim mitarachim added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 DeployBlockerCash This issue or pull request should block deployment labels Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

Copy link

melvin-bot bot commented Jan 29, 2025

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot assigned MariaHCD and strepanier03 and unassigned MariaHCD Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

💬 A slack conversation has been started in #expensify-open-source

@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Jan 29, 2025
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MariaHCD
Copy link
Contributor

Looks like the PR that introduced this was reverted

@MariaHCD MariaHCD removed the DeployBlockerCash This issue or pull request should block deployment label Jan 29, 2025
@MariaHCD
Copy link
Contributor

And this will be handled in the original issue: #53089 (comment)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Hourly KSv2 labels Jan 30, 2025
@melvin-bot melvin-bot bot changed the title Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page [HOLD for payment 2025-02-06] Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page Jan 30, 2025
Copy link

melvin-bot bot commented Jan 30, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-06. 🎊

Copy link

melvin-bot bot commented Jan 30, 2025

@MariaHCD @strepanier03 @MariaHCD The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jan 31, 2025
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2025-02-06] Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page Jan 31, 2025
Copy link

melvin-bot bot commented Jan 31, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-07. 🎊

Copy link

melvin-bot bot commented Jan 31, 2025

@MariaHCD @strepanier03 @MariaHCD The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Engineering Weekly KSv2
Projects
None yet
Development

No branches or pull requests

3 participants