Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" #55942

Merged

Conversation

@mountiny mountiny changed the title Revert "Enabling Receipt drag and drop inside the confirmation step" [CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Beamanator
Copy link
Contributor Author

Straight revert, ESLint / changed files are due to previous changes fixed in reverted PR

@mountiny mountiny merged commit dbc3de5 into main Jan 29, 2025
13 of 17 checks passed
@mountiny mountiny deleted the revert-53849-enabling-receipt-drop-inside-confirm-step branch January 29, 2025 12:52
@melvin-bot melvin-bot bot added the Emergency label Jan 29, 2025
Copy link

melvin-bot bot commented Jan 29, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor

Straight revert

OSBotify pushed a commit that referenced this pull request Jan 29, 2025
…t-drop-inside-confirm-step

[CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step"

(cherry picked from commit dbc3de5)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Jan 29, 2025
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.91-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.91-2 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants