-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" #55942
[CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" #55942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Straight revert to fix at least:
- [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Pointer has a + icon when drag and drop file on scan and distance confirmation page #55933
- [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - App crashes when drag and drop a large PDF file to confirmation page #55934
- [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - No "Let it go" screen when drag and drop receipt to replace receipt on confirm page #55935
- [HOLD for payment 2025-02-07] [Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file #55937
- [HOLD for payment 2025-02-07] [HOLD for payment 2025-02-06] Expense - Can drag & drop image to replace image receipt but not pdf to replace image receipt #55938
Straight revert, ESLint / changed files are due to previous changes fixed in reverted PR |
@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
Straight revert |
…t-drop-inside-confirm-step [CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" (cherry picked from commit dbc3de5) (CP triggered by mountiny)
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.91-1 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.91-2 🚀
|
Reverts #53849
Fixed issues
$ #55933
$ #55934
$ #55935
$ #55937
$ #55938
$ #55931
QA
Please confirm these blockers are no longer reproducible: