[HOLD for payment 2025-02-07] [Due for payment 2025-02-06] Expense - No error modal when drag and drop an invalid file to replace current file

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.91-0
Reproducible in staging?: Yes
Reproducible in production?: Unable to check
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: N/A
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Money Requests

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Click + > Create expense > Manual.
4. Enter amount > Next.
5. On the confirmation page, drag and drop an invalid file format to the RHP.
6. Note that it shows error modal.
7. Drag and drop a valid file.
8. Drag and drop another valid file (to show that we can drag and drop file to replace current file).
9. Drag and drop an invalid file.

Expected Result:

App will show error modal.

Actual Result:

App does not show error modal when drag and drop an invalid file to replace current file.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6727168_1738142472297.no_error.mp4

file for step 9 (please unzip)
Bug6727168_1738142472292!AnnoyingOrangeAnimator.webp.zip

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @Beamanator (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[Beamanator]

Discussing in slack: https://expensify.slack.com/archives/C01GTK53T8Q/p1738148050803679

[Beamanator]

PR reverted & CP'd, QA should test before marking this NAB 🙏

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.91-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" #55942

If no regressions arise, payment will be issued on 2025-02-06. 🎊

[melvin-bot]

@Beamanator @RachCHopkins @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[RachCHopkins]

@Beamanator do I actually need to pay anyone here?

[Beamanator]

aah nope you're good, the PR fixing this was a straight revert so nope! 👍

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.92-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Revert "Enabling Receipt drag and drop inside the confirmation step" #55942

If no regressions arise, payment will be issued on 2025-02-07. 🎊

[melvin-bot]

@Beamanator @RachCHopkins @Beamanator The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]