[Due for payment 2025-03-05] [$250] mWeb - Account setting - Device backspace lead to main setting from avatar upload photo

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.-97-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: mWeb
App Component: User Settings

Action Performed:

1. Navigate to https://staging.new.expensify.com
2. Go to profile and upload new avatar photo or change the existing one
3. Choose a picture and in edit photo page click system backspace
4. Notice it navigate back to profile setting
5. Click Upload photo again and in edit photo page click device backspace

Expected Result:

Both Device and system backspace should return the user to profile setting

Actual Result:

Device backspace return the user to the main setting page rather than profile setting page

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6740279_1739338098088.Screen_Recording_20250212_081550_Chrome.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889864268517448396
• Upwork Job ID: 1889864268517448396
• Last Price Increase: 2025-02-13
• Automatic offers:
• thelullabyy | Contributor | 106182040

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[thelullabyy]

🚨 Edited by proposal-police: This proposal was edited at 2025-02-12 08:42:54 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

Device backspace return the user to the main setting page rather than profile setting page

What is the root cause of that problem?

We didn't use shouldHandleNavigationBack in:

App/src/components/AvatarCropModal/AvatarCropModal.tsx

Line 347 in 4c1919e

<Modal

so the logic to handle the device back button:

App/src/components/Modal/index.tsx

Lines 50 to 53 in 6000b2a

	if (shouldHandleNavigationBack) {
	window.history.pushState({shouldGoBack: true}, '', null);
	window.addEventListener('popstate', handlePopStateRef.current);
	}

which used to address the issue is not applied.

What changes do you think we should make in order to solve the problem?

Use shouldHandleNavigationBack={true} or shouldHandleNavigationBack={Browser.isMobileChrome()} in the above modal.

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

[jliexpensify]

I can't repro this on a Pixel 7, but I've heard every Android phone may have different behaviours. Going to make it External.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889864268517448396

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[dangrous]

can handle internal review on this when ready

[anigab994]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~019fd447d51af49927?s=1110580755057594368

[melvin-bot]

⚠️ Invalid email. Please make sure to create an Expensify account with this email first here.

[jliexpensify]

@alitoshmatov - will the above proposal work?

[melvin-bot]

@dangrous, @jliexpensify, @alitoshmatov Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Bumping @alitoshmatov for a review!

[alitoshmatov]

Reproduced, this is simple fix and @thelullabyy 's proposal works well. Let's go with that.

C+ reviewed 🎀 👀 🎀

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Julesssss]

Not sure why I was asssigned @dangrous without it recognising you, but feel free to remain assigned. PR can have a double review.

[melvin-bot]

📣 @thelullabyy 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dangrous]

I think it's coz I'm OOO this week. But yeah happy to review when the PR is ready

[Julesssss]

PR in review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.6-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: device back button lead to main setting #57099

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment through NewDot Manual Requests
• @thelullabyy requires payment automatic offer (Contributor)

[melvin-bot]

@alitoshmatov @jliexpensify @alitoshmatov The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]