[Due for payment 2025-02-27] [$250] Refactor convertTrackedExpenseToRequest to use a parameter object

[neil-marcellini]

As part of the tracking issue, and as advised in its description, refactor convertTrackedExpenseToRequest to use a parameter object.

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~021889740685045101882
• Upwork Job ID: 1889740685045101882
• Last Price Increase: 2025-02-27

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~021889740685045101882

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[mkzie2]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Refactor convertTrackedExpenseToRequest function to use a parameter object

What is the root cause of that problem?

This is an improvement

What changes do you think we should make in order to solve the problem?

Wrap all parameters of this function into one object and in this object, we can have some sub-objects that will wrap the related data.

App/src/libs/actions/IOU.ts

Line 4248 in 60c801c

function convertTrackedExpenseToRequest(

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

[mkzie2]

@neil-marcellini I'm here.

[mkzie2]

@neil-marcellini Sorry for the confusion, splitBill already handled to object parameter. I will start with convertTrackedExpenseToRequest function, please help to update the title and description of this issue.

[mkzie2]

@c3024 The PR is ready.

[mkzie2]

@neil-marcellini Please help to assign me to the issue.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.1-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Refactor convertTrackedExpenseToRequest function #56808

If no regressions arise, payment will be issued on 2025-02-27. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment through NewDot Manual Requests

[melvin-bot]

@c3024 @strepanier03 @c3024 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[mkzie2]

@neil-marcellini, please help assign me here for payment. Thanks.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[c3024]

This is a refactor. No checklist nor regression test is required here.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @c3024 owed $250 via NewDot

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1889740685045101882/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[strepanier03]

Payment Summary

• @c3024 owed $250 via NewDot

[strepanier03]

@c3024 - Payment summary is above. Feel free to request payment since there is no reg test or checklist needed for this one.

Closing now!

[mkzie2]

@strepanier03 I am the PR author, and I should also be paid here. Thanks!

[JmillsExpensify]

$250 approved for @c3024