-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Due for payment 2025-03-03] iOS- Reports- App returns to Inbox instead of expense report after editing expense from Report #56801
Comments
Triggered auto assignment to @lschurr ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @techievivek ( |
💬 A slack conversation has been started in #expensify-open-source |
I think this could be non-blocking but going to leave this in the list as I would consider it as a medium importance |
FYI most likely related to https://expensify.slack.com/archives/C01GTK53T8Q/p1739435484596829?thread_ts=1739328522.587109&cid=C01GTK53T8Q and we are discussing and working on solutions for this |
Hey, I'll take a look at it :) |
The new navigation structure introduced the following change: Now when we change tab within the app we always push a sidebar screen to the navigation stack (remember that it's not related to the SearchPage as On small screens tab switching is not visible when we navigate to the screen from the different tab that doesn't show the bottom bar but it's performed. Here's the video showing this flow on the wide layout, and what's happening when we are resizing it. The same flow is done on the narrow layout, so the Inbox page is also pushed to the navigation stack after redirecting to transaction thread from the Search. This should explain why we navigate to the Inbox page in this case. Screen.Recording.2025-02-13.at.15.54.25.mov |
@WojtekBoman seems like not a blocker and maybe not a bug either, going to close this one for now |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.4-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2025-03-03. 🎊 For reference, here are some details about the assignees on this issue:
|
@mountiny @lschurr @WojtekBoman The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button] |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Money Requests
Action Performed:
Expected Result:
App will return to the previous page which is the expense report.
Actual Result:
App returns to Inbox.
Workaround:
Unknown
Platforms:
Screenshots/Videos
Bug6741332_1739403385280.ScreenRecording_02-13-2025_07-33-21_1.mp4
View all open jobs on GitHub
Issue Owner
Current Issue Owner: @lschurrThe text was updated successfully, but these errors were encountered: