Company cards - App back button loops between card page and card selection page

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.4-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Workspace Settings

Action Performed:

1. Launch ND or hybrid app.
2. Create a new workspace.
3. Go to workspace settings > More features.
4. Enable Company card.
5. Go to workspace settings > Company card.
6. Tap Add cards.
7. Select American Express > Corporate Cards > Complete the rest of the flow.
8. Tap Card feed dropdown.
9. Tap app back button.
10. Tap app back button again.
11. Tap app back button.

Expected Result:

In Step 10, app back button on card feed will return to workspace settings.

Actual Result:

In Step 10, app back button on card feed returns to card selection page.
In Step 11, app back button on card selection page returns to card feed.

App back button loops between card page and card selection page.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6750496_1740186261371.ScreenRecording_02-22-2025_09-03-21_1.mp4

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @laurenreidexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @lakchote (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[huult]

Proposal

Please re-state the problem that we are trying to solve in this issue.

App back button loops between card page and card selection page

What is the root cause of that problem?

When we go back from WorkspaceCompanyCardFeedSelectorPage, it still exists in the navigation stack. When navigating back to WorkspacePageWithSections, using Navigation.goBack with an undefined parameter redirects to the previous page, which is WorkspaceCompanyCardFeedSelectorPage

App/src/pages/workspace/WorkspacePageWithSections.tsx

Line 187 in cb402cc

onBackButtonPress={() => (onBackButtonPress ? onBackButtonPress() : Navigation.goBack(backButtonRoute))}

What changes do you think we should make in order to solve the problem?

To resolve this issue, we simply clean WorkspaceCompanyCardFeedSelectorPage by using Navigation.goBack();

App/src/pages/workspace/companyCards/WorkspaceCompanyCardFeedSelectorPage.tsx

Line 83 in 037e4cc

const goBack = () => Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));

update to:

    const goBack = () => {
        Navigation.goBack();
        Navigation.navigate(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
    };

or

    const goBack = () => {
        Navigation.goBack(ROUTES.WORKSPACE_COMPANY_CARDS.getRoute(policyID));
    };

Screen.Recording.2025-02-23.at.00.39.39.mp4

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

None

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[ZhenjaHorbach]

Looks like an issue came from this PR