Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-02-25] [$250] Expensify Card - Back button on card details page opens same page after editing card details #56815

Closed
8 tasks done
IuliiaHerets opened this issue Feb 13, 2025 · 21 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 13, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.0.98-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp https://expensify.testrail.io/index.php?/tests/view/5595904
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: Mac 15.0 / Chrome
App Component: Workspace Settings

Action Performed:

Precondition:

  • User has assigned Expensify Card to a workspace member.
  1. Launch ND or hybrid app.
  2. Go to workspace settings > Members.
  3. Tap on the member with Expensify Card.
  4. Tap on the card.
  5. Tap Limit amount.
  6. Edit the amount and save it.
  7. Tap app back button.

Expected Result:

App will return to member profile page.

Actual Result:

App returns to the same card details page.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6741546_1739428382263.20250213_143232.mp4

View all open jobs on GitHub

Issue OwnerCurrent Issue Owner: @mallenexpensify
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. DeployBlockerCash This issue or pull request should block deployment labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @mallenexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 13, 2025

Triggered auto assignment to @Gonals (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Hourly KSv2 labels Feb 13, 2025
Copy link

melvin-bot bot commented Feb 13, 2025

💬 A slack conversation has been started in #expensify-open-source

@mountiny mountiny assigned mountiny and unassigned Gonals Feb 13, 2025
@mountiny mountiny added Hourly KSv2 and removed Daily KSv2 labels Feb 13, 2025
@mountiny
Copy link
Contributor

Related to navigation changes we are discussing here https://expensify.slack.com/archives/C01GTK53T8Q/p1739328522587109 its is quite minor but it should also be a quick fix so keeping it as a blocker

@mananjadhav
Copy link
Collaborator

I can see the PR is raised and assigned to me. Should I go ahead and review it?

@SzymczakJ
Copy link
Contributor

It's up to Vit, I think we want to merge the navigation fixes pretty fast, so that the nav PR is not reverted.
I didn't manage to make recordings for every platform, but tested this pretty robustly.

@mananjadhav
Copy link
Collaborator

@SzymczakJ I reviewed the code, but can you fix the lint issues?

@Julesssss
Copy link
Contributor

FYI I cloned the PR to resolve a conflict and merged it here.

@Julesssss
Copy link
Contributor

@Julesssss Julesssss removed the DeployBlockerCash This issue or pull request should block deployment label Feb 15, 2025
@mountiny mountiny changed the title Expensify Card - Back button on card details page opens same page after editing card details [$250] Expensify Card - Back button on card details page opens same page after editing card details Feb 17, 2025
Copy link

melvin-bot bot commented Feb 17, 2025

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@mountiny mountiny added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 17, 2025
@mountiny
Copy link
Contributor

$250 to @mananjadhav

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 18, 2025
@melvin-bot melvin-bot bot changed the title [$250] Expensify Card - Back button on card details page opens same page after editing card details [Due for payment 2025-02-25] [$250] Expensify Card - Back button on card details page opens same page after editing card details Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.99-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-02-25. 🎊

For reference, here are some details about the assignees on this issue:

  • @mananjadhav requires payment through NewDot Manual Requests
  • @SzymczakJ does not require payment (Contractor)

Copy link

melvin-bot bot commented Feb 18, 2025

@mananjadhav @mallenexpensify @mananjadhav The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

Copy link

melvin-bot bot commented Feb 20, 2025

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Feb 23, 2025
Copy link

melvin-bot bot commented Feb 25, 2025

Payment Summary

Upwork Job

  • Reviewer: @mananjadhav owed $250 via NewDot
  • Contributor: @SzymczakJ is from an agency-contributor and not due payment

BugZero Checklist (@mallenexpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@melvin-bot melvin-bot bot added the Overdue label Feb 25, 2025
@mananjadhav
Copy link
Collaborator

BugZero Checklist:

  • [Contributor] Classify the bug:
Bug classification

Source of bug:

  • 1a. Result of the original design (eg. a case wasn't considered)
  • 1b. Mistake during implementation
  • 1c. Backend bug
  • 1z. Other:

Where bug was reported:

  • 2a. Reported on production (eg. bug slipped through the normal regression and PR testing process on staging)
  • 2b. Reported on staging (eg. found during regression or PR testing)
  • 2d. Reported on a PR
  • 2z. Other:

Who reported the bug:

  • 3a. Expensify user
  • 3b. Expensify employee
  • 3c. Contributor
  • 3d. QA
  • 3z. Other:

@mananjadhav
Copy link
Collaborator

@mallenexpensify Can you please post the payment summary as per the comment?

@mallenexpensify
Copy link
Contributor

Contributor+: @mananjadhav due $250 via NewDot

@garrettmknight
Copy link
Contributor

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering
Projects
None yet
Development

No branches or pull requests

8 participants