Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Due for payment 2025-03-05] [$125] Settings - Android and iOS app download links are invalid #57010

Open
3 of 8 tasks
IuliiaHerets opened this issue Feb 18, 2025 · 15 comments
Open
3 of 8 tasks
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2

Comments

@IuliiaHerets
Copy link

IuliiaHerets commented Feb 18, 2025

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 9.1.0-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Issue reported by: Applause Internal Team
Device used: Windows 10 / Chrome, macOS Sequoia 15.0, Apple iPhone 12 Pro / Safari
App Component: User Settings

Action Performed:

  1. In Chrome incognito mode, navigate to https://staging.new.expensify.com/
  2. Log in with a Gmail account
  3. Navigate to Settings - About - App download links
  4. Click on "Android"
  5. Navigate back to the Expensify tab
  6. Click on "iOS"

Expected Result:

Both links should pointing the user to the correct hybrid app download option.

Android link: https://play.google.com/store/apps/details?id=org.me.mobiexpensifyg
iOS mobile link: https://apps.apple.com/us/app/expensify-travel-expense/id471713959

Actual Result:

Android and iOS app download links are invalid. "We're sorry, the requested URL was not found on this server." error on Google Play, endless "Connecting..." message on Apple Store. The Android one can only be repro in incognito mode, it loads correctly in a normal Chrome window.

Workaround:

Unknown

Platforms:

  • Android: Standalone
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: Standalone
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Bug6746563_1739875487893.bandicam_2025-02-18_11-33-25-535.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~021891919586470867600
  • Upwork Job ID: 1891919586470867600
  • Last Price Increase: 2025-02-18
  • Automatic offers:
    • mkzie2 | Contributor | 106205515
Issue OwnerCurrent Issue Owner: @sonialiap
@IuliiaHerets IuliiaHerets added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@mkzie2
Copy link
Contributor

mkzie2 commented Feb 18, 2025

Proposal

Please re-state the problem that we are trying to solve in this issue.

Android and iOS app download links are invalid. "We're sorry, the requested URL was not found on this server." error on Google Play, endless "Connecting..." message on Apple Store. The Android one can only be repro in incognito mode, it loads correctly in a normal Chrome window.

What is the root cause of that problem?

The NewDot App was deleted on GooglePlay and AppStore.

App/src/CONST.ts

Lines 533 to 534 in 6471df9

ANDROID: `https://play.google.com/store/apps/details?id=${ANDROID_PACKAGE_NAME}`,
IOS: 'https://apps.apple.com/us/app/expensify-cash/id1530278510',

What changes do you think we should make in order to solve the problem?

We need to update the ANDROID_PACKAGE_NAME and IOS link here to the Hybird App link. That can be provided by the team.

const ANDROID_PACKAGE_NAME = 'org.me.mobiexpensifyg';
IOS: 'https://apps.apple.com/us/app/expensify-travel-expense/id471713959', 

App/src/CONST.ts

Lines 533 to 534 in 6471df9

ANDROID: `https://play.google.com/store/apps/details?id=${ANDROID_PACKAGE_NAME}`,
IOS: 'https://apps.apple.com/us/app/expensify-cash/id1530278510',

What specific scenarios should we cover in automated tests to prevent reintroducing this issue in the future?

NA

What alternative solutions did you explore? (Optional)

Result

Screen.Recording.2025-02-18.at.18.34.33.mov

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

@sonialiap sonialiap added the External Added to denote the issue can be worked on by a contributor label Feb 18, 2025
@melvin-bot melvin-bot bot changed the title Settings - Android and iOS app download links are invalid [$250] Settings - Android and iOS app download links are invalid Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Job added to Upwork: https://www.upwork.com/jobs/~021891919586470867600

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

@sonialiap sonialiap changed the title [$250] Settings - Android and iOS app download links are invalid [$125] Settings - Android and iOS app download links are invalid Feb 18, 2025
Copy link

melvin-bot bot commented Feb 18, 2025

Upwork job price has been updated to $125

@sonialiap
Copy link
Contributor

I've updated the OP with the correct mobile links

@parasharrajat
Copy link
Member

parasharrajat commented Feb 18, 2025

@mkzie2's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

Copy link

melvin-bot bot commented Feb 18, 2025

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@parasharrajat
Copy link
Member

Bump @jasperhuangg for review.

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 20, 2025
Copy link

melvin-bot bot commented Feb 20, 2025

📣 @mkzie2 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Feb 21, 2025
@mkzie2
Copy link
Contributor

mkzie2 commented Feb 21, 2025

@parasharrajat The PR is ready.

@dylanexpensify dylanexpensify moved this to Bugs and Follow Up Issues in [#whatsnext] #expense Feb 25, 2025
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Feb 26, 2025
@melvin-bot melvin-bot bot added the Awaiting Payment Auto-added when associated PR is deployed to production label Feb 26, 2025
@melvin-bot melvin-bot bot changed the title [$125] Settings - Android and iOS app download links are invalid [Due for payment 2025-03-05] [$125] Settings - Android and iOS app download links are invalid Feb 26, 2025
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Feb 26, 2025
Copy link

melvin-bot bot commented Feb 26, 2025

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Feb 26, 2025

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.5-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2025-03-05. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Feb 26, 2025

@parasharrajat @sonialiap @parasharrajat The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

@parasharrajat
Copy link
Member

parasharrajat commented Feb 28, 2025

No checklist is needed for this. It is just links change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. External Added to denote the issue can be worked on by a contributor Weekly KSv2
Projects
Status: Bugs and Follow Up Issues
Development

No branches or pull requests

5 participants