[HOLD 57607] Reports - Menu does not close after opening saved search

[mitarachim]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.1.1.0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Yes, reproducible on both
If this was caught during regression testing, add the test name, ID and link from TestRail: Exp
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team
Device used: iPhone 15 Pro Max / iOS 18.3
App Component: Search

Action Performed:

Precondition:

• Account has a saved search.

1. Launch ND or hybrid app.
2. Go to Reports.
3. Tap on the bookmark icon.
4. Tap on the saved search.

Expected Result:

When tapping on the saved search, the menu will close.

Actual Result:

When tapping on the saved search, the menu does not close.
It only closes when tapping on it for the second time.

Workaround:

Unknown

Platforms:

• Android: Standalone
• Android: HybridApp
• Android: mWeb Chrome
• iOS: Standalone
• iOS: HybridApp
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6747425_1739937587358.ScreenRecording_02-19-2025_11-52-52_1.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @sumo-slonik

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

💬 A slack conversation has been started in #expensify-open-source

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[sumo-slonik]

Hi, I'm Kuba from SWM and I can take care of it.

[sumo-slonik]

I'm sending a PR that fixes this issue:
#57105

[luacmartins]

This is also reproducible in production https://expensify.slack.com/archives/C01GTK53T8Q/p1739943966639889

[luacmartins]

@sumo-slonik I investigated this a bit and traced it down to the navigation action for all menu items, not only saved search, e.g. removing this action makes the menu perform correctly -

App/src/components/Search/SearchPageHeader/SearchTypeMenuPopover.tsx

Line 141 in 82b5de0

Navigation.navigate(item.getRoute(policyID));

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.1.3-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix saved search no hiding modal #57105

If no regressions arise, payment will be issued on 2025-02-28. 🎊

For reference, here are some details about the assignees on this issue:

• @sumo-slonik does not require payment (Contractor)
• @ishpaul777 requires payment through NewDot Manual Requests

[melvin-bot]

@ishpaul777 @Christinadobrzyn @ishpaul777 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[sumo-slonik]

This afternoon I will create a PR with POC.

[luacmartins]

Thanks @sumo-slonik

[sumo-slonik]

Pr is ready and I've attached the skis to see if this behavior is ok:
https://github.com/Expensify/App/pull/57327/files
If it looks okay, I'll make sure all PR checks pass.

[Christinadobrzyn]

Is payment really 2-28? It looks like the PR might still be drafted. Is that true?

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @sumo-slonik is from an agency-contributor and not due payment
• Reviewer: @ishpaul777 owed $250 via NewDot

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Hi @sumo-slonik and @ishpaul777 are we waiting for this PR - https://github.com/Expensify/App/pull/57327/files to be complete before paying this out?

If not and we're ready to pay, do we need a regression test for #57105

[ishpaul777]

I beleive the issue was different and had unrelated root cause from our PR, so I think no need to hold on that.

[luacmartins]

I think we should since the menu is still not fully responsive and that PR is also solving this issue.

[Christinadobrzyn]

It looks like that PR was closed in favor of #57607.

Based on this it sounds like we'll hold this for 57607 to make sure everything is working properly after the deploy. Let me know if that's not correct. Thanks!