[HOLD for payment 2021-11-29] Log in - Bottom footer is not bottom aligned - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open New Expensify on mobile

Expected Result:

The footer should be bottom aligned

Actual Result:

Footer is not bottom aligned

Workaround:

No need, visual issues.

Platform:

Where is this issue occurring?

• iOS
• Android

Version Number: 1.1.12-3

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Expected behaviour confirmed here #5159 (comment)

Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1635817319324000

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @chiragsalian (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[MelvinBot]

Triggered auto assignment to @MitchExpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[chiragsalian]

Odd, i only try to unassign myself but it removes the other assignee too. Maybe i'm doing it too fast.

Anyway, this should be a straightforward external issue.

[MitchExpensify]

Upwork job

[MelvinBot]

Triggered auto assignment to @luacmartins (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[parasharrajat]

Proposal

1. I am already fixing other issues with the login page.
2. One such issue is here https://expensify.slack.com/archives/C01GTK53T8Q/p1635499712244400.
   In this fix: LoginPage for wide screens #6137.

That PR modifies the Login Page on wide screens currently, I will extend that to the Narrow screen Login page as well. and fix it.

It requires manipulating the UI elements to achieve the best results but I haven't started on it so I can't exactly tell how will the UI look in this proposal.

Updates

1. We need to change styling for Scrollbar and the KeyboardAvoidingView to allow it to expand the whole page.
   

   App/src/pages/signin/SignInPageLayout/SignInPageLayoutNarrow.js

   Line 34 in 19fcbd7

   contentContainerStyle={styles.ph5}

It will look like

    <ScrollView
        keyboardShouldPersistTaps="handled"
        showsVerticalScrollIndicator={false}
        style={[
            styles.flexGrow1,
            styles.signInPageNarrowContentContainer,
            styles.alignSelfCenter,
        ]}
        contentContainerStyle={[styles.ph5, styles.flex1]}  <==== updated
    >
        <KeyboardAvoidingView
            behavior="position"
            style={[                         <==== updated
                styles.flex1,
                styles.w100,
                styles.mt40Percentage,
                styles.alignSelfCenter,
            ]}
        >

KeyboardAvoidingView consumes the child View and that View is not needed anymore

.

[luacmartins]

@parasharrajat Let me know when you have a more concrete solution here so I can green-light it.

[parasharrajat]

Ok. @luacmartins Updated.

[luacmartins]

@parasharrajat Thanks! Proposal looks good, please apply to the Upwork job.

@MitchExpensify let's hire @parasharrajat for this job.

[MitchExpensify]

Please submit a proposal in Upwork and I will hire you @parasharrajat (There is a bug on my end when I'm trying to hire you without a proposal being submitted)

[parasharrajat]

@MitchExpensify Done.

[MitchExpensify]

Hired!

[luacmartins]

PR merged!

[puneetlath]

@MitchExpensify can you add a $250 bonus for @parasharrajat when paying this issue out since his PR also fixed #6202. Thanks!

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.15-15 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix footer position on the login page in mobile View #6203

If no regressions arise, payment will be issued on 2021-11-29. 🎊

[parasharrajat]

Ping for

@MitchExpensify

[MitchExpensify]

Paid with reporting bonus!

[parasharrajat]

@MitchExpensify You might have missed this #6175 (comment).

[MitchExpensify]

I did miss that, thanks @parasharrajat. Applying that bonus now