[HOLD for payment 2021-12-15] Change password - Extra gap under validation button - Reported by: @parasharrajat

[isagoico]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Navigate to Settings
Click on profile
Click on add phone number (secondary log in)
Check the button with dev tools

Expected Result:

Button area should only be consistent all around the button

Actual Result:

There's a empty gap below the button.

Workaround:

None needed.

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.1.16-10

Reproducible in staging?: Yes
Reproducible in production?: Yes

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:

Issue reported by: @parasharrajat
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1637865439012200

View all open jobs on GitHub

[MelvinBot]

Triggered auto assignment to @MariaHCD (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[isagoico]

Looks like it's the same issue for this button as - #6460. Created this issue separately, according to @parasharrajat it can be fixed in the same PR fix as the issue mentioned in this comment.

[parasharrajat]

Proposal

1. Remove the extra margin from the button

   App/src/pages/settings/PasswordPage.js

   Line 239 in 85d9a21

   style={[styles.mb2]}

FixedFooter already handles the correct gapping.

---

From the @isagoico Comment,
I think I can solve this into the same PR for #6460 Already Merged but I asked her to create a separate ticket as this was not known to us when 6460 was found. and As I come to know of this later while fixing some other issue. So this should be considered separate (Looking at the history of issues we have).

[MelvinBot]

@MariaHCD Whoops! This issue is 2 days overdue. Let's get this updated quick!

[MelvinBot]

@MariaHCD Huh... This is 4 days overdue. Who can take care of this?

[MelvinBot]

@MariaHCD Still overdue 6 days?! Let's take care of this!

[parasharrajat]

@mallenexpensify Could you please triage this? Maria seems to be OOO.

[MelvinBot]

Triggered auto assignment to @adelekennedy (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[mallenexpensify]

I'm going to go out on a limb and say this can be worked on by a contributor...
@adelekennedy I posted for ya cuz it's 5pm on a Friday and I wanted to get a CME assigned to review Rajat's proposal above

[MelvinBot]

Triggered auto assignment to @parasharrajat (Exported)

[MelvinBot]

Triggered auto assignment to @stitesExpensify (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shoaibzkhalid]

Proposal

1. Remove the margin bottom to get rid of the unnecessary space below the button

App/src/pages/settings/PasswordPage.js

Line 239 in 85d9a21

style={[styles.mb2]}

[deetergp]

We have a similar issue for the secondary login page, and the fix for it is the same as the fix for this that @parasharrajat had already suggested. Let's have him fix both.

[adelekennedy]

@parasharrajat and @deetergp I can open and hire Rajat for this job, or, we can add a bonus to the other issue - thoughts?

[deetergp]

If the end amount is the same for @parasharrajat, then I'm in favor of whichever has less administrative overhead, but Rajat may have different thoughts, so I will defer to him.

[parasharrajat]

I think opening a job for this is fine. In the end, it becomes confusing to manage multiple issues in one. Also, I will be submitting a new PR for this. The other one is already merged. @adelekennedy

We already have it https://www.upwork.com/jobs/~01478dd14ed4b583ec . You can hire me there.

[parasharrajat]

Submitted the proposal on https://www.upwork.com/jobs/~01478dd14ed4b583ec

[adelekennedy]

@parasharrajat Hired herein this case I assume we'd still pay out the reporting bonus for this job as well?

[botify]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.1.18-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: margin for Save button on Password page #6600

If no regressions arise, payment will be issued on 2021-12-15. 🎊

[adelekennedy]

Paid!

[parasharrajat]

@adelekennedy Will, there be a reporting bonus as well?