Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android - Chat - Infinite loading spinner appears when adding PDF attachment #7267

Closed
kavimuru opened this issue Jan 16, 2022 · 20 comments
Closed
Assignees
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open app and login
  2. Open any chat
  3. Tap on + > Add Attachment >
  4. Select "choose document" and attach a PDF
  5. Tap send in preview modal

Expected Result:

PDF file should upload

Actual Result:

Infinite loading spinner appears and never gets added

Workaround:

Unknown

Platform:

Where is this issue occurring?

  • Android

Version Number: 1.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: No
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5409742_20220116_103712__1_.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@kavimuru kavimuru added the DeployBlockerCash This issue or pull request should block deployment label Jan 16, 2022
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@MelvinBot
Copy link

Triggered auto assignment to @mountiny (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@mountiny
Copy link
Contributor

Identified a potential culprit PR and left a comment there for involved developers if they are able to help: #4908

@kidroca
Copy link
Contributor

kidroca commented Jan 17, 2022

Submitted a regression fix: #7277

  1. Identify the pull request that introduced this issue and revert it.

Maybe we should include a point dealing with PRs that introduce a migration
If such a merge request is reverted it might cause problems as any migrations run won't be reversed

@mountiny
Copy link
Contributor

That is a good point @kidroca.

Thank you very much for digging into this!

@mountiny mountiny added the Reviewing Has a PR in review label Jan 17, 2022
@mountiny
Copy link
Contributor

@kavimuru @mvtglobally The fix has been deployed to staging, would you be please able to re-test this?

Thank you very much! 🙇

@mountiny mountiny removed the DeployBlockerCash This issue or pull request should block deployment label Jan 17, 2022
@mountiny mountiny added the External Added to denote the issue can be worked on by a contributor label Jan 17, 2022
@MelvinBot
Copy link

Triggered auto assignment to @michaelhaxhiu (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@MelvinBot MelvinBot added Daily KSv2 and removed Hourly KSv2 labels Jan 17, 2022
@mountiny mountiny added Weekly KSv2 and removed Daily KSv2 labels Jan 17, 2022
@mountiny
Copy link
Contributor

@michaelhaxhiu I made this issue External, but Kidroca has already fixed this and he is now working on a follow-up solution in the external library, which will, even more, improve our codebase.

I am not sure how exactly his contract works but as per this comment, Kidroca will track time working on that fix under this issue.

@kidroca do we need to export this job and assign it to you on Upwork too?

@kidroca
Copy link
Contributor

kidroca commented Jan 17, 2022

@kidroca do we need to export this job and assign it to you on Upwork too?

No, typically I reference the issue I was assigned and worked on in my hourly

This task would take about an hour, and looks like a PR would be welcomed: react-native-documents/document-picker#526 (comment)

@mountiny
Copy link
Contributor

@kidroca Sounds great then! Thank you for working on this!

@kidroca
Copy link
Contributor

kidroca commented Jan 18, 2022

PR Ready: react-native-documents/document-picker#527

@kidroca
Copy link
Contributor

kidroca commented Jan 20, 2022

PR was merged and a new version (8) with the change is available.
I'll open a PR to update our RN document picker version and remove our temp fix

@mountiny
Copy link
Contributor

Thank you @kidroca!

@kidroca
Copy link
Contributor

kidroca commented Jan 20, 2022

PR to update App's version is ready: #7338

@mvtglobally
Copy link

Issue not reproducible during KI retests. (First week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Second week)

@mvtglobally
Copy link

Issue not reproducible during KI retests. (Third week)

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2022

What is the general rule for KI retests? At what point are we happy to close the issue? @mvtglobally Thank you :)

@mvtglobally
Copy link

@mountiny typically we close after third no-repro.
But in case of the "external" label and when comments have some fix mentioned, there is typically payment involved, so I wait another week (to process payments if any). If you think this is good to close, let me know

@mountiny
Copy link
Contributor

mountiny commented Feb 8, 2022

@mvtglobally Ah! Thank you very much for explanation!

In case of @kidroca, he works on hourly basis, therefore we are good to close this issue, they will be paid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Engineering External Added to denote the issue can be worked on by a contributor Reviewing Has a PR in review Weekly KSv2
Projects
None yet
Development

No branches or pull requests

7 participants