Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update React Native document picker to v8 #7338

Merged
merged 4 commits into from
Jan 20, 2022

Conversation

kidroca
Copy link
Contributor

@kidroca kidroca commented Jan 20, 2022

Details

We've submitted a PR to fix an issue with RN document picker: react-native-documents/document-picker#527 and it was merged

Fixed Issues

$ #7267

Tests

  • Verify adding document attachments works and uploads the selected document

QA Steps

  • Verify adding document attachments works and uploads the selected document

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

Screen.Recording.2022-01-20.at.21.52.55.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2022-01-20.21-03-12.mp4

@kidroca kidroca marked this pull request as ready for review January 20, 2022 20:26
@kidroca kidroca requested a review from a team as a code owner January 20, 2022 20:26
@botify botify requested a review from mountiny January 20, 2022 20:26
@MelvinBot MelvinBot removed the request for review from a team January 20, 2022 20:26
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! I really appreciate you have followed up on this issue. Great to work with you!

@mountiny mountiny merged commit 520db47 into Expensify:main Jan 20, 2022
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @mountiny in version: 1.1.31-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants