Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2022-01-20 #7347

Closed
20 of 33 tasks
OSBotify opened this issue Jan 20, 2022 · 13 comments
Closed
20 of 33 tasks

Deploy Checklist: New Expensify 2022-01-20 #7347

OSBotify opened this issue Jan 20, 2022 · 13 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 20, 2022

@mvtglobally
Copy link

Starting QA

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 21, 2022
@mvtglobally
Copy link

Regression is complete
#7331 is failing due to #7360
#7211 is internal QA

Issues logged
#7365
#7360
#7361

@mvtglobally
Copy link

@AndrewGable let us know if we are good to check off #7331. Hopefully, we can get a new build today.

@AndrewGable
Copy link
Contributor

Is #7360 a deploy blocker since it was found testing #7331?

@mvtglobally
Copy link

@AndrewGable because feature is not fully in PROD, we were asked not to add Blocker label even if its failing PR. But since this one we can't properly check in PROD even later, I feel you should take a second look and decide.

@AndrewGable
Copy link
Contributor

Added deploy blocker label for now.

@mvtglobally
Copy link

retesting #7331
Checking off #7211 (comment)

@AndrewGable
Copy link
Contributor

Thank you @mvtglobally - Let me know when all QA is checked off and I can kick off a deploy.

@mvtglobally
Copy link

@AndrewGable I feel we are good to go.

Checking off #7339, retest is Pass
Checking off #7331 as the bank is setup is working
We found another issue on clicking disconnect, but since this is behind Beta we can log it as the new Checklist is created. Let me know what you think

Recording.132.mp4

@AndrewGable
Copy link
Contributor

Looks good to me! Going to do one last test here to do some testing with the checkboxes, so ignore the messages from the bots for one moment.

@AndrewGable
Copy link
Contributor

:shipit:

@OSBotify
Copy link
Contributor Author

This issue either has unchecked QA steps or has not yet been marked with the :shipit: emoji of approval.
Reopening!

@OSBotify OSBotify reopened this Jan 25, 2022
@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

4 participants