[$250] IOS - Build against iOS 15 in ~1 month or the app will be auto-rejected cc

[mvtglobally]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Check IOS app SDK Version

Expected Result:

IOS 15+ SDK should be used for the Expensify app

Actual Result:

IOS 14.5 SDK is used for the Expensify app

Workaround:

unknown

Platform:

Where is this issue occurring?

• iOS

Version Number: 1.1.44-4
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Expensify/Expensify Issue URL:
Issue reported by: @AndrewGable
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1648137460915479

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @danieldoglas (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[danieldoglas]

Moved this to external.

[jliexpensify]

Posted:

• Internal: https://www.upwork.com/ab/applicants/1512285496911982592/job-details
• External: https://www.upwork.com/jobs/~01fe244a40dd2dfb79

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (Exported)

[melvin-bot]

Triggered auto assignment to @Julesssss (Exported), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Julesssss]

Awaiting proposals.

[dharmik]

Proposal & Information @Julesssss

File: .github/workflows/platformDeploy.yml

-   DEVELOPER_DIR: /Applications/Xcode_12.5.1.app/Contents/Developer
+   DEVELOPER_DIR: /Applications/Xcode_13.2.1.app/Contents/Developer

Main context we have to release iOS application with iOS 15 SDKs

Official Information
App Store submission requirement starts April 25

• From who ever's machine we are releasing iOS application we need to verify is Xcode version is 13 or later.
  ==> open Xcode ==> Top menu item click on Xcode ==> Click on About Xcode

• Version must be 13 or later as I attached in screenshot.

• If after updating Xcode and if we want to check iOS SDK version open terminal and write command xcodebuild -showsdks

Outcome:
If we generate release iOS ipa file will above configuration this email/message ITMS-90725: SDK Version Issue will not come.

I have Xcode version is 13 or later with latest SDK so let me know if we want to upload ipa file from my machine.

Only option we have is just update Xcode version.

[parasharrajat]

@dharmik I think you misunderstood the issue. Here we wants someone to update the target SDK version on the plist file and corresponding configurations and set up the project so that it will successfully build.

Let's me your proposal for doing that. The deployment will be taken care of internally.

[dharmik]

@parasharrajat Are you talking about to change iOS Deployment Target? Please correct me if I misunderstood something.

If you need someone to do, I will do that.

[parasharrajat]

Yup, I think that is the one. I don't know much about iOS but that should be it.

[dharmik]

@parasharrajat
https://user-images.githubusercontent.com/43995119/161472375-1924737e-5479-4f65-b25f-cd8f1fd4d877.png

We are planning to resolve above informative message which came in email while recently we release application. To resolve this per my proposal we have to stay updated or build application with minimum SDK which is iOS 15 and iOS 15 will be support in Xcode 13 or later so if we generate a build from this configuration it will not give us that email again.

CC @Julesssss

[parasharrajat]

Sounds good. Let's go with that. We have to inform everyone to upgrade their Xcode version. For some of them, it will be hard to do as it may require an OS upgrade. So informing early will be good.

cc: @Julesssss

🎀 👀 🎀 C+ reviewed

[jliexpensify]

Bump @Julesssss for approval!

I'll be re-assigning this as I am OOO until the 30th.

[parasharrajat]

Yup. Also, in the PR attach videos for successful build on Xcode 13.

[dharmik]

Yup. Also, in the PR attach videos for successful build on Xcode 13.

Do you want me to generate successful build from pipeline or from Xcode? @parasharrajat

[dharmik]

Proposal Updated. @AndrewGable

[parasharrajat]

Do you want me to generate a successful build from the pipeline or from Xcode?

From Xcode(preferably same version as platformDeploy.xml)

[AndrewGable]

Yes, version of XCode built locally must match the code change.

[dharmik]

@AndrewGable @parasharrajat Is it what we are expecting in video?

Screen.Recording.2022-04-21.at.2.53.04.AM.mov

Mine current xcode version:

[AndrewGable]

You are going to have to show in video that your changes did not introduce any regressions to the iOS app.

[dharmik]

@parasharrajat @AndrewGable PR created.
#8738

[AndrewGable]

FYI - Once this is deployed to staging, I can verify that the email is or is not sent via apple.

[dharmik]

@AndrewGable Sure, Please.

[Julesssss]

Okay, thanks for the PR.

I can't believe I'm saying this, but compiling the app from the newer XCode/iOS sdk worked first time, I was expecting this to be a nightmare to test with all sorts of local compile issues 😆

[dharmik]

@Julesssss If all well can we merge that PR?

[Julesssss]

Yep, just running a few more tests. I used to have two XCode installations (one for the old app, one for the new one), so I'm just confirming all is good after switching to a single app.

[Julesssss]

Merged.

[Julesssss]

Awaiting deploy

[dharmik]

@Julesssss Is there something pending to test for this issue?

[Julesssss]

For now we're awaiting deployment to production

[dharmik]

@Julesssss I am new so after this only @jliexpensify can to completed project from upwork?

[Julesssss]

Oh, sorry. Yes, once the issue is deployed to production there will be an automated message here in the issue to let us know you should be paid.

[arielgreen]

Still awaiting deploy

[arielgreen]

@dharmik paid
@parasharrajat hired for PR review in Upwork, once you accept I'll remit payment

[arielgreen]

Paid.