Fix Issue 9253: Previous chat username is displayed when you navigate back from different chat #10069

ntdiary · 2022-07-24T10:20:35Z

Details

Proposal option 1
Just show blank page when backing

Fixed Issues

$ #9253

Tests

This problem only occurs on mobile web platform.

Go to localhost:8080
Log in with an account that has multiple chats.
Open any chat.
Add a new tab and go to localhost:8080 ( you have logged in in the step 2 ).
Open a different chat from step 3.
Click the browser's back button ( or use the back gesture in android platform)

Verify that no errors appear in the JS console

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

QA Steps

This problem only occurs on mobile web platform.

Go to staging.new.expensify.com
Log in with an account that has multiple chats.
Open any chat.
Add a new tab and go to staging.new.expensify.com ( you have logged in in the step 2 ).
Open a different chat from step 3.
Click the browser's back button ( or use the back gesture in android platform)

Verify that no errors appear in the JS console

Screenshots

Web

macos-chrome.mp4

Mobile Web

android chrome

android-chrome.mp4

ios safari

ios-safari.mp4

Desktop

macos-desktop.mp4

iOS

ios-native.mp4

Android

android-native.mp4

github-actions · 2022-07-24T10:20:52Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

ntdiary · 2022-07-24T10:22:25Z

I have read the CLA Document and I hereby sign the CLA

mananjadhav

Changes look fine. Thanks for the signed commit @ntdiary.

I had troubles with reproducing this even back then. Do you have anything specific in the QA steps that makes it easier for me or the QA to reproduce the issue?

ntdiary · 2022-07-26T03:43:02Z

Hi @mananjadhav, I'll try to demonstrate it in Chrome Device Mode to better explain the steps,
this is similar to Safari and Android Chrome.
Please feel free to let me know if there is anything unclear. 🙂

Make sure you are logged out in browser.
Add a New Tab
Open the Chrome Dev Tools and Device Mode like this
Enter the URL in the address bar such as localhost:8080, and login the account
And now, the current URL is http://localhost:8080/r/96188031 96188031 in the URL path represents the report ntdiary+1 (we can see it on the right panel), we should avoid opening this report in the step 7 .
Click Reload Button to refresh this page
Click another report except the ntdiary+1. Here I chose the [email protected], and then URL changed to this http://localhost:8080/r/96403444.
Click the back button here
now the URL immediately changed back to the original path http://localhost:8080/r/96188031, the page was first rendered as the contents of ntdiary+1, and then back to the chat list like this

demo.mp4

ntdiary · 2022-07-28T15:19:38Z

Hi, this might be an easier way ( in mobile web ):

Go to staging.new.expensify.com
Log in with an account that has multiple chats.
Open any chat.
Add a new tab and go to staging.new.expensify.com ( you have logged in in the step 2 ).
Open a different chat from step 3.
Click the browser's back button ( or use the back gesture in android platform), we'll see the previous username in a moment

ntdiary · 2022-08-04T12:38:38Z

Hi, @mananjadhav, can you reproduce the issue with the latest steps? 🙂

mananjadhav · 2022-08-09T19:27:33Z

I was OOO last week, getting to this by tomorrow. Can you please resolve conflicts @ntdiary meanwhile? thank you for your patience on this one.

ntdiary · 2022-08-10T02:31:55Z

@mananjadhav resolved. 🙂

mananjadhav · 2022-08-10T02:36:51Z

@mananjadhav resolved. 🙂

Right on time. Thanks, just pulled your changes to review and test. Will send an update soon.

Can you reproduce the issue with the latest steps?

Thanks @ntdiary, these steps are much clearer and reproducible. Appreciate it.

mananjadhav · 2022-08-10T13:30:51Z

@AndrewGable I tested this on iOS Simulator Safari for mWeb. (tested on all platforms). Changes look fine.

The only thing I am not sure if contextType will have any impact anywhere. @AndrewGable if you can help with that once, it'll be great.

🎀 👀 🎀
C+ reviewed

PR Reviewer Checklist

The Contributor+ will copy/paste it into a new comment and complete it after the author checklist is completed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by tagging the marketing team on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- Any functional components have the displayName property
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

mananjadhav

LGTM

OSBotify · 2022-08-10T16:34:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

marcaaron · 2022-08-22T14:03:24Z

Hey! I came across this change because I am working on an issue to refresh the report on network reconnect when the sidebar is open. This solution has an issue where it breaks some existing behavior since it forces the report page to unmount when the sidebar is revealed. There is quite a bit of code in ReportActionsView that expects the report the stay mounted and not get unmounted. This code in particular does not seem like the behavior we want.

App/src/pages/home/ReportScreen.js

Lines 203 to 205 in a70aa0c

    
           if (this.props.isSmallScreenWidth && this.context === 'open') { 
        
               return null; 
        
           }

ntdiary · 2022-08-23T06:17:55Z

Hi, sorry for that, I didn't expect such a problem.
If we want to keep the child component mounted, we can use visibility, like this:

diff --git a/src/pages/home/ReportScreen.js b/src/pages/home/ReportScreen.js
index e46a4ed27..ea09a4eb0 100644
--- a/src/pages/home/ReportScreen.js
+++ b/src/pages/home/ReportScreen.js
@@ -198,9 +198,7 @@ class ReportScreen extends React.Component {
             return null;
         }

-        if (this.props.isSmallScreenWidth && this.context === 'open') {
-            return null;
-        }
+        const visibility = (this.props.isSmallScreenWidth && this.context === 'open') ? styles.visibilityHidden : {};

         // We let Free Plan default rooms to be shown in the App - it's the one exception to the beta, otherwise do not show policy rooms in product
         if (!Permissions.canUseDefaultRooms(this.props.betas)
@@ -221,7 +219,7 @@ class ReportScreen extends React.Component {
             reportClosedAction = lodashFindLast(this.props.reportActions, action => action.actionName === CONST.REPORT.ACTIONS.TYPE.CLOSED);
         }
         return (
-            <ScreenWrapper style={[styles.appContent, styles.flex1, {marginTop: this.state.viewportOffsetTop}]}>
+            <ScreenWrapper style={[styles.appContent, styles.flex1, {marginTop: this.state.viewportOffsetTop}, visibility]}>
                 <HeaderView
                     reportID={reportID}
                     onNavigationMenuButtonClicked={() => Navigation.navigate(ROUTES.HOME)}

This way we can both fix this issue and keep the report mounted.
styles.visibilityHidden is already compatible with native app and mobile web,
and this issue also only occurs on mobile web (small screen).

AndrewGable · 2022-08-23T08:49:35Z

Reverted

ntdiary · 2022-08-23T10:29:20Z

Hi @AndrewGable, the latest solution can work well for these scenarios in my test, should I submit a new PR later ? 🙂

fix issue 9253

9d678de

ntdiary requested a review from a team as a code owner July 24, 2022 10:20

melvin-bot bot requested review from AndrewGable and mananjadhav and removed request for a team July 24, 2022 10:20

ntdiary closed this Jul 24, 2022

ntdiary reopened this Jul 24, 2022

mananjadhav reviewed Jul 25, 2022

View reviewed changes

Merge branch 'main' into issue-9253

7e4242e

mananjadhav approved these changes Aug 10, 2022

View reviewed changes

AndrewGable approved these changes Aug 10, 2022

View reviewed changes

AndrewGable merged commit 972b835 into Expensify:main Aug 10, 2022

OSBotify mentioned this pull request Aug 15, 2022

Deploy Checklist: New Expensify 2022-08-04 #10253

Closed

marcaaron mentioned this pull request Aug 22, 2022

Manually revert 10069 #10479

Merged

93 tasks

melvin-bot bot mentioned this pull request Aug 23, 2022

[HOLD - App Navigation Reboot] [$500] mWeb- Previous chat username is displayed when you navigate back from different chat @Yash Chauhan & @Puneet-here #9253

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Issue 9253: Previous chat username is displayed when you navigate back from different chat #10069

Fix Issue 9253: Previous chat username is displayed when you navigate back from different chat #10069

ntdiary commented Jul 24, 2022 •

edited

Loading

github-actions bot commented Jul 24, 2022 •

edited

Loading

ntdiary commented Jul 24, 2022

mananjadhav left a comment

ntdiary commented Jul 26, 2022 •

edited

Loading

ntdiary commented Jul 28, 2022 •

edited

Loading

ntdiary commented Aug 4, 2022

mananjadhav commented Aug 9, 2022

ntdiary commented Aug 10, 2022

mananjadhav commented Aug 10, 2022

mananjadhav commented Aug 10, 2022

PR Reviewer Checklist

mananjadhav left a comment

OSBotify commented Aug 10, 2022

marcaaron commented Aug 22, 2022

ntdiary commented Aug 23, 2022 •

edited

Loading

AndrewGable commented Aug 23, 2022

ntdiary commented Aug 23, 2022

Fix Issue 9253: Previous chat username is displayed when you navigate back from different chat #10069

Fix Issue 9253: Previous chat username is displayed when you navigate back from different chat #10069

Conversation

ntdiary commented Jul 24, 2022 • edited Loading

Details

Fixed Issues

Tests

PR Review Checklist

Contributor (PR Author) Checklist

PR Reviewer Checklist

QA Steps

Screenshots

Web

Mobile Web

android chrome

ios safari

Desktop

iOS

Android

github-actions bot commented Jul 24, 2022 • edited Loading

ntdiary commented Jul 24, 2022

mananjadhav left a comment

Choose a reason for hiding this comment

ntdiary commented Jul 26, 2022 • edited Loading

ntdiary commented Jul 28, 2022 • edited Loading

ntdiary commented Aug 4, 2022

mananjadhav commented Aug 9, 2022

ntdiary commented Aug 10, 2022

mananjadhav commented Aug 10, 2022

mananjadhav commented Aug 10, 2022

PR Reviewer Checklist

mananjadhav left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 10, 2022

marcaaron commented Aug 22, 2022

ntdiary commented Aug 23, 2022 • edited Loading

AndrewGable commented Aug 23, 2022

ntdiary commented Aug 23, 2022

ntdiary commented Jul 24, 2022 •

edited

Loading

github-actions bot commented Jul 24, 2022 •

edited

Loading

ntdiary commented Jul 26, 2022 •

edited

Loading

ntdiary commented Jul 28, 2022 •

edited

Loading

ntdiary commented Aug 23, 2022 •

edited

Loading