Revert "Start Using BeginSignIn command and remove obsolete API command calls" #10266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you modified Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands. Unsure if your change is okay? Drop a note in #expensify-open-source! |
|
|
melvin-bot
bot
requested review from
techievivek
and removed request for
a team
yuwenmemon
requested review from
robertjchen and
a team
and removed request for
techievivek
robertjchen
approved these changes
Aug 5, 2022
melvin-bot
bot
requested review from
techievivek
and removed request for
a team
OSBotify
pushed a commit
that referenced
this pull request
Aug 5, 2022
Revert "Start Using BeginSignIn command and remove obsolete API command calls" (cherry picked from commit d6f9542)
OSBotify
added a commit
that referenced
this pull request
Aug 5, 2022
…-10266 🍒 Cherry pick PR #10266 to staging 🍒
|
🚀 Cherry-picked to staging by @yuwenmemon in version: 1.1.88-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robertjchen please review
Reverts #10222
A problem was discovered with the error handling - so I'm reverting to fix it rather than blocking the deploy: #10257