Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Smart banner issue" #10299

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham requested a review from a team as a code owner August 8, 2022 16:08
@roryabraham roryabraham self-assigned this Aug 8, 2022
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team August 8, 2022 16:08
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2022

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@roryabraham roryabraham merged commit 1e94a27 into main Aug 8, 2022
@roryabraham roryabraham deleted the revert-10070-smart_banner_ios branch August 8, 2022 16:16
OSBotify pushed a commit that referenced this pull request Aug 8, 2022
OSBotify added a commit that referenced this pull request Aug 8, 2022
@OSBotify
Copy link
Contributor

OSBotify commented Aug 8, 2022

🚀 Cherry-picked to staging by @roryabraham in version: 1.1.88-5 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants