Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Onyx in web development #10326

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Expose Onyx in web development #10326

merged 3 commits into from
Aug 10, 2022

Conversation

iwiznia
Copy link
Contributor

@iwiznia iwiznia commented Aug 9, 2022 •
edited
Loading

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/220006

Tests

  • Opened the app on web and checked that Onyx was available in the console. For staging testing this will not work, so test is the opposite: open console in web and check that typing Onyx in the console returns nothing (or undefined)
  • Opened the app in ios and checked no errors

@iwiznia iwiznia self-assigned this Aug 9, 2022
@iwiznia iwiznia requested a review from a team as a code owner August 9, 2022 18:13
@melvin-bot melvin-bot bot requested review from puneetlath and removed request for a team August 9, 2022 18:14
puneetlath
puneetlath previously approved these changes Aug 10, 2022
View reviewed changes
@puneetlath
Copy link
Contributor

Nice! This is great. Do you think we should add this to the documentation too so that people know about it? Maybe in the debugging section?

@iwiznia
Copy link
Contributor Author

iwiznia commented Aug 10, 2022

Added it to the readme as you suggested

puneetlath
puneetlath requested changes Aug 10, 2022
View reviewed changes
@iwiznia @puneetlath
Update README.md
6c4f97c 
Co-authored-by: Puneet Lath <[email protected]>
@iwiznia
Copy link
Contributor Author

iwiznia commented Aug 10, 2022

Accepted the suggestion

@puneetlath puneetlath merged commit c5b3ba8 into main Aug 10, 2022
@puneetlath puneetlath deleted the ionatan_onyxdev branch August 10, 2022 20:11
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puneetlath puneetlath puneetlath approved these changes

Assignees

@iwiznia iwiznia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iwiznia @puneetlath @OSBotify