Update internal dev dependencies for GitHub #10332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow the paginate is very broken now, trying to figure out how to fix it. Once that is fixed we should be in business here. |
|
Tests should be passing now |
|
Ok should see a ✅ now and ready for review! |
|
I'll defer to Rory since I'm 100% green on github actions |
roryabraham
reviewed
Aug 10, 2022
|
Diff is looking much more manageable at this point, thanks for the suggestion! |
roryabraham
approved these changes
Aug 11, 2022
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
As a part of upgrading to NPM 8, we ran into a large peer dependency issue with GitHub dependencies. This upgrades all GitHub dependencies to the latest version and uses the new rest API.
This updates it in the way that @roryabraham and I discussed would be easiest to understand.
Fixed Issues
Related #10331
Tests