-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add 404 page to Help Site #10344
add 404 page to Help Site #10344
Conversation
Looks good to me! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, just tested this locally and it works like charm.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
@marcochavezf @techievivek Can you validate this internally or update the QA steps for Staging so we can run it |
Oops I forgot to update the QA tests with the correct URL, but it's working fine on the production env (https://help.expensify.com/): |
cc @michelle-thompson
Details
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/216920
Tests
(you need ruby and bundler installed to do this, more info here)
Run:
Navigate http://localhost:4000/blabla (a non-existent page) and verify the 404 page is displayed
QA Steps
Follow step 2 from the Test section
Screenshots
Web
Mobile Web