Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update Offline UX docs #10480

Merged
merged 5 commits into from
Aug 22, 2022
Merged

[No QA] Update Offline UX docs #10480

merged 5 commits into from
Aug 22, 2022

Conversation

puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Aug 22, 2022

Details

I was reading the offline UX doc and noticed a few issues, so I fixed them. They were:

  1. Fixing the headings
  2. Fixing the pin button image
  3. Fixing the table of contents
  4. Nesting the responses to the flowchart questions
  5. Adding an example for each pattern

No QA or testing. This is just documentation

@puneetlath puneetlath self-assigned this Aug 22, 2022
@puneetlath puneetlath changed the title Update Offline UX docs [No QA] Update Offline UX docs Aug 22, 2022
@puneetlath puneetlath marked this pull request as ready for review August 22, 2022 20:35
@puneetlath puneetlath requested a review from a team as a code owner August 22, 2022 20:35
@melvin-bot melvin-bot bot requested review from aldo-expensify and removed request for a team August 22, 2022 20:36
@aldo-expensify aldo-expensify merged commit 5a1204f into main Aug 22, 2022
@aldo-expensify aldo-expensify deleted the puneet-offline-docs branch August 22, 2022 22:13
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @aldo-expensify in version: 1.1.89-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants