-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NoQA] add generatePolicyID #10565
[NoQA] add generatePolicyID #10565
Conversation
Hmm it's failing because of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just one nab about the comment
You should just be able to include the variable in the export below to fix this error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for the ⚡ !
Going to merge to push this forward and since it's a harmless change - feel free to leave comments still if you notice something @MonilBhavsar |
@thienlnam looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Tests had passed |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @thienlnam in version: 1.1.90-0 🚀
|
cc @thienlnam
Details
Add
generatePolicyID()
to generatePolicyID
on the client.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/224679
Tests
N/A This function is going to be used for https://github.com/Expensify/Expensify/issues/224690
QA Steps
N/A
Screenshots
N/A