Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unread indicator and just use bold weight for report name #106

Merged
merged 5 commits into from
Aug 12, 2020
Merged

Remove unread indicator and just use bold weight for report name #106

merged 5 commits into from
Aug 12, 2020

Conversation

cead22
Copy link
Contributor

@cead22 cead22 commented Aug 12, 2020 •
edited
Loading

@cead22 cead22 requested a review from tgolen August 12, 2020 17:24
@cead22 cead22 self-assigned this Aug 12, 2020
@tgolen
Copy link
Contributor

tgolen commented Aug 12, 2020

Could we also make the text white so it stands out more?

@shawnborton
Copy link
Contributor

I like that idea Tim, but could we do ECECEC instead? Let's save white for when the list item is active.

@cead22
Copy link
Contributor Author

cead22 commented Aug 12, 2020

@shawnborton should I call this style in stylesheets "unread" instead of "bold"?

@cead22
Copy link
Contributor Author

cead22 commented Aug 12, 2020

Or better sideBarUnreadLink

shawnborton
shawnborton reviewed Aug 12, 2020
View reviewed changes
src/page/HomePage/SidebarLink.js Outdated
@@ -25,14 +25,12 @@ class SidebarLink extends React.Component {
const linkWrapperActiveStyle = isReportActive && styles.sidebarLinkWrapperActive;
const linkActiveStyle = isReportActive ? styles.sidebarLinkActive : styles.sidebarLink;
const textActiveStyle = isReportActive ? styles.sidebarLinkActiveText : styles.sidebarLinkText;
const textActiveUnreadStyle = this.state && this.state.isUnread ? [textActiveStyle, styles.bold] : [textActiveStyle];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps a better way to name this is styles.sidebarLinkTextUnread

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@cead22
Copy link
Contributor Author

cead22 commented Aug 12, 2020

How's this?
image

@cead22
Copy link
Contributor Author

cead22 commented Aug 12, 2020

Updated

@shawnborton
Copy link
Contributor

I like it!

@cead22
Copy link
Contributor Author

cead22 commented Aug 12, 2020

@tgolen bump so we don't get conflicts

@tgolen tgolen merged commit 2ccdad3 into master Aug 12, 2020
@tgolen tgolen deleted the carlos-boldunread branch August 12, 2020 20:51
mountiny pushed a commit that referenced this pull request Feb 12, 2025
@adamgrzybowski
Merge pull request #106 from software-mansion-labs/poc/split-adapted-…
98127ae 
…state

Poc/split adapted state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shawnborton shawnborton shawnborton left review comments

@tgolen tgolen Awaiting requested review from tgolen

Assignees

@cead22 cead22

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove unread indicator and just use bold weight for report name
3 participants
@cead22 @tgolen @shawnborton