Code

Refactor ValidationStep Form#10946

Code

Merged

luacmartins merged 28 commits intomainExpensify/App:mainfrom youssef_refactor_validation_step_formExpensify/App:youssef_refactor_validation_step_formCopy head branch name to clipboardOct 4, 2022

+32-75

Commits

Commits on Sep 12, 2022

• Replace reimbursement account form with Form

  youssef-lr

  committed
  4606ccc

  Copy full SHA for 4606ccc

• Add validation step form ID to ONYXKEYS and use it

  youssef-lr

  committed
  efbac29

  Copy full SHA for efbac29

• Add validate callback to validation step Form

  youssef-lr

  committed
  cdaf310

  Copy full SHA for cdaf310

• Implement onSubmit

  youssef-lr

  committed
  f17716c

  Copy full SHA for f17716c

• Refactor inputs and clean up their unused methods

  youssef-lr

  committed
  da74728

  Copy full SHA for da74728

• Display any backend error in the form

  youssef-lr

  committed
  3a937ec

  Copy full SHA for 3a937ec

• Cleanup debugging code

  youssef-lr

  committed
  53b840a

  Copy full SHA for 53b840a

• Use _.keys to loop over input values in validation

  youssef-lr

  committed
  89c1309

  Copy full SHA for 89c1309

• Save draft values

  youssef-lr

  committed
  fd8517b

  Copy full SHA for fd8517b

Commits on Sep 13, 2022

• Clean up code

  youssef-lr

  committed
  b7a6550

  Copy full SHA for b7a6550

• Remove unneeded props

  youssef-lr

  committed
  7ed486b

  Copy full SHA for 7ed486b

• Fix style, remove unused variable

  youssef-lr

  committed
  3d7ebf5

  Copy full SHA for 3d7ebf5

• Fix style

  youssef-lr

  committed
  0f8b8ff

  Copy full SHA for 0f8b8ff

• Prevent duplicate form submitting

  youssef-lr

  committed
  1defacd

  Copy full SHA for 1defacd

• Remove debugging code

  youssef-lr

  committed
  d6608c7

  Copy full SHA for d6608c7

• Clean up unused code

  youssef-lr

  committed
  329e4b8

  Copy full SHA for 329e4b8

Commits on Sep 14, 2022

• Use isLoading instead of isSubmitting

  youssef-lr

  committed
  23ebd43

  Copy full SHA for 23ebd43

• Apply requested changes

  youssef-lr

  committed
  30beeed

  Copy full SHA for 30beeed

Commits on Sep 16, 2022

• Merge branch 'main' into youssef_refactor_validation_step_form

  youssef-lr

  committed
  9ccf295

  Copy full SHA for 9ccf295

• Use the refactored validateBankAccount API call

  youssef-lr

  committed
  b2f7945

  Copy full SHA for b2f7945

Commits on Sep 19, 2022

• Merge branch 'main' into youssef_refactor_validation_step_form

  youssef-lr

  committed
  545edc5

  Copy full SHA for 545edc5

• Apply requested changes.

  youssef-lr

  committed
  c5e0fc4

  Copy full SHA for c5e0fc4

Commits on Sep 22, 2022

• Clear any server errors when validating inputs

  youssef-lr

  committed
  683ea77

  Copy full SHA for 683ea77

• Fix typo

  youssef-lr

  committed
  c06dac5

  Copy full SHA for c06dac5

Commits on Sep 23, 2022

• Set Form's error message in errors key

  youssef-lr

  committed
  d599f65

  Copy full SHA for d599f65

Commits on Sep 29, 2022

• Merge branch 'main' into youssef_refactor_validation_step_form

  youssef-lr

  committed
  828d44a

  Copy full SHA for 828d44a

Commits on Oct 3, 2022

• Merge branch 'main' into youssef_refactor_validation_step_form

  youssef-lr

  committed
  53dfdf8

  Copy full SHA for 53dfdf8

• Fix param type

  youssef-lr

  committed
  13863c7

  Copy full SHA for 13863c7