-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #1039 : extending KeyboardShortcut to Support Special Keys #1180
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Thanks for the PR @code-fi! Can you resolve the merge conflicts? |
@alex-mechler merge conflicts resolved :) |
@code-fi did you open another PR for this? Just double-checking since I don't see a new PR linked here or in the issue |
@Jag96 no, it was closed automatically I think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there are some style issues, but github was having issues when you last pushed. You can run the style checker locally with npm run lint
@alex-mechler changes made |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@code-fi pulling this out of the thread, I was able to reproduce on Mac OS (10.15.7), on both desktop and web |
Closing in favor of #1293 |
<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>
Details
Added Escape key listener to close all modals using existing KeyboardShortcut library. KeyboardShortcut library was also modified to accept single keys by passing
special
as modifier when subscribing for event.Fixed Issues
Fixes #1039
Tests
Close Image upload preview:
Close Attachment preview modal:
Tested On
Screenshots
record.mp4