Update NewDot Logos Nov 2022 #12608

grgia · 2022-11-09T20:08:13Z

Details

Update to our New Expensify Logos!

Holding for official color-switch PR, but ready for review.

Fixed Issues

$ #12441

Tests

Verify that no errors appear in the JS console

Ensure correct Logo on Sign in Page
Ensure correct Watermark on sign in page
Ensure correct Logo on About Page
Ensure correct Logo on Splash Screen
Ensure correct Logo for ios, android, desktop icons
Ensure dev logo if on dev, staging logo if on staging, official logo if on production (sign on page logo, desktop icon, splash screen)
Ensure correct web favicon/unread indicator

QA Steps

Verify that no errors appear in the JS console
Same checks as tests section.

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2022-11-19T05:23:21Z

@parasharrajat @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

parasharrajat · 2022-11-21T20:15:26Z

Please merge the main.

parasharrajat · 2022-11-23T02:54:44Z

Can we remove the HOLD from the title of this is ready?

grgia · 2022-11-23T18:18:41Z

Ready for final review/merge!

shawnborton · 2022-11-23T22:21:48Z

Looks good to me! The splash screen logo on iOS feels slightly too small, any idea why that might be?

parasharrajat · 2022-11-23T22:30:47Z

For Splash screens,

On Android =>

Please update the colors in this file main/android/app/src/main/res/values/styles.xml as well. This file is used when the app boots up and the splash screen is shown.

It uses colors from main/android/app/src/main/res/values/colors.xml

iOS =>

I have never touched it but it seems that we need to

Update the color

App/ios/NewExpensify/AppDelegate.mm

Line 73 in e7b0248

rootView.backgroundColor = [[UIColor alloc] initWithRed:1.0f

.
Update https://github.com/Expensify/App/blob/main/ios/NewExpensify/BootSplash.storyboard.

If we are not interested to update that in this PR. Let's first create an issue for it before we merged this.

grgia · 2022-11-23T23:02:24Z

This is the IOS splash screen

shawnborton · 2022-11-23T23:03:43Z

Ah got it, thanks for clarifying. We should definitely update the colors there to use the dark BG.

I was thinking that this one here was the splash screen, but maybe this is something different?

grgia · 2022-11-23T23:06:46Z

I tried that method to change the color but it doesn't seem to work. Technically RGBA(1,1,1,1) is black so I'm actually not sure if that is where we would set it. I think we can make an issue for the mobile splash screens. The android splash can be updated easily- but I think we should wait to update both together later.

grgia · 2022-11-23T23:08:21Z

@marcaaron since you set up the splash screens in this PR, any idea how to change IOS background color?

marcaaron · 2022-11-23T23:28:29Z

The package we are using (I think) is this one -> https://github.com/zoontek/react-native-bootsplash

Looks like there are some mentions of background color in there.

But it also looks like we made a ton of changes to the splash screen in this PR and embedded that package 🤔

I'm a bit behind on how it works now. But would guess that we need to define the color as a global in Android maybe here:

App/android/app/src/main/res/values/colors.xml

Lines 2 to 3 in b1e517d

    
           <color name="bootsplash_background">#FFFFFF</color> 
        
           <color name="white">#FFFFFF</color>

Used here:

App/android/app/src/main/res/drawable/bootsplash.xml

Lines 4 to 5 in b1e517d

	<item android:drawable="@color/bootsplash_background" />

And for iOS maybe that happens here in the BootSplash.storyboard file:

App/ios/NewExpensify/BootSplash.storyboard

Lines 27 to 28 in b1e517d

    
           <color key="backgroundColor" red="1.00000000000000" green="1.00000000000000" blue="1.00000000000000" alpha="1" colorSpace="custom" customColorSpace="sRGB"/> 
        
           <accessibility key="accessibilityConfiguration">

Gonna tag in @NikkiWines and @zoontek to see if they are available to help advise further.

grgia · 2022-11-23T23:46:14Z

Okay I figured it out, it's the inverse color. I used https://wtools.io/invert-color-code-online to get rgb(249, 228, 246)

shawnborton · 2022-11-23T23:51:07Z

Nice, that will do - thanks for digging into that one.

grgia · 2022-11-24T00:14:20Z

I changed in colors PR, logos can be merged once someone submits the PR review checklist

luacmartins · 2022-11-24T00:50:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

OSBotify · 2022-11-24T02:05:02Z

🚀 Deployed to staging by @luacmartins in version: 1.2.31-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

parasharrajat

LGTM.

luacmartins · 2022-12-06T17:33:36Z

The production deploy comment failed for this PR, but this was deployed to production on v1.2.32-2 on Nov 28.

grgia added 4 commits November 9, 2022 11:29

Replace android specific logos

f5aaa9d

Update expensify wordmark svg

555568d

Update New Expensify Logo svgs (prod/stg/dev)

c5a3c52

Replace IOS, Desktop icons, Web favicons, and notification icons.

a746869

shawnborton mentioned this pull request Nov 15, 2022

Update Concierge icon #12425

Merged

95 tasks

Merge branch 'main' into georgia-new-logos

05bc6ee

grgia self-assigned this Nov 19, 2022

grgia changed the title ~~[WIP] Update NewDot Logos Nov 2022~~ [Hold] Update NewDot Logos Nov 2022 Nov 19, 2022

grgia requested review from shawnborton, Luke9389 and AndrewGable November 19, 2022 05:22

grgia marked this pull request as ready for review November 19, 2022 05:22

grgia requested a review from a team as a code owner November 19, 2022 05:22

melvin-bot bot requested review from parasharrajat and puneetlath and removed request for a team November 19, 2022 05:23

shawnborton approved these changes Nov 21, 2022

View reviewed changes

AndrewGable approved these changes Nov 22, 2022

View reviewed changes

Merge branch 'main' into georgia-new-logos

726ba1b

Luke9389 approved these changes Nov 23, 2022

View reviewed changes

grgia changed the title ~~[Hold] Update NewDot Logos Nov 2022~~ Update NewDot Logos Nov 2022 Nov 23, 2022

parasharrajat mentioned this pull request Nov 23, 2022

Make the Switch to Dark Mode #12944

Merged

100 tasks

luacmartins merged commit e6e5465 into main Nov 24, 2022

luacmartins deleted the georgia-new-logos branch November 24, 2022 00:50

OSBotify mentioned this pull request Nov 24, 2022

Deploy Checklist: New Expensify 2022-11-23 #12976

Closed

38 tasks

parasharrajat reviewed Nov 24, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update NewDot Logos Nov 2022 #12608

Update NewDot Logos Nov 2022 #12608

grgia commented Nov 9, 2022 •

edited

Loading

melvin-bot bot commented Nov 19, 2022

parasharrajat commented Nov 21, 2022

parasharrajat commented Nov 23, 2022

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

parasharrajat commented Nov 23, 2022 •

edited

Loading

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

grgia commented Nov 23, 2022

grgia commented Nov 23, 2022

marcaaron commented Nov 23, 2022

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

grgia commented Nov 24, 2022

luacmartins commented Nov 24, 2022

OSBotify commented Nov 24, 2022

parasharrajat left a comment

luacmartins commented Dec 6, 2022

Update NewDot Logos Nov 2022 #12608

Update NewDot Logos Nov 2022 #12608

Conversation

grgia commented Nov 9, 2022 • edited Loading

Details

Fixed Issues

Tests

QA Steps

PR Author Checklist

Screenshots/Videos

PR Reviewer Checklist

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot bot commented Nov 19, 2022

parasharrajat commented Nov 21, 2022

parasharrajat commented Nov 23, 2022

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

parasharrajat commented Nov 23, 2022 • edited Loading

On Android =>

iOS =>

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

grgia commented Nov 23, 2022

grgia commented Nov 23, 2022

marcaaron commented Nov 23, 2022

grgia commented Nov 23, 2022

shawnborton commented Nov 23, 2022

grgia commented Nov 24, 2022

luacmartins commented Nov 24, 2022

Reviewer Checklist

Screenshots/Videos

OSBotify commented Nov 24, 2022

parasharrajat left a comment

Choose a reason for hiding this comment

luacmartins commented Dec 6, 2022

grgia commented Nov 9, 2022 •

edited

Loading

parasharrajat commented Nov 23, 2022 •

edited

Loading