Remove unnecessary shouldRemoveClippedSubviews prop #12686

dangrous · 2022-11-11T20:04:19Z

cc @roryabraham

Details

This is just removing unnecessary code that doesn't do anything.

Fixed Issues

$ #12666

Tests

Verify that no errors appear in the JS console

QA Steps

Verify that no errors appear in the JS console

Launch the app on android
Log in with any account
Go to any chat and send the message
The app should not crash
Repeat 3-4 a couple times just to be safe (it didn't always happen the first time, but 80% were very early.

PR Author Checklist

PR Reviewer Checklist

The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed

Screenshots

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions · 2022-11-11T20:06:13Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

src/components/InvertedFlatList/BaseInvertedFlatList.js

src/components/InvertedFlatList/index.native.js

melvin-bot · 2022-11-11T20:45:51Z

@mananjadhav @puneetlath One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dangrous · 2022-11-11T22:21:09Z

Note - I think this needs #12688 to be merged for this to successfully work.

roryabraham · 2022-11-11T23:18:09Z

Removed the CP Staging label because this is now just cleanup, not a bugfix

marcaaron · 2022-11-14T16:30:36Z

Any chance this will cause a performance regression? I think we added it while following this guide -> https://reactnative.dev/docs/optimizing-flatlist-configuration#removeclippedsubviews

This is a React Native bug it looks like

What's the bug?

roryabraham · 2022-11-14T18:10:27Z

The React Native bug issue was created then closed here. Basically there are crashes that happen if you use zIndex in a FlatList with shouldRemoveClippedSubviews={true}

Any chance this will cause a performance regression? I think we added it while following this guide

Yeah, I think that guide might be out-of-date or something because unless I'm mistaken, this code was just resulting in the same thing as the default. copy/pasting my explanation from Slack so everyone can see it...

Right now we are set up like:

BaseInvertedFlatList accepts a shouldRemoveClippedSubviews parameter, and drills it into the removeClippedSubviews parameter of FlatList
InvertedFlatList/index.android.js passes true for shouldRemoveClippedSubviews
InvertedFlatList/index.ios.js does not pass any value for shouldRemoveClippedSubviews, so it falls back to the default false

The effect is that removeClippedSubviews is true for Android and false for iOS, which – surprise: that’s already the default behavior of React Native.

marcaaron · 2022-11-14T18:44:55Z

Yeah, I think that guide might be out-of-date or something because unless I'm mistaken, this code was just resulting in the same thing as the default.

Ah sorry, I am a little confused by the explanation. Disregarding the default behavior, it seems like we are changing the param for Android from true to false? Is that right? And if so, does it affect performance?

marcaaron · 2022-11-14T18:46:48Z

Mostly just trying to understand what is happening - but also do have a concern that someone may try to add removeClippedSubviews={true} back to Android in the future and cause the crash again.

roryabraham · 2022-11-14T19:19:07Z

It seems like we are changing the param for Android from true to false? Is that right?

No, because the default value of the parameter is true on Android, and false on iOS.

Value of removeClippedSubviews before this PR:

Android: true
iOS: false

Value of removeClippedSubviews after this PR (default behavior):

Android: true
iOS false

So it should have no effect on performance

roryabraham · 2022-11-14T19:21:22Z

do have a concern that someone may try to add removeClippedSubviews={true} back to Android in the future and cause the crash again

In a separate PR we removed the zIndex entirely, which used to be necessary but it seems no longer is. So in order to reintroduce the same crash someone would have to add that zIndex back.

marcaaron · 2022-11-14T19:28:45Z

Ok so what is this PR doing lol?

roryabraham · 2022-11-14T19:34:56Z

Ok so what is this PR doing lol?

At this point, it's just removing unnecessary code that doesn't do anything.

marcaaron · 2022-11-14T20:19:23Z

Ah ok - sorry I was just thrown off by the description

This is a React Native bug it looks like (we will make a separate issue to investigate) but this will fix it in our app in the short term.

roryabraham · 2022-11-14T20:49:34Z

Totally understandable – updated the PR description to remove that outdated excerpt

roryabraham

LGTM

mananjadhav · 2022-11-15T10:24:10Z

🎀 👀 🎀
C+ reviewed

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- iOS / native
- Android / native
- iOS / Safari
- Android / Chrome
- MacOS / Chrome
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product was added in all src/languages/* files
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.