Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scrolling to bottom when opening the keyboard #12868

Merged
merged 2 commits into from
Nov 20, 2022
Merged

Remove scrolling to bottom when opening the keyboard #12868

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c517f6
Remove scrolling to bottom when opening the keyboard
jasperhuangg Nov 18, 2022
6d79913
remove unused
jasperhuangg Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions src/pages/home/report/ReportActionsView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,4 @@
import React from 'react';
import {
Keyboard,
} from 'react-native';
import PropTypes from 'prop-types';
import _ from 'underscore';
import lodashGet from 'lodash/get';
Expand All @@ -15,7 +12,6 @@ import withWindowDimensions, {windowDimensionsPropTypes} from '../../../componen
import {withDrawerPropTypes} from '../../../components/withDrawerState';
import * as ReportScrollManager from '../../../libs/ReportScrollManager';
import withLocalize, {withLocalizePropTypes} from '../../../components/withLocalize';
import ReportActionComposeFocusManager from '../../../libs/ReportActionComposeFocusManager';
import * as ReportActionContextMenu from './ContextMenu/ReportActionContextMenu';
import PopoverReportActionContextMenu from './ContextMenu/PopoverReportActionContextMenu';
import Performance from '../../../libs/Performance';
Expand Down Expand Up @@ -100,13 +96,6 @@ class ReportActionsView extends React.Component {
this.setState({newMarkerSequenceNumber: 0});
});

this.keyboardEvent = Keyboard.addListener('keyboardDidShow', () => {
if (!ReportActionComposeFocusManager.isFocused()) {
return;
}
ReportScrollManager.scrollToBottom();
});

if (this.getIsReportFullyVisible()) {
this.openReportIfNecessary();
}
Expand Down