-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move KAV outside of Freeze view #13037
Conversation
@rushatgabhane @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@madmax330 looks like we have a small bug for iOS and Android: There's some extra padding above report header skeleton.
Steps:
- Go to search, and search for a user that isn't in your contacts.
- Go back to LHN
- Go to any random user where a skeleton view would be shown
regression.mov
@rushatgabhane thanks, I watched this video like 20 times before I saw it 😄 I think I know why this is happenning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code change looks good to me. I have not tested it
…ce-fkavors update branch
Alright, updated and retested, @rushatgabhane lmk what you think |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Tests work well.
Code looks good. Also did not test this though. Seems we are just waiting on this comment then #13037 (comment) |
@rushatgabhane @cristipaval Will one of you be able to test this PR today so we can help get it merged? |
@marcaaron LGTM! ✨
Screenshots/VideosWebUntitled.1.mp4Mobile Web - ChromeScreen.Recording.2022-12-01.at.12.56.31.AM.movMobile Web - SafariScreen.Recording.2022-12-01.at.12.53.19.AM.movDesktopScreen.Recording.2022-12-01.at.1.11.57.AM.moviOSScreen.Recording.2022-12-01.at.12.47.25.AM.movAndroidWhatsApp.Video.2022-12-01.at.01.03.12.mp4 |
PR Reviewer checklist failed on this one, but they are all filled out as far as I can tell. |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @marcaaron in version: 1.2.35-0 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.35-0 🚀
|
Fixed Issues
$ #11858
Tests
Test steps
Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots/Videos
Web
Screen.Recording.2022-11-25.at.12.01.13.PM.mov
Mobile Web - Chrome
Screen.Recording.2022-11-25.at.6.33.01.PM.mov
Mobile Web - Safari
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-11-25.at.12.04.09.mp4
Desktop
Screen.Recording.2022-11-25.at.6.17.45.PM.mov
iOS
Simulator.Screen.Recording.-.iPhone.14.Pro.-.2022-11-29.at.18.01.42.mp4
Android
Screen.Recording.2022-11-29.at.7.18.32.PM.mov