-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/12777: Attachment -The image can be dragged by moving the cursor outside the image #13077
Fix/12777: Attachment -The image can be dragged by moving the cursor outside the image #13077
Conversation
@PauloGasparSv @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebplatform does not apply Mobile Web - Chromeplatform does not apply Mobile Web - Safariplatform does not apply Desktopplatform does not apply iOSScreen.Recording.2022-11-28.at.11.03.37.movAndroidScreen.Recording.2022-11-28.at.11.16.50.mov |
Looks good to me and tests well. |
Hey @aimane-chnaif I was doing that right now :D Feel free to approve the P.R.! Once I'm done with the list and screenshots and videos I'll merge it here. Also, if you could add test screenshots and videos of your own as a separate comment I'd appreciate that very much (only for native Android and iOS) |
@tienifr can you please merge latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, added videos for Android and iOS
@aimane-chnaif I think we can approve it despite of the dark mode as this won't be affected by it (since we are not adding any new components here). But I can re-approve this once @tienifr pulls main if we want to test that : )
yeah, dark mode changes won't affect this issue but just to match app screens with screenshots after merge |
Hi @aimane-chnaif I just merged the |
Screenshots/VideosWebN/A Mobile Web - ChromeN/A Mobile Web - SafariN/A DesktopN/A iOSios.mp4Androidandroid.mp4 |
Merging here as the pipeline passed! |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by @PauloGasparSv in version: 1.2.33-0 🚀
|
1 similar comment
🚀 Deployed to staging by @PauloGasparSv in version: 1.2.33-0 🚀
|
@tienifr @PauloGasparSv @aimane-chnaif this fix doesn't seem to be working as expected - see comment. Could you please check? |
🚀 Deployed to staging by @PauloGasparSv in version: 1.2.33-0 🚀
|
I think I can't re-run this, but I still think the original iOS build failure was not related to this P.R. changes. |
@PauloGasparSv the build is not related to this PR. Please don't re-run deploy actions. |
🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀
|
🚀 Deployed to production by @luacmartins in version: 1.2.33-7 🚀
|
Details
When the user uploads an image that has a large resolution enough to be dragged. The image can be dragged by moving the cursor outside the image so this PR fix it
Fixed Issues
$ #12777
$ #12777 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)PR Reviewer Checklist
The reviewer will copy/paste it into a new comment and complete it after the author checklist is completed
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
).src/languages/*
filesWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
have been tested & I retested again)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Screenshots/Videos
Web
Can't be executed on Web
Mobile Web - Chrome
Can't be executed on Mobile Web ChromeMobile Web - Safari
Can't be executed on Mobile Web SafariDesktop
Can't be executed on Desktop
iOS
203029226-8682067a-d4a4-4570-b805-d9871137b9d4.mp4
Android
Screen.Recording.2022-11-28.at.14.29.51.mp4