Fix wrong Provisioning Profile and add directories to desktop upload #13129
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| name: 'Configure AWS Credentials' | ||
| description: 'Configures AWS credentials for the workflow' | ||
|
|
||
| inputs: | ||
| AWS_ACCESS_KEY_ID: | ||
| description: 'Access Key to AWS' | ||
| required: true | ||
| AWS_SECRET_ACCESS_KEY: | ||
| description: 'Secret Access Key to AWS' | ||
| required: true | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Configure AWS Credentials | ||
| # Version: 1.5.5 | ||
| uses: aws-actions/configure-aws-credentials@e97d7fbc8e0e5af69631c13daa0f4b5a8d88165b | ||
| with: | ||
| aws-access-key-id: ${{ inputs.AWS_ACCESS_KEY_ID }} | ||
| aws-secret-access-key: ${{ inputs.AWS_SECRET_ACCESS_KEY }} | ||
| aws-region: us-east-1 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -4,6 +4,7 @@ on: | |||||
| workflow_dispatch: | ||||||
| pull_request_target: | ||||||
| types: [opened, synchronize] | ||||||
| branches: ['*ci-test/**'] | ||||||
|
|
||||||
| env: | ||||||
| DEVELOPER_DIR: /Applications/Xcode_14.0.1.app/Contents/Developer | ||||||
|
|
@@ -49,6 +50,12 @@ jobs: | |||||
| env: | ||||||
| LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} | ||||||
|
|
||||||
| - name: Configure AWS Credentials | ||||||
| uses: Expensify/App/.github/actions/composite/configureAwsCredentials@main | ||||||
| with: | ||||||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||
|
|
||||||
| - name: Run Fastlane beta test | ||||||
| id: runFastlaneBetaTest | ||||||
| run: bundle exec fastlane android build_internal | ||||||
|
|
@@ -99,6 +106,12 @@ jobs: | |||||
| env: | ||||||
| LARGE_SECRET_PASSPHRASE: ${{ secrets.LARGE_SECRET_PASSPHRASE }} | ||||||
|
|
||||||
| - name: Configure AWS Credentials | ||||||
| uses: Expensify/App/.github/actions/composite/configureAwsCredentials@main | ||||||
| with: | ||||||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||
|
|
||||||
| - name: Run Fastlane | ||||||
| run: bundle exec fastlane ios build_internal | ||||||
| env: | ||||||
|
|
@@ -131,6 +144,12 @@ jobs: | |||||
| env: | ||||||
| DEVELOPER_ID_SECRET_PASSPHRASE: ${{ secrets.DEVELOPER_ID_SECRET_PASSPHRASE }} | ||||||
|
|
||||||
| - name: Configure AWS Credentials | ||||||
| uses: Expensify/App/.github/actions/composite/configureAwsCredentials@main | ||||||
| with: | ||||||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||
|
|
||||||
| - name: Build desktop app for testing | ||||||
| run: npm run desktop-build-internal -- --publish always | ||||||
| env: | ||||||
|
|
@@ -140,44 +159,12 @@ jobs: | |||||
| APPLE_ID_PASSWORD: ${{ secrets.APPLE_ID_PASSWORD }} | ||||||
| AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} | ||||||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} | ||||||
roryabraham marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
| PULL_REQUEST_NUMBER: ${{ github.event.number }} | ||||||
roryabraham marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
|
||||||
| postGithubComment: | ||||||
| runs-on: ubuntu-latest | ||||||
| name: Post a GitHub comment with app download links for testing | ||||||
| needs: [android, ios, desktop] | ||||||
| steps: | ||||||
| - name: Checkout | ||||||
| uses: actions/checkout@93ea575cb5d8a053eaa0ac8fa3b40d7e05a33cc8 | ||||||
|
|
@@ -203,9 +190,10 @@ jobs: | |||||
| - name: Publish links to apps for download | ||||||
| run: | | ||||||
| gh pr comment --body \ | ||||||
| ":test_tube::test_tube: Use the links below to test this build in android and iOS. Happy testing! :test_tube::test_tube: | ||||||
| | android :robot: | iOS :apple: | desktop :computer: | | ||||||
| | ------------- | ------------- | ------------- | | ||||||
| | ${{fromJson(steps.set_var.outputs.android_paths).html_path}} | ${{fromJson(steps.set_var.outputs.ios_paths).html_path}} | https://ad-hoc-expensify-cash.us-east-1.amazonaws.com/desktop/${{github.event.number}}/NewExpensify.dmg | ||||||
|
There was a problem hiding this comment.
Suggested change
|
||||||
| | .html_path}}) | .html_path}}) | " | ||||||
|
There was a problem hiding this comment.
Suggested change
I don't think this is technically required, but let's be sure to add it in the next PR please There was a problem hiding this comment. Thanks, good catch, I haven't noticed this one! The fix is here: #13321 |
||||||
| env: | ||||||
| GITHUB_TOKEN: ${{ secrets.OS_BOTIFY_TOKEN }} | ||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I understand we're still in a testing phase, but why did you remove the web build?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turned out that it is not so simple to host multiple react apps in on S3 bucket. It seems that we may configure buckets to host a couple of apps with some predefined urls, but we have to dive deeper to find a way to do it dynamically (as we want to keep it in a folder with PR's number). Uploading the web app is not a problem, hosting it unfortunately might be.