Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to NewHelp #13898

Merged
merged 10 commits into from
Jan 14, 2023
Merged

Add link to NewHelp #13898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ed49239
add text for link
marcochavezf Dec 29, 2022
3786f50
add new help url as const
marcochavezf Dec 29, 2022
582541d
add menu item to settings page
marcochavezf Dec 29, 2022
18988f3
add help link to Get assistance page
marcochavezf Dec 30, 2022
5868231
add space
marcochavezf Dec 30, 2022
e7bd06d
Merge branch 'main' into marco-addNewHelpLink
marcochavezf Jan 6, 2023
89eb97a
add copy for help docs in Get Assistance Page
marcochavezf Jan 9, 2023
0d4b78a
update text link for NewHelp
marcochavezf Jan 9, 2023
5f5c5f5
update copy in Spanish
marcochavezf Jan 9, 2023
63cb818
Merge branch 'main' into marco-addNewHelpLink
marcochavezf Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,7 @@ const CONST = {
FEES_URL: `${USE_EXPENSIFY_URL}/fees`,
CFPB_PREPAID_URL: 'https://cfpb.gov/prepaid',
STAGING_NEW_EXPENSIFY_URL: 'https://staging.new.expensify.com',
NEWHELP_URL: 'https://help.expensify.com',

// Use Environment.getEnvironmentURL to get the complete URL with port number
DEV_NEW_EXPENSIFY_URL: 'http://localhost:',
Expand Down
2 changes: 2 additions & 0 deletions src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ export default {
phrase3: 'and',
phrase4: 'privacy policy',
},
help: 'Help',
},
closeAccountPage: {
closeAccount: 'Close account',
Expand Down Expand Up @@ -979,6 +980,7 @@ export default {
chatWithConcierge: 'Chat with Concierge',
requestSetupCall: 'Request a setup call',
questionMarkButtonTooltip: 'Get assistance from our team',
exploreHelpDocs: 'Explore help docs',
},
requestCallPage: {
title: 'Request a call',
Expand Down
2 changes: 2 additions & 0 deletions src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,7 @@ export default {
phrase3: 'y',
phrase4: 'política de privacidad',
},
help: 'Ayuda',
},
closeAccountPage: {
closeAccount: 'Cerrar cuenta',
Expand Down Expand Up @@ -981,6 +982,7 @@ export default {
chatWithConcierge: 'Chatear con Concierge',
requestSetupCall: 'Llámame por teléfono',
questionMarkButtonTooltip: 'Obtén ayuda de nuestro equipo',
exploreHelpDocs: 'Explorar la documentación de ayuda',
},
requestCallPage: {
title: 'Llámame por teléfono',
Expand Down
10 changes: 10 additions & 0 deletions src/pages/GetAssistancePage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import * as Expensicons from '../components/Icon/Expensicons';
import * as Illustrations from '../components/Icon/Illustrations';
import * as Report from '../libs/actions/Report';
import ROUTES from '../ROUTES';
import * as Link from '../libs/actions/Link';
import CONST from '../CONST';

const propTypes = {
/** Route object from navigation */
Expand Down Expand Up @@ -55,6 +57,14 @@ const GetAssistancePage = props => (
iconFill: themeColors.success,
wrapperStyle: [styles.cardMenuItem],
},
{
title: props.translate('getAssistancePage.exploreHelpDocs'),
onPress: () => Link.openExternalLink(CONST.NEWHELP_URL),
icon: Expensicons.QuestionMark,
shouldShowRightIcon: true,
iconFill: themeColors.success,
wrapperStyle: [styles.cardMenuItem],
},
]}
>
<View style={styles.mv3}>
Expand Down
6 changes: 6 additions & 0 deletions src/pages/settings/InitialSettingsPage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ import * as Wallet from '../../libs/actions/Wallet';
import walletTermsPropTypes from '../EnablePayments/walletTermsPropTypes';
import * as PolicyUtils from '../../libs/PolicyUtils';
import ConfirmModal from '../../components/ConfirmModal';
import * as Link from '../../libs/actions/Link';
import OfflineWithFeedback from '../../components/OfflineWithFeedback';

const propTypes = {
Expand Down Expand Up @@ -173,6 +174,11 @@ class InitialSettingsPage extends React.Component {
brickRoadIndicator: PaymentMethods.hasPaymentMethodError(this.props.bankAccountList, this.props.cardList) || !_.isEmpty(this.props.userWallet.errors)
|| !_.isEmpty(this.props.walletTerms.errors) ? 'error' : null,
},
{
translationKey: 'initialSettingsPage.help',
icon: Expensicons.QuestionMark,
action: () => { Link.openExternalLink(CONST.NEWHELP_URL); },
},
{
translationKey: 'initialSettingsPage.about',
icon: Expensicons.Info,
Expand Down