Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Revert "Update CODEOWNERS so that we don't accidentally deploy a new version of react-native-onyx" #13970

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

tgolen
Copy link
Contributor

@tgolen tgolen commented Jan 4, 2023

Reverts #13952

We are rolling out the SQLite upgrade today, so it's no longer necessary for me to review these PRs.

No testing or checklists required since this change doesn't affect the App code

@tgolen tgolen requested a review from puneetlath January 4, 2023 01:32
@tgolen tgolen requested a review from a team as a code owner January 4, 2023 01:32
@tgolen tgolen self-assigned this Jan 4, 2023
@melvin-bot melvin-bot bot requested review from flodnv and removed request for a team January 4, 2023 01:32
@melvin-bot
Copy link

melvin-bot bot commented Jan 4, 2023

@flodnv Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@puneetlath puneetlath merged commit 5af5d30 into main Jan 4, 2023
@puneetlath puneetlath deleted the revert-13952-tgolen-patch-3 branch January 4, 2023 01:36
@melvin-bot melvin-bot bot added the Emergency label Jan 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jan 4, 2023

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2023

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@puneetlath
Copy link
Contributor

This is a simple revert that doesn't affect product-facing code, so the checklist didn't make sense in this scenario.

@OSBotify
Copy link
Contributor

OSBotify commented Jan 4, 2023

🚀 Deployed to staging by @puneetlath in version: 1.2.48-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 5, 2023

🚀 Deployed to production by @luacmartins in version: 1.2.48-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Jan 6, 2023

🚀 Deployed to production by @luacmartins in version: 1.2.49-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants