[No QA] Go back to slack v3 to fix broken actions

[roryabraham]

Details

All GitHub Workflows that use this action are currently broken (example):

So it's critical we fix them ASAP.

Fixed Issues

n/a

Tests

1. Merge this PR.
2. Retry https://github.com/Expensify/App/actions/runs/4082370861/jobs/7036650596
3. It should work (otherwise add DeployBlocker to a new test PR and the resulting workflow should work).

Offline tests

None

QA Steps

None

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

None

[melvin-bot]

@sketchydroide Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[mountiny]

Worked https://expensify.slack.com/archives/C07J32337/p1675415817800799?thread_ts=1675413872.000939&cid=C07J32337 🎉

[github-actions]

Performance Comparison Report 📊

Significant Changes To Duration

There are no entries

Meaningless Changes To Duration

Show entries

Name	Duration
App start TTI	698.228 ms → 738.352 ms (+40.124 ms, +5.7%)
App start runJsBundle	194.613 ms → 208.750 ms (+14.137 ms, +7.3%)
Open Search Page TTI	607.284 ms → 614.401 ms (+7.117 ms, +1.2%)
App start nativeLaunch	20.069 ms → 20.129 ms (+0.060 ms, ±0.0%)
App start regularAppStart	0.015 ms → 0.016 ms (+0.001 ms, +6.2%)

Show details

Name	Duration
App start TTI	Baseline Mean: 698.228 ms Stdev: 32.905 ms (4.7%) Runs: 635.5021899999119 648.8174549997784 648.8574689999223 650.4795739999972 659.2564380001277 661.2113950001076 667.6740890000947 676.0143630001694 676.7883009999059 678.1325559997931 682.8203830001876 685.5711099999025 687.539226999972 692.6610159999691 697.5957880001515 701.9447200000286 703.0515129999258 703.5062259999104 703.7897870000452 704.6281940001063 706.2962600002065 707.9250719998963 711.7997369999066 719.026967999991 721.6103880000301 730.6523649999872 732.950251000002 734.30049399985 734.6749610002153 746.4104760000482 764.1018849997781 767.6922869998962 Current Mean: 738.352 ms Stdev: 25.248 ms (3.4%) Runs: 703.8922549998388 707.0256449999288 707.958014999982 709.3953470000997 709.9392719999887 712.8425650000572 715.7529609999619 719.5206630001776 721.1712650000118 721.5133960000239 723.3456190000288 726.4583220002241 726.716686999891 728.9376840000041 736.5882149999961 736.6533750002272 736.711217999924 737.0713280001655 739.1615590001456 741.9224200001918 744.309607999865 746.3848339999095 746.8949420000426 750.1488620000891 755.6243090000935 759.2823830000125 769.1629880000837 780.447798000183 784.9475969998166 789.3667449997738 799.7545920000412
App start runJsBundle	Baseline Mean: 194.613 ms Stdev: 20.135 ms (10.3%) Runs: 162 163 163 165 170 170 176 177 182 183 188 188 191 194 195 196 197 200 202 203 204 204 205 205 207 208 221 222 225 227 240 Current Mean: 208.750 ms Stdev: 24.082 ms (11.5%) Runs: 178 179 180 181 184 184 186 187 189 190 194 198 198 201 201 203 205 205 205 208 211 219 219 224 232 234 235 239 240 249 250 272
Open Search Page TTI	Baseline Mean: 607.284 ms Stdev: 22.395 ms (3.7%) Runs: 575.0336110000499 575.3559159999713 581.0570479999296 585.1971440003254 587.7508140001446 589.8229170003906 591.3324790000916 591.4543460002169 591.8746749996208 592.407226999756 594.9639079999179 595.7176520000212 596.3761799996719 597.3400480002165 598.4329840000719 600.633911000099 601.3248290000483 601.6335450001061 604.2540279999375 604.9541020002216 605.740722999908 608.5233569997363 611.9858809998259 616.759195999708 620.4512530001812 625.2657070001587 627.0282389996573 627.4554449999705 632.1734219999053 637.1285810000263 639.6085620000958 656.310344000347 675.0313729997724 Current Mean: 614.401 ms Stdev: 18.517 ms (3.0%) Runs: 586.3898120000958 588.6222740001976 591.7737639998086 595.5127769997343 595.7419030000456 597.2292479998432 600.5127770002 601.2127689998597 602.7516679996625 603.2450359999202 605.1574709997512 605.327432999853 605.8596199997701 607.9136560000479 610.180949000176 610.5286870002747 610.9792080000043 611.4285480002873 612.7776290001348 613.4817710001953 616.597534999717 619.7296549999155 619.744262999855 619.8410250004381 623.734701000154 625.2561440002173 629.2092690002173 629.8693440002389 632.5002040001564 633.3027349999174 634.8563240002841 666.7602949999273 667.2017419999465
App start nativeLaunch	Baseline Mean: 20.069 ms Stdev: 1.721 ms (8.6%) Runs: 18 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 21 21 21 21 21 21 21 21 22 23 23 25 Current Mean: 20.129 ms Stdev: 2.352 ms (11.7%) Runs: 17 18 18 18 18 18 18 18 18 19 19 19 19 19 19 19 20 20 20 20 21 21 21 21 21 22 22 25 25 25 26
App start regularAppStart	Baseline Mean: 0.015 ms Stdev: 0.001 ms (7.3%) Runs: 0.0125730000436306 0.013142999727278948 0.013387000188231468 0.01375299971550703 0.013753000181168318 0.013833999633789062 0.0138349998742342 0.013835000339895487 0.013996999710798264 0.014037999790161848 0.01411899970844388 0.014364000409841537 0.014405000023543835 0.014444999862462282 0.014485999941825867 0.014526000246405602 0.014566999860107899 0.014771000016480684 0.014851999934762716 0.01509599993005395 0.01509599993005395 0.015177999623119831 0.015298999845981598 0.015381000004708767 0.015381000004708767 0.01570700015872717 0.015746999997645617 0.015786999836564064 0.015910000074654818 0.016439000144600868 0.0167239997535944 0.017659000121057034 Current Mean: 0.016 ms Stdev: 0.001 ms (6.0%) Runs: 0.0139979999512434 0.014201000332832336 0.014648000244051218 0.014690000098198652 0.01472900016233325 0.014810999855399132 0.014851999934762716 0.014973999932408333 0.015054999850690365 0.01509599993005395 0.01525900000706315 0.01534100016579032 0.015503000002354383 0.015503000002354383 0.015625 0.015625 0.015625 0.015746999997645617 0.01578700030222535 0.015910000074654818 0.01607199991121888 0.01607300015166402 0.016112999990582466 0.01623600022867322 0.01635799976065755 0.016398000065237284 0.0166830001398921 0.017577999737113714 0.01769999973475933 0.017904000356793404

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.65-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/mountiny in version: 1.2.65-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅