Fixes width/height extraction with respect to exif orientation tag #14996

alexxxwork · 2023-02-09T20:05:44Z

Details

Expensify uses react-native-fast-image and added a patch to be able to get dimensions of the image displayed in the component on an onLoad event. But this method doesn't work correctly with images that have an exif property of image orientation. In such cases image is displayed properly (rotated according to the exif orientation flag) but dimensions returned from react-native-fast-image component are wrong (width/height swapped).
To resolve this propblem we should add an exif reader to get orientation tag and correct dimensions in such cases.

Fixed Issues

$ #14448
$ #14448 (comment)

Tests

Launch the app
Login with any account
Go to any chat
Tap on plus button
Select Add Attachment
Select Take a photo
Take a photo and send it

Verify that no errors appear in the JS console
Picture should be displayed in full size
upload image from iOS camera and preview in android
upload image from iOS gallery and preview in android
upload image from web and preview in android
upload image from android camera and preview in all platforms
upload image from android gallery and preview in all platforms

Offline tests

Go to a chat with previously uploaded pictures
Pictures should be displayed in full size

QA Steps

Launch the app
Login with any account
Go to any chat
Tap on plus button
Select Add Attachment
Select Take a photo
Take a photo and send it

Verify that no errors appear in the JS console
Picture should be displayed in full size
upload image from iOS camera and preview in android
upload image from iOS gallery and preview in android
upload image from web and preview in android
upload image from android camera and preview in all platforms
upload image from android gallery and preview in all platforms

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

github-actions · 2023-02-09T20:06:01Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

MelvinBot · 2023-02-09T20:06:32Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

alexxxwork · 2023-02-09T20:29:32Z

I have read the CLA Document and I hereby sign the CLA

0xmiros · 2023-02-10T06:18:36Z

@alexxxwork please let us know when PR is ready for review.
Also, please make sure to follow PR template exactly from next time. Reviewers are not linked correctly. pullerbear should have correctly assigned @mountiny and me as reviewers.

alexxxwork · 2023-02-10T10:28:31Z

@alexxxwork please let us know when PR is ready for review. Also, please make sure to follow PR template exactly from next time. Reviewers are not linked correctly. pullerbear should have correctly assigned @mountiny and me as reviewers.

Seems like a don't have enough rights to request review from specific persons. Should I just mention desired reviewers @mountiny @0xmiroslav? The PR is ready for review

0xmiros · 2023-02-10T10:34:26Z

@alexxxwork I believe you didn't comment like this. Can you share your screenshot on editing state?

alexxxwork · 2023-02-10T10:41:56Z

@alexxxwork I believe you didn't comment like this. Can you share your screenshot on editing state?

Do you mean that mention in comment above details header?

<!-- If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit. @mountiny @0xmiroslav  -->
### Details

### Fixed Issues
<!---
1. Please replace GH_LINK with a URL link to the GitHub issue this Pull Request is fixing.
2. Please replace PROPOSAL: GH_LINK_ISSUE(COMMENT) with a URL link to your GitHub comment, which contains the approved proposal (i.e. the proposal that was approved by Expensify).

Do NOT add the special GH keywords like `fixed` etc, we have our own process of managing the flow.
It MUST be an entire link to the github issue and your comment proposal ; otherwise, the linking will not work as expected.

Make sure this section looks similar to this (you can link multiple issues using the same formatting, just add a new line):

$ https://github.com/Expensify/App/issues/<number-of-the-issue>
$ https://github.com/Expensify/App/issues/<number-of-the-issue(comment)>

Do NOT only link the issue number like this: $ #<number-of-the-issue>
--->
$ [#14448](https://github.com/Expensify/App/issues/14448)   
PROPOSAL: [#14448 (comment)](https://github.com/Expensify/App/issues/14448#issuecomment-1422330478)

0xmiros · 2023-02-10T10:44:09Z

@alexxxwork ok so that's the issue. Automation didn't work because you didn't follow template.

- $ [#14448](https://github.com/Expensify/App/issues/14448) 
+ $ https://github.com/Expensify/App/issues/14448

I understand this is your first PR but from next job, please follow template correctly.

alexxxwork · 2023-02-10T10:47:42Z

@alexxxwork ok so that's the issue. Automation didn't work because you didn't follow template.
- $ [#14448](https://github.com/Expensify/App/issues/14448) 
+ $ https://github.com/Expensify/App/issues/14448
I understand this is your first PR but from next job, please follow template correctly.

🤦 Thought that this automation worked correctly as long as the link to PR appeared in the issue.

alexxxwork · 2023-02-10T10:51:08Z

@alexxxwork ok so that's the issue. Automation didn't work because you didn't follow template.
- $ [#14448](https://github.com/Expensify/App/issues/14448) 
+ $ https://github.com/Expensify/App/issues/14448
I understand this is your first PR but from next job, please follow template correctly.

@0xmiroslav should I recreate this PR to trigger correct assignment?

patches/react-native-fast-image+8.6.3.patch

0xmiros · 2023-02-10T10:53:51Z

@0xmiroslav should I recreate this PR to trigger correct assignment?

As I said, no need anymore for this PR. But don't repeat the same mistake from next PR for the next job.

Co-authored-by: Miroslav Stevanovic <[email protected]>

0xmiros · 2023-02-10T11:06:41Z

Typo in Tests step:
Log i with expensifail account -> Login with any account

…issue-14448

mountiny · 2023-02-10T11:14:34Z

@alexxxwork no problem as @0xmiroslav mentioned the issue needs to be linked exactly as the template says to make this work.

Can you also fill out the details section with some summary of what are we doing here?

Also will we make an upstream PR?

0xmiros · 2023-02-10T11:18:04Z

Also will we make an upstream PR?

@mountiny this is not upstream issue as I stated here. So the issue came from patch itself and it makes sense to fix in patch itself too.

mountiny · 2023-02-10T11:30:26Z

@0xmiroslav oh sorry, thanks for the link! Thank you 🙇

alexxxwork · 2023-02-10T11:36:37Z

Can you also fill out the details section with some summary of what are we doing here?

@mountiny updated details

patches/react-native-fast-image+8.6.3.patch

Co-authored-by: Miroslav Stevanovic <[email protected]>

0xmiros · 2023-02-10T12:08:32Z

@alexxxwork please replace with this file and commit again
react-native-fast-image+8.6.3.patch

…issue-14448

alexxxwork · 2023-02-10T12:19:35Z

@alexxxwork please replace with this file and commit again react-native-fast-image+8.6.3.patch

Seems to be ok now

mountiny

Looking good so far!

0xmiros · 2023-02-10T23:26:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.mp4

Desktop

desktop.mov

iOS

ios.mp4

Android

Before:

android-old.mov

After:

android.mp4

0xmiros

mac.rotate1.mov

mac.rotate2.mov

tested various cases: windows/mac images rotation, android/iOS camera/gallery portrait/landscape images and all look good.
I attached before-fix and after-fix videos in Android Screenshots. All other platforms look same between before-fix and after-fix.

mountiny

@0xmiroslav I do appreciate your thorough testing here!

@alexxxwork Congratulations, you first PR done, onwards and upwards 😍

OSBotify · 2023-02-10T23:44:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-02-11T01:04:10Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-02-11T02:23:34Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-02-13T12:04:03Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.2.70-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-02-13T17:44:52Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.2.70-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

alexxxwork added 2 commits February 10, 2023 00:39

Fixes width/height extraction with respect to exif orientation tag

ff0f150

Adds regenerated patch

dd7c947

alexxxwork requested a review from a team as a code owner February 9, 2023 20:05

melvin-bot bot requested review from grgia and removed request for a team February 9, 2023 20:06

alexxxwork marked this pull request as draft February 10, 2023 09:59

alexxxwork marked this pull request as ready for review February 10, 2023 10:29

alexxxwork marked this pull request as draft February 10, 2023 10:46

alexxxwork marked this pull request as ready for review February 10, 2023 10:48

0xmiros suggested changes Feb 10, 2023

View reviewed changes

patches/react-native-fast-image+8.6.3.patch Outdated Show resolved Hide resolved

patches/react-native-fast-image+8.6.3.patch Show resolved Hide resolved

Update patches/react-native-fast-image+8.6.3.patch

b2e793b

Co-authored-by: Miroslav Stevanovic <[email protected]>

mountiny self-requested a review February 10, 2023 11:10

mountiny assigned alexxxwork Feb 10, 2023

alexxxwork added 2 commits February 10, 2023 16:13

Adds comments on using InputStream.reset()

2406a70

Merge branch 'issue-14448' of https://github.com/alexxxwork/App into …

3725794

…issue-14448

0xmiros reviewed Feb 10, 2023

View reviewed changes

patches/react-native-fast-image+8.6.3.patch Outdated Show resolved Hide resolved

0xmiros reviewed Feb 10, 2023

View reviewed changes

patches/react-native-fast-image+8.6.3.patch Outdated Show resolved Hide resolved

0xmiros reviewed Feb 10, 2023

View reviewed changes

patches/react-native-fast-image+8.6.3.patch Outdated Show resolved Hide resolved

Update patches/react-native-fast-image+8.6.3.patch

f84e4f7

Co-authored-by: Miroslav Stevanovic <[email protected]>

alexxxwork added 2 commits February 10, 2023 17:13

Fixes non-intended changes in the patch file after npx patch-package

544b640

Merge branch 'issue-14448' of https://github.com/alexxxwork/App into …

a93b4ea

…issue-14448

mountiny reviewed Feb 10, 2023

View reviewed changes

0xmiros approved these changes Feb 10, 2023

View reviewed changes

mountiny approved these changes Feb 10, 2023

View reviewed changes

mountiny merged commit da3494a into Expensify:main Feb 10, 2023

OSBotify mentioned this pull request Feb 11, 2023

Deploy Checklist: New Expensify 2023-02-11 #15070

Closed

13 tasks

MelvinBot mentioned this pull request Feb 13, 2023

[HOLD for payment 2023-02-20] [$2000] Android - Attachment- User seen frame when attaching picture #14448

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes width/height extraction with respect to exif orientation tag #14996

Fixes width/height extraction with respect to exif orientation tag #14996

alexxxwork commented Feb 9, 2023 •

edited

Loading

github-actions bot commented Feb 9, 2023 •

edited

Loading

MelvinBot commented Feb 9, 2023

alexxxwork commented Feb 9, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023 •

edited

Loading

alexxxwork commented Feb 10, 2023

alexxxwork commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

mountiny left a comment

0xmiros commented Feb 10, 2023

0xmiros left a comment

mountiny left a comment

OSBotify commented Feb 10, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 13, 2023

OSBotify commented Feb 13, 2023

Fixes width/height extraction with respect to exif orientation tag #14996

Fixes width/height extraction with respect to exif orientation tag #14996

Conversation

alexxxwork commented Feb 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

github-actions bot commented Feb 9, 2023 • edited Loading

MelvinBot commented Feb 9, 2023

alexxxwork commented Feb 9, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023 • edited Loading

alexxxwork commented Feb 10, 2023

alexxxwork commented Feb 10, 2023 • edited Loading

0xmiros commented Feb 10, 2023 • edited Loading

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

0xmiros commented Feb 10, 2023

mountiny commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

0xmiros commented Feb 10, 2023

alexxxwork commented Feb 10, 2023

mountiny left a comment

Choose a reason for hiding this comment

0xmiros commented Feb 10, 2023

Reviewer Checklist

Screenshots/Videos

0xmiros left a comment

Choose a reason for hiding this comment

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Feb 10, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 11, 2023

OSBotify commented Feb 13, 2023

OSBotify commented Feb 13, 2023

alexxxwork commented Feb 9, 2023 •

edited

Loading

github-actions bot commented Feb 9, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023 •

edited

Loading

alexxxwork commented Feb 10, 2023 •

edited

Loading

0xmiros commented Feb 10, 2023 •

edited

Loading