Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use image thumbnail instead of full sized profile image #1568

Merged
merged 9 commits into from
Apr 2, 2021
Merged

Only use image thumbnail instead of full sized profile image #1568

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
bf6a49f
update to use the new thumbnail
thienlnam Feb 26, 2021
bae67a9
remove getAvatar method
thienlnam Feb 26, 2021
304f871
Merge branch 'master' into jack-updateavatar
thienlnam Mar 25, 2021
6aad46b
avatar changes
thienlnam Mar 26, 2021
81e0fe6
use default
thienlnam Mar 26, 2021
3d4cb12
move back to original location
thienlnam Mar 26, 2021
d931a08
remove extra space
thienlnam Mar 26, 2021
9ee94de
fix max-len
thienlnam Mar 26, 2021
1f64bb7
add back check for personalDetail
thienlnam Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/libs/actions/PersonalDetails.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,8 @@ function getDefaultAvatar(login = '') {
* @returns {String}
*/
function getAvatar(personalDetail, login) {
if (personalDetail && personalDetail.avatar) {
return personalDetail.avatar.replace(/&d=404$/, '');
if (personalDetail && personalDetail.avatarThumbnail) {
return personalDetail.avatarThumbnail;
}

return getDefaultAvatar(login);
Expand Down Expand Up @@ -170,7 +170,8 @@ function getFromReportParticipants(reports) {
if (report.participants.length > 0) {
const avatars = _.map(report.participants, dmParticipant => ({
firstName: lodashGet(details, [dmParticipant, 'firstName'], ''),
avatar: lodashGet(details, [dmParticipant, 'avatar'], '') || getDefaultAvatar(dmParticipant),
avatar: lodashGet(details, [dmParticipant, 'avatarThumbnail'], '')
|| getDefaultAvatar(dmParticipant),
}))
.sort((first, second) => first.firstName - second.firstName)
.map(item => item.avatar);
Expand Down