Fix login page urls #15731

luacmartins · 2023-03-07T23:10:18Z

Details

The Create a new account and Login urls in the Sign in page should redirect to the specific environment we are on, i.e. dev, staging, prod.

Fixed Issues

$ #15694

Tests

Navigate to the login page
Press the Create a new account link in the footer
Verify that you are navigated to the login page
Enter an email address and press Continue
Scroll down to the footer and press Log in
Verify that you are navigated back to the login page instead of Validate code page

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

MelvinBot · 2023-03-08T13:09:09Z

@Santhosh-Sellavel @amyevans One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Santhosh-Sellavel · 2023-03-08T18:56:34Z

@luacmartins When I can signup or login inside the app, why a web page is loaded browser for native platforms?

luacmartins · 2023-03-09T19:34:41Z

@Santhosh-Sellavel that's a good point. Thinking more about it, that section doesn't make much sense since we only display the footer on the sign in page and those links point to the same page. @shawnborton am I missing something here? Is there a reason to have the Get Started section if it always points to the current page?

Santhosh-Sellavel · 2023-03-09T19:51:30Z

Thinking more about it, that section doesn't make much sense since we only display the footer on the sign in page and those links point to the same page.

It makes more sense because we are already on the sign-in/sign-up page,
so shouldn't we just scroll up (reset the view) and show enter email page?

shawnborton · 2023-03-09T20:07:57Z

I think the main reason was so that the Get Started section is consistent across every single footer in our universe: NewDot, OldDot, WeAre, UseDot, CommunityDot, HelpDot, etc.

luacmartins · 2023-03-09T22:41:51Z

Updated!

Santhosh-Sellavel · 2023-03-13T17:24:02Z

LGTM tests well mostly. But will continue and get it done with the checklist tomorrow!

Santhosh-Sellavel · 2023-03-14T14:22:17Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web & Desktop

Screen.Recording.2023-03-14.at.8.29.41.PM.mov

Mobile Web - Chrome & Mobile Web - Safari

Screen.Recording.2023-03-14.at.8.30.39.PM.mov

iOS &Android

Screen.Recording.2023-03-14.at.8.34.04.PM.mov

Santhosh-Sellavel

LGTM, test well!

All you @amyevans

OSBotify · 2023-03-17T14:19:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-03-21T16:06:40Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-21T18:11:31Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.2.88-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-25T00:00:13Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-03-27T09:46:37Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.2.88-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

rushatgabhane · 2023-05-05T10:58:13Z

src/pages/signin/SignInPageLayout/Footer.js

                translationPath: 'footer.createAccount',
            },
            {
-                link: CONST.NEW_EXPENSIFY_URL,
+                onPress: navigateHome,
                translationPath: 'footer.logIn',


Hi! Coming from #16981 (A small UX polish)

We shouldn't call navigateHome if we're on the same page, because it'll trigger a navigation animation to the same page which looks weird.

230212633-7e1dd419-8b17-47fe-a60a-407b8e3d315e.mp4

We should have just scrolled to the top instead.

Good point, thank you for sharing!

Santhosh-Sellavel · 2023-05-25T22:02:52Z

We caused this #16357, we should have just scrolled up.

amyevans · 2023-05-25T22:15:37Z

@Santhosh-Sellavel can you clarify which issue you're coming from? Your link is just to this PR

Santhosh-Sellavel · 2023-05-26T05:21:57Z

Sorry for the mixup updated now. #16357

luacmartins added 3 commits March 7, 2023 17:46

rename getEnvironmentURL to getEnvironmentURLAsync

331b257

create getEnvironmentURL

185a102

update login page urls

702d6c3

luacmartins self-assigned this Mar 7, 2023

luacmartins marked this pull request as ready for review March 8, 2023 13:08

luacmartins requested a review from a team as a code owner March 8, 2023 13:08

luacmartins mentioned this pull request Mar 8, 2023

[HOLD for payment 2023-03-31] Log in - Tapping on Sign in/Get Started/Create a new Account directed on production instead of staging #15694

Closed

6 tasks

melvin-bot bot requested review from amyevans and Santhosh-Sellavel and removed request for a team March 8, 2023 13:09

luacmartins added 2 commits March 9, 2023 13:23

resolve conflicts

66a6b3a

add navigation

7d38122

luacmartins marked this pull request as draft March 9, 2023 19:38

luacmartins added 7 commits March 9, 2023 17:25

update home screen navigation

2eba711

revert changes to getEnvironmentURL

c837bc2

revert comment

ca28187

use screen const

441d800

use onPress

f9a7df3

clean up

730ac23

rm routes

6f0902e

luacmartins marked this pull request as ready for review March 9, 2023 22:41

Santhosh-Sellavel approved these changes Mar 14, 2023

View reviewed changes

amyevans approved these changes Mar 17, 2023

View reviewed changes

amyevans merged commit f16ce46 into main Mar 17, 2023

amyevans deleted the cmartins-fixLoginPageUrls branch March 17, 2023 14:15

OSBotify mentioned this pull request Mar 21, 2023

Deploy Checklist: New Expensify 2023-03-21 #16345

Closed

28 tasks

kbecciv mentioned this pull request Mar 21, 2023

[HOLD for payment 2023-05-23] [$2000] Android - Sign in - The keyboard opens and disappears for a brief moment #16357

Closed

6 tasks

rushatgabhane reviewed May 5, 2023

View reviewed changes

rushatgabhane mentioned this pull request May 5, 2023

[HOLD for payment 2023-04-26] [$1000] Wrong transition in Login page when click Login menu #16981

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix login page urls #15731

Fix login page urls #15731

luacmartins commented Mar 7, 2023 •

edited

Loading

MelvinBot commented Mar 8, 2023

Santhosh-Sellavel commented Mar 8, 2023 •

edited

Loading

luacmartins commented Mar 9, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 9, 2023

shawnborton commented Mar 9, 2023

luacmartins commented Mar 9, 2023

Santhosh-Sellavel commented Mar 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 14, 2023 •

edited

Loading

Santhosh-Sellavel left a comment

OSBotify commented Mar 17, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 25, 2023

OSBotify commented Mar 27, 2023

rushatgabhane May 5, 2023 •

edited

Loading

amyevans May 5, 2023

Santhosh-Sellavel commented May 25, 2023 •

edited

Loading

amyevans commented May 25, 2023

Santhosh-Sellavel commented May 26, 2023

Fix login page urls #15731

Fix login page urls #15731

Conversation

luacmartins commented Mar 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 8, 2023

Santhosh-Sellavel commented Mar 8, 2023 • edited Loading

luacmartins commented Mar 9, 2023 • edited Loading

Santhosh-Sellavel commented Mar 9, 2023

shawnborton commented Mar 9, 2023

luacmartins commented Mar 9, 2023

Santhosh-Sellavel commented Mar 13, 2023 • edited Loading

Santhosh-Sellavel commented Mar 14, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Santhosh-Sellavel left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 17, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 21, 2023

OSBotify commented Mar 25, 2023

OSBotify commented Mar 27, 2023

rushatgabhane May 5, 2023 • edited Loading

Choose a reason for hiding this comment

amyevans May 5, 2023

Choose a reason for hiding this comment

Santhosh-Sellavel commented May 25, 2023 • edited Loading

amyevans commented May 25, 2023

Santhosh-Sellavel commented May 26, 2023

luacmartins commented Mar 7, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 8, 2023 •

edited

Loading

luacmartins commented Mar 9, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 13, 2023 •

edited

Loading

Santhosh-Sellavel commented Mar 14, 2023 •

edited

Loading

rushatgabhane May 5, 2023 •

edited

Loading

Santhosh-Sellavel commented May 25, 2023 •

edited

Loading