Fix/15544: Bank account pages disable text input within wrong data on main device #15772

tienifr · 2023-03-09T11:35:09Z

Details

Fixed Issues

$ #15544
PROPOSAL: #15544 (comment)

Tests

Log in with the same account in 2 different environment (2 different devices or 2 different browsers)
In the main testing device, navigate to Settings -> Workspace -> Open any workspace -> Connect bank account
Type the wrong routing number and account number
In the second device, navigate to the connect bank account page too
Complete 2 first steps to reach step 3
Refresh the page in the main device and verify that the inputs in step 1 and step 2 are the same as what we filled in the second device and some of the inputs ("Routing number", "Account number", "Legal business name", and "Tax ID number") are disabled as expected.

Verify that no errors appear in the JS console

Offline tests

To connect bank account, we need a internet connection.

QA Steps

Log in with the same account in 2 different environment (2 different devices or 2 different browsers)
In the main testing device, navigate to Settings -> Workspace -> Open any workspace -> Connect bank account
Type the wrong routing number and account number
In the second device, navigate to the connect bank account page too
Complete 2 first steps to reach step 3
Refresh the page in the main device and verify that the inputs in step 1 and step 2 are the same as what we filled in the second device and some of the inputs ("Routing number", "Account number", "Legal business name", and "Tax ID number") are disabled as expected.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-03-09.at.21.06.55.mp4

Mobile Web - Chrome

Screen.Recording.2023-03-09.at.22.01.25.mp4

Mobile Web - Safari

Screen.Recording.2023-03-09.at.22.22.03.mp4

Desktop

Screen.Recording.2023-03-09.at.21.19.50.mp4

iOS

Screen.Recording.2023-03-09.at.22.17.43.mp4

Android

Screen.Recording.2023-03-09.at.21.54.20.mp4

…ft=true

MelvinBot · 2023-03-09T11:35:14Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

MelvinBot · 2023-03-13T16:27:19Z

@tylerkaraszewski @mollfpr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tylerkaraszewski · 2023-03-16T20:02:25Z

@mollfpr - can you start on this?

mollfpr · 2023-03-16T20:24:54Z

@tylerkaraszewski Yes! Sorry, I miss this PR! I thought that already reviewed a PR from @tienifr , but that’s another PR 😅

src/components/Form.js

src/libs/ReimbursementAccountUtils.js

src/pages/ReimbursementAccount/ReimbursementAccountPage.js

tienifr · 2023-03-19T15:59:37Z

@mollfpr I have resolved the comments. Please help me check it. Thank you!

tienifr · 2023-03-20T17:18:35Z

Hi @mollfpr, please help me check the updated code. Thank you!

mollfpr · 2023-03-20T18:24:13Z

@tienifr Sorry for the delay. I just arrived home from ECX. I'm reviewing it now.

mollfpr

Meanwhile, I'm testing the changes now.

src/components/Form.js

tienifr · 2023-03-21T05:07:34Z

I have updated the code. Please help me review it @mollfpr. Thank you!

tienifr · 2023-03-21T05:09:13Z

@tylerkaraszewski It seems that because of an accident made by me, you're not being requested to review this PR. Can you add yourself again?

mollfpr · 2023-03-21T19:38:59Z

@tienifr Thanks for the update! I'll review it within hours.

mollfpr · 2023-03-22T14:49:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

15772.Web.mp4

Mobile Web - Chrome

15772.mWeb.Chrome.mp4

Mobile Web - Safari

15772.mWeb-Safari.mp4

Desktop

15772.Desktop.mp4

iOS

15772.iOS.mp4

Android

15772.Android.mp4

mollfpr

Great work @tienifr 👍

@tylerkaraszewski All tests well and all yours.

tienifr · 2023-03-23T09:57:51Z

Hi @mollfpr I just resolved the conflict, could you approve again? Many thanks

mollfpr · 2023-03-23T11:53:26Z

@tylerkaraszewski Whenever you have time to review this.

OSBotify · 2023-03-27T12:16:02Z

🚀 Deployed to staging by https://github.com/tylerkaraszewski in version: 1.2.90-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-03-28T17:19:55Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.2.90-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Santhosh-Sellavel · 2023-05-11T14:22:46Z

src/pages/ReimbursementAccount/ReimbursementAccountPage.js

    getDefaultStateForField(fieldName, defaultValue = '') {
-        return ReimbursementAccountUtils.getDefaultStateForField(this.props.reimbursementAccountDraft, this.props.reimbursementAccount, fieldName, defaultValue);
+        return lodashGet(this.props.reimbursementAccount, ['achData', fieldName], defaultValue);


This change led to regression. We should prefer to draft, that got deleted, more details here

tienifr added 3 commits March 9, 2023 18:31

remove reimbursementAccountDraft

204ded3

pass shouldDiscardDraft to TextInput

a347d70

fix: assign respective defaultValue to inputValue if shouldDiscardDra…

25d7971

…ft=true

merge main branch

51b8440

tienifr marked this pull request as ready for review March 13, 2023 16:26

tienifr requested a review from a team as a code owner March 13, 2023 16:26

melvin-bot bot requested review from mollfpr and tylerkaraszewski and removed request for a team March 13, 2023 16:27

tienifr mentioned this pull request Mar 13, 2023

[HOLD for payment 2023-04-04] [$1000] Bank account pages disable text input within wrong data on main device #15544

Closed

6 tasks

mollfpr requested changes Mar 17, 2023

View reviewed changes

src/components/Form.js Outdated Show resolved Hide resolved

src/libs/ReimbursementAccountUtils.js Outdated Show resolved Hide resolved

src/pages/ReimbursementAccount/ReimbursementAccountPage.js Outdated Show resolved Hide resolved

tienifr added 2 commits March 19, 2023 22:43

remove ReimbursementAccountUtils

0648226

replace shouldDiscardDraft by isValidValueSaved

bfd3ea7

tienifr requested review from mollfpr and removed request for tylerkaraszewski March 19, 2023 15:58

mollfpr requested changes Mar 20, 2023

View reviewed changes

src/components/Form.js Outdated Show resolved Hide resolved

tienifr added 3 commits March 21, 2023 11:59

add proptype for shouldUseDefaultValue

5fe8c41

replace isValidValueSaved by shouldUseDefaultValue

fd9c68c

resolve conflict and merge main

c68f627

mollfpr previously approved these changes Mar 22, 2023

View reviewed changes

mollfpr mentioned this pull request Mar 22, 2023

Implement Invite message page #15672

Merged

55 tasks

fix: merge main

35a0cd1

tienifr dismissed mollfpr’s stale review via 35a0cd1 March 23, 2023 09:41

mollfpr approved these changes Mar 23, 2023

View reviewed changes

tienifr changed the title ~~Fix/15544 bank account pages disable text input within wrong data on main device~~ Fix/15544: Requeue ReconnectApp API requests to fix old data getting rendered when going from offline to online mode Mar 23, 2023

tienifr changed the title ~~Fix/15544: Requeue ReconnectApp API requests to fix old data getting rendered when going from offline to online mode~~ Fix/15544: Bank account pages disable text input within wrong data on main device Mar 23, 2023

tylerkaraszewski approved these changes Mar 27, 2023

View reviewed changes

tylerkaraszewski merged commit 06be850 into Expensify:main Mar 27, 2023

OSBotify mentioned this pull request Mar 27, 2023

Deploy Checklist: New Expensify 2023-03-27 #16536

Closed

18 tasks

fedirjh mentioned this pull request Mar 28, 2023

[HOLD for payment 2023-04-04] Workspace -Unable to add Chase bank account, can't choose a bank account ending in 1111/0000 #16594

Closed

6 tasks

bernhardoj mentioned this pull request Apr 18, 2023

[HOLD for payment 2023-05-16] [$1000] Connect Bank Account - Beneficial owners Info isn't saved after going offline and return to connect new BA #16938

Closed

6 tasks

amyevans mentioned this pull request Apr 20, 2023

Reintroduce error message in "Connect Bank Account" flow when wrong bank account number is entered #17748

Merged

56 tasks

Santhosh-Sellavel reviewed May 11, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/15544: Bank account pages disable text input within wrong data on main device #15772

Fix/15544: Bank account pages disable text input within wrong data on main device #15772

tienifr commented Mar 9, 2023 •

edited

Loading

MelvinBot commented Mar 9, 2023

MelvinBot commented Mar 13, 2023

tylerkaraszewski commented Mar 16, 2023

mollfpr commented Mar 16, 2023

tienifr commented Mar 19, 2023

tienifr commented Mar 20, 2023

mollfpr commented Mar 20, 2023

mollfpr left a comment

tienifr commented Mar 21, 2023

tienifr commented Mar 21, 2023

mollfpr commented Mar 21, 2023

mollfpr commented Mar 22, 2023

mollfpr left a comment

tienifr commented Mar 23, 2023

mollfpr commented Mar 23, 2023

OSBotify commented Mar 27, 2023

OSBotify commented Mar 28, 2023

Santhosh-Sellavel May 11, 2023 •

edited

Loading

Fix/15544: Bank account pages disable text input within wrong data on main device #15772

Fix/15544: Bank account pages disable text input within wrong data on main device #15772

Conversation

tienifr commented Mar 9, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 9, 2023

MelvinBot commented Mar 13, 2023

tylerkaraszewski commented Mar 16, 2023

mollfpr commented Mar 16, 2023

tienifr commented Mar 19, 2023

tienifr commented Mar 20, 2023

mollfpr commented Mar 20, 2023

mollfpr left a comment

Choose a reason for hiding this comment

tienifr commented Mar 21, 2023

tienifr commented Mar 21, 2023

mollfpr commented Mar 21, 2023

mollfpr commented Mar 22, 2023

Reviewer Checklist

Screenshots/Videos

mollfpr left a comment

Choose a reason for hiding this comment

tienifr commented Mar 23, 2023

mollfpr commented Mar 23, 2023

OSBotify commented Mar 27, 2023

OSBotify commented Mar 28, 2023

Santhosh-Sellavel May 11, 2023 • edited Loading

Choose a reason for hiding this comment

tienifr commented Mar 9, 2023 •

edited

Loading

Santhosh-Sellavel May 11, 2023 •

edited

Loading