Ensure OpenReport is always called when deeplinking from an outside source #15994

jasperhuangg · 2023-03-15T15:36:29Z

Details

This fixes an issue where scanning QR codes on Android would cause you to navigate to a "No Access" screen. This was due to a faulty condition in our componentDidUpdate logic in the ReportScreen that would prevent OpenReport from being called when you deeplinked to a report on Native platforms from outside the App.

This also makes it so I can get rid of a hack I added to get deeplinks within the App to work in the AnchorRenderer

Fixed Issues

$ N/A

Tests/QA

Deeplinking from within the App

Send yourself a link to a public report you're not already a member of on NewDot (from a different account).
Click on that link, and verify you can access the report.

Deeplinking from outside the App

Paste a link to a public report you're not already a member of to an outside source (e.g. Notes app, Contacts app, etc.)
Click on that link, and verify you can access the report.

PR Author Checklist

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb-chrome.mov

Mobile Web - Safari

mweb-safari.mov

Desktop

desktop.mov

iOS

ios.mp4

Android

android.mov

…ource

github-actions · 2023-03-15T15:36:45Z

⚠️ ⚠️ Heads up! This pull request has the CP Staging label ⚠️ ⚠️
If you applied the CP Staging label before the PR was merged, the PR will be be immediately deployed to staging even if the open StagingDeployCash deploy checklist is locked.
However if you applied the CP Staging after the PR was merged it's possible it won't be CP'ed automatically. If you need it to be CP'ed to staging, tag a member of @Expensify/mobile-deployers to CP it manually, otherwise you can wait for it to go out with the next deploy.

jasperhuangg · 2023-03-15T16:16:21Z

@stitesExpensify Ready to go :D

MelvinBot · 2023-03-15T16:17:23Z

@grgia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

stitesExpensify · 2023-03-15T16:48:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

2023-03-15_12-33-45.mp4

2023-03-15_12-34-07.mp4

Mobile Web - Chrome

2023-03-15_12-47-37.mp4

Mobile Web - Safari

2023-03-15_12-35-58.mp4

2023-03-15_12-39-09.mp4

Desktop

2023-03-15_12-51-02.mp4

iOS

2023-03-15_12-35-01.mp4

Android

2023-03-15_12-41-47.mp4

2023-03-15_12-45-02.mp4

stitesExpensify

LGTM and tests well!

…nDidUpdate Ensure OpenReport is always called when deeplinking from an outside source (cherry picked from commit e9c2e0f)

…-15994 🍒 Cherry pick PR #15994 to staging 🍒

OSBotify · 2023-03-15T18:26:05Z

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 1.2.85-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-03-16T11:11:15Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.2.85-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-15T01:35:13Z

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

OSBotify · 2023-06-16T18:52:58Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 1.3.28-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

c3024 · 2024-11-13T05:57:47Z

src/pages/home/ReportScreen.js

+        // before deciding that we shouldn't call OpenReport.
+        const onyxReportID = this.props.report.reportID;
+        const routeReportID = getReportID(this.props.route);
+        if (routeReportID === prevProps.route.params.reportID && (!onyxReportID || onyxReportID === routeReportID)) {


This check caused the OpenReport to be called multiple times when opening a thread. This has been fixed with comparing only the reportIDFromRoute. More info at #51680 .

Ensure OpenReport is always called when deeplinking from an outside s…

f385118

…ource

jasperhuangg added the CP Staging label Mar 15, 2023

jasperhuangg self-assigned this Mar 15, 2023

remove unused

3819354

jasperhuangg requested a review from stitesExpensify March 15, 2023 15:50

jasperhuangg added 2 commits March 15, 2023 12:00

simplify condition

5cddaf2

simplify condition

9e07606

jasperhuangg marked this pull request as ready for review March 15, 2023 16:16

jasperhuangg requested a review from a team as a code owner March 15, 2023 16:16

melvin-bot bot requested review from grgia and removed request for a team March 15, 2023 16:17

jasperhuangg marked this pull request as draft March 15, 2023 16:55

jasperhuangg marked this pull request as ready for review March 15, 2023 16:58

stitesExpensify approved these changes Mar 15, 2023

View reviewed changes

jasperhuangg merged commit e9c2e0f into main Mar 15, 2023

jasperhuangg deleted the jasper-alwaysCallOpenReportInDidUpdate branch March 15, 2023 17:05

OSBotify pushed a commit that referenced this pull request Mar 15, 2023

Merge pull request #15994 from Expensify/jasper-alwaysCallOpenReportI…

39ec3eb

…nDidUpdate Ensure OpenReport is always called when deeplinking from an outside source (cherry picked from commit e9c2e0f)

OSBotify mentioned this pull request Mar 15, 2023

🍒 Cherry pick PR #15994 to staging 🍒 #15999

Merged

OSBotify added a commit that referenced this pull request Mar 15, 2023

Merge pull request #15999 from Expensify/OSBotify-cherry-pick-staging…

2922285

…-15994 🍒 Cherry pick PR #15994 to staging 🍒

OSBotify mentioned this pull request Mar 15, 2023

Deploy Checklist: New Expensify 2023-03-15 #15983

Closed

8 tasks

kbecciv mentioned this pull request Mar 16, 2023

[$1000] Android - There is no focus in compose box after tapping on deep link #16023

Closed

6 tasks

bernhardoj mentioned this pull request Mar 21, 2023

New skeleton loader for LHN #14456

Merged

54 tasks

OSBotify mentioned this pull request May 2, 2023

Deploy Checklist: New Expensify 2023-05-02 #18315

Closed

OSBotify mentioned this pull request Jun 15, 2023

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed

bernhardoj mentioned this pull request Oct 22, 2024

[$250] 3 OpenReport API calls for the same report #49948

Closed

6 tasks

c3024 reviewed Nov 13, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure OpenReport is always called when deeplinking from an outside source #15994

Ensure OpenReport is always called when deeplinking from an outside source #15994

jasperhuangg commented Mar 15, 2023 •

edited

Loading

github-actions bot commented Mar 15, 2023

jasperhuangg commented Mar 15, 2023

MelvinBot commented Mar 15, 2023

stitesExpensify commented Mar 15, 2023 •

edited

Loading

stitesExpensify left a comment

OSBotify commented Mar 15, 2023

OSBotify commented Mar 16, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

c3024 Nov 13, 2024

Ensure OpenReport is always called when deeplinking from an outside source #15994

Ensure OpenReport is always called when deeplinking from an outside source #15994

Conversation

jasperhuangg commented Mar 15, 2023 • edited Loading

Details

Fixed Issues

Tests/QA

Deeplinking from within the App

Deeplinking from outside the App

PR Author Checklist

Screenshots/Videos

github-actions bot commented Mar 15, 2023

jasperhuangg commented Mar 15, 2023

MelvinBot commented Mar 15, 2023

stitesExpensify commented Mar 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

stitesExpensify left a comment

Choose a reason for hiding this comment

OSBotify commented Mar 15, 2023

OSBotify commented Mar 16, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

c3024 Nov 13, 2024

Choose a reason for hiding this comment

jasperhuangg commented Mar 15, 2023 •

edited

Loading

stitesExpensify commented Mar 15, 2023 •

edited

Loading