Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #16470

narefyev91 · 2023-03-24T13:30:22Z

Details

App displays the keyboard for few seconds on profile page before closing it. During development discovered powerful way to build re-usable component - which will handle both navigate/go back logic and dismiss keyboard where it will be necessary and not rely on navigation events for android at all. Now this component can be used for example in HeaderWithCloseButton

<Pressable
    onPress={this.props.onBackButtonPress} />

<HeaderWithCloseButton
    title={this.props.translate('common.details')}
    shouldShowBackButton={shouldShowBackButton}
    onBackButtonPress={drawerGoBack} // or onBackButtonPress={() => drawerGoBack(CUSTOM_ROUTE_TO_GO}
    onCloseButtonPress={() => Navigation.dismissModal()}
/>

Fixed Issues

$ #15919
$ #15919 (comment)

Tests

Open the app
Open settings
Open Profile
Open Display name
Click on first name or last name and once the keyboard is open, click on save
Keyboard shouldn't be visible while going back to previous screen
Repeat same steps in personal details

Verify that no errors appear in the JS console

Offline tests

This feature doesn't change or is impacted by offline mode.

QA Steps

Same as above.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

back-web.mov

Mobile Web - Chrome

8mb.video-ngf-TZkPtlur.mp4

Mobile Web - Safari

8mb.video-1T9-1v6cfwcz.mp4

Desktop

back-desktop.mov

iOS

back-ios.mov

Android

back-android.mov

…isplay name and Personal details page

MelvinBot · 2023-03-24T13:30:29Z

@techievivek @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/libs/Navigation/drawerGoBack/index.android.js

src/libs/Navigation/drawerGoBack/index.js

mananjadhav

Raised some refactor comments. @techievivek Would also need your help to review. Rest of the changes look good here.

narefyev91 · 2023-03-28T08:59:53Z

@mananjadhav pushed fix to resolve all comments

src/libs/Navigation/removeKeyboardGoingBack/index.android.js

techievivek · 2023-03-28T12:51:15Z

Sorry, I couldn't finish reviewing the PR completely as I had to change place, I will give it a review now.

techievivek

@mananjadhav The PR looks good to me, can you just test the flows and fill the PR checklists.

src/libs/Navigation/Navigation.js

src/libs/actions/PersonalDetails.js

src/libs/Navigation/Navigation.js

mananjadhav · 2023-03-29T04:11:02Z

I'll need time until today/tomorrow to test all the pages. code changes look fine though.

techievivek · 2023-04-03T08:29:27Z

Hey @mananjadhav any updates here?

mananjadhav · 2023-04-03T08:38:06Z

Apologies for the delay. I will finish this today.

mananjadhav · 2023-04-04T19:36:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-hide-keyboard-after-save.mov

Mobile Web - Chrome

mweb-chrome-hide-keyboard-after-save.mov

Mobile Web - Safari

mweb-safari-hide-keyboard-after-save.mov

Desktop

desktop-hide-keyboard-after-save.mov

iOS

Screen.Recording.2023-04-05.at.10.47.55.PM.mov

Android

android-hide-keyboard-after-save.mov

@techievivek I am stuck with my iOS build and hence I am unable to upload screencasts for iOS. Could you please help me with the same?

@narefyev91 I think let's improve our Test Cases/QA Steps to include that the Keyboard shouldn't be visible while navigating back to the previous screen.

narefyev91 · 2023-04-05T06:26:21Z

@mananjadhav sure - i added that step in our Test cases

techievivek · 2023-04-05T15:30:48Z

@mananjadhav Testing the PR on iOS.

techievivek · 2023-04-05T17:27:20Z

My build was broken as well, but in the end it worked. I have updated the PR reviewer checklist.

Screen.Recording.2023-04-05.at.10.47.55.PM.mov

techievivek · 2023-04-05T17:35:56Z

There seems to be some issue with the PR reviewer checklist task here.

techievivek · 2023-04-05T17:44:04Z

Aaah, I had already posted a reviewer checklist comment, and the automation was using that to figure out if the checklist is filled or not. I have deleted that comment, and it works now.

techievivek

Looks good. 🎉

OSBotify · 2023-04-05T17:51:28Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-06T01:33:43Z

🚀 Deployed to staging by https://github.com/techievivek in version: 1.2.96-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-07T22:13:18Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.96-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

narefyev91 added 3 commits March 24, 2023 15:14

Profile : Keyboard is visible for a brief moment when hit "Save" in d…

5f4ad36

…isplay name and Personal details page

add correct component

49a7af8

clean up

c54681b

narefyev91 requested a review from a team as a code owner March 24, 2023 13:30

melvin-bot bot requested review from mananjadhav and techievivek and removed request for a team March 24, 2023 13:30

mananjadhav reviewed Mar 27, 2023

View reviewed changes

src/libs/Navigation/drawerGoBack/index.android.js Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 27, 2023

View reviewed changes

src/libs/Navigation/drawerGoBack/index.android.js Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 27, 2023

View reviewed changes

src/libs/Navigation/drawerGoBack/index.js Outdated Show resolved Hide resolved

mananjadhav reviewed Mar 27, 2023

View reviewed changes

Fix comments

580e9c5

techievivek reviewed Mar 28, 2023

View reviewed changes

src/libs/Navigation/removeKeyboardGoingBack/index.android.js Outdated Show resolved Hide resolved

change naming

5dc6da0

techievivek reviewed Mar 28, 2023

View reviewed changes

src/libs/Navigation/Navigation.js Outdated Show resolved Hide resolved

src/libs/Navigation/Navigation.js Outdated Show resolved Hide resolved

src/libs/actions/PersonalDetails.js Show resolved Hide resolved

src/libs/Navigation/Navigation.js Outdated Show resolved Hide resolved

wording

48b3e44

narefyev91 requested review from techievivek and mananjadhav and removed request for techievivek and mananjadhav March 28, 2023 16:41

mananjadhav approved these changes Apr 4, 2023

View reviewed changes

techievivek approved these changes Apr 5, 2023

View reviewed changes

techievivek merged commit e56b9c7 into Expensify:main Apr 5, 2023

OSBotify mentioned this pull request Apr 6, 2023

Deploy Checklist: New Expensify 2023-04-06 #16996

Closed

16 tasks

MelvinBot mentioned this pull request Apr 7, 2023

[HOLD for payment 2023-04-14] [$2000] Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #15919

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #16470

Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #16470

narefyev91 commented Mar 24, 2023 •

edited

Loading

MelvinBot commented Mar 24, 2023

mananjadhav left a comment

narefyev91 commented Mar 28, 2023

techievivek commented Mar 28, 2023

techievivek left a comment

mananjadhav commented Mar 29, 2023

techievivek commented Apr 3, 2023

mananjadhav commented Apr 3, 2023

mananjadhav commented Apr 4, 2023 •

edited by techievivek

Loading

narefyev91 commented Apr 5, 2023

techievivek commented Apr 5, 2023

techievivek commented Apr 5, 2023 •

edited

Loading

techievivek commented Apr 5, 2023

techievivek commented Apr 5, 2023

techievivek left a comment

OSBotify commented Apr 5, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #16470

Profile : Keyboard is visible for a brief moment when hit "Save" in display name and Personal details page #16470

Conversation

narefyev91 commented Mar 24, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Mar 24, 2023

mananjadhav left a comment

Choose a reason for hiding this comment

narefyev91 commented Mar 28, 2023

techievivek commented Mar 28, 2023

techievivek left a comment

Choose a reason for hiding this comment

mananjadhav commented Mar 29, 2023

techievivek commented Apr 3, 2023

mananjadhav commented Apr 3, 2023

mananjadhav commented Apr 4, 2023 • edited by techievivek Loading

Reviewer Checklist

Screenshots/Videos

narefyev91 commented Apr 5, 2023

techievivek commented Apr 5, 2023

techievivek commented Apr 5, 2023 • edited Loading

techievivek commented Apr 5, 2023

techievivek commented Apr 5, 2023

techievivek left a comment

Choose a reason for hiding this comment

OSBotify commented Apr 5, 2023

OSBotify commented Apr 6, 2023

OSBotify commented Apr 7, 2023

narefyev91 commented Mar 24, 2023 •

edited

Loading

mananjadhav commented Apr 4, 2023 •

edited by techievivek

Loading

techievivek commented Apr 5, 2023 •

edited

Loading