Fix replay effect #16545

neil-marcellini · 2023-03-27T11:42:57Z

Details

The replay effect happens when a user takes multiple actions while offline, the requests are queued up in the SequentialQueue, and then they go back online and each request is processed on at a time. Since optimistic data has already been set while offline, each Pusher event that arrives updates Onyx with outdated data, causing the offline actions to "replay".

In order to fix the replay effect from the App side we are first sending the Pusher socket_id with all requests. Then, while the SequentialQueue is processing, create a list of Onyx updates from each response. Once the SequentialQueue is empty, batch update Onyx. Together with the backend changes to send the socket_id with Pusher events, preventing them from being delivered to the requesting client, and sending Onyx updates for the requesting client back in the response, the replay effect is solved.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/270219
PROPOSAL: GH_LINK_ISSUE(COMMENT)

Tests

Without backend changes

Response Onyx updates work

Sign in with any account
Open the Network tab
Send a message in any chat
Mark the message as unread
Navigate to another chat
Navigate back to the chat
Verify that the message is now read
Verify that the onyxData returned in the last OpenReport response contains an update for the lastReadTime.
Verify that the queuedOnyxUpdates key is empty in the Onyx DB: Application > IndexedDB > OnyxDB > keyvaluepairs > Search for queuedOnyxUpdates and verify that nothing comes up

Pusher Onyx updates work

Sign in with account A
Sign into account B on another device, making sure both devices remain active with the app open
Send a message from A to B
Verify that B receives the message from A

Verify that no errors appear in the JS console

Offline tests

Without backend changes

Send offline messages

Log in with any account
Go offline
Send a message in an existing chat with account A
Send a message in an existing chat with account B
Go back online
Verify that both messages sent successfully and aren't grayed out.

With backend changes from the Web-Expensify PR

Workspace rename

Log in with any account
Go offline
Create a new worksapce
Rename the workspace Workspace
Go back to the settings
Go back online
Verify that the workspace shows the new name

New chat

Log in with any account
Go offline
Create a new DM with someone you have never chatted with before
Send a message
Go back online
Verify that the messages remain in order

Workspace member

Open the app > Open any Workspace > Go to Manage members
Go offline
Invite and remove a member while offline
Go online
Verify that the member is removed when you go back online and remains removed

QA Steps

Most of the QA will be handled with the backend PR QA, so just run the Pusher Onyx updates work and Send offline messages tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

The changes are platform independent so I only tested on web.

Web

Without backend changes

Response Onyx updates work

response-onyx-updates.mov

Pusher Onyx updates work

pusher-onyx-updates.mov

Send offline messages

offline-messages.mov

With backend changes from the Web-Expensify PR

Workspace rename

replayA.mov

New chat

replay-new-chat.mov

Workspace member

replay-member.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

jasperhuangg · 2023-04-10T15:15:55Z

Adding myself as a reviewer since I'm interested in this change 👀

MelvinBot · 2023-04-25T22:20:41Z

@aimane-chnaif @cristipaval One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

neil-marcellini · 2023-04-25T22:23:52Z

Woohoo this is ready for review @jasperhuangg!

neil-marcellini · 2023-04-27T16:50:13Z

Bump @aimane-chnaif, @cristipaval

aimane-chnaif · 2023-04-27T16:51:25Z

started reviewing

src/libs/API.js

src/libs/Middleware/SaveResponseInOnyx.js

jasperhuangg

Few minor changes, overall looks really good haven't had a chance to test yet tho

src/libs/Middleware/SaveResponseInOnyx.js

neil-marcellini · 2023-05-01T17:37:52Z

Updated, thanks for the reviewing Jasper! Can we get this merged today? It's been up for review for almost a week. @aimane-chnaif will you be able to finish your review today? @cristipaval are you planning to review?

neil-marcellini · 2023-05-03T16:03:57Z

@aimane-chnaif the Web-E PR is held on this PR. Please only run the tests without the backend changes, or message one of the internal employees on this PR and we can set up a ngrok url for you to hit our dev environment with the backend changes. Please review again today.

aimane-chnaif · 2023-05-03T16:06:24Z

@neil-marcellini ok, does #16545 (comment) also require backend deploy?

neil-marcellini · 2023-05-03T17:13:06Z

Yes. The replay effect isn't fixed for any case without the backend portion as well

aimane-chnaif · 2023-05-04T12:40:44Z

Looks good so far "without backend changes".
So Response/Pusher Onyx updates and offline tests work correctly.
queuedOnyxUpdates onyx data is synced well.

One thing I noticed that this code is run once more unnecessarily at the end after bulk requests (so 2 times total)

@neil-marcellini please pull main as branch is very behind

aimane-chnaif · 2023-05-04T12:41:35Z

message one of the internal employees on this PR and we can set up a ngrok url for you to hit our dev environment with the backend changes

Can anyone please help me on this to test with backend changes from the Web-Expensify PR?
cc: @cristipaval @jasperhuangg @neil-marcellini

neil-marcellini · 2023-05-04T17:58:34Z

@jasperhuangg says he will help you test. I'm going to merge main now. I'll also look into why the finally block runs twice.

neil-marcellini · 2023-05-04T19:10:08Z

One thing I noticed that this code is run once more unnecessarily at the end after bulk requests (so 2 times total)

@aimane-chnaif I added some console logs and did some debugging. I think you probably encountered this in the case of the Response Onyx updates work test right? Regardless I tested by opening a single report once.

What I found is that we make two identical API.write calls to OpenReport when the report screen updates and when the ReportActionsView mounts. However, looking at the Network tab I only saw one request get made, which means we are actually de-duplicating identical requests somewhere. When we finishing processing the first request we remove all persisted requests here that are equal to the request we want to remove. Since we have two identical OpenReport requests they both get removed as you can see here.

Full OpenReport logs

Neil API.write OpenReport
SequentialQueue.js:102 Neil push request =  {command: 'OpenReport', data: {…}, successData: Array(1), failureData: Array(1)}
SequentialQueue.js:54 Neil flush
Log.js:61 [info] Making API request - {"command":"OpenReport"}
Log.js:61 [info] Navigating to route - {"path":"/r/4548882972288752"}
index.js:865 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
setupWebWheelHandler @ index.js:865
componentDidMount @ index.js:834
commitLayoutEffectOnFiber @ react-dom.development.js:23204
commitLayoutMountEffects_complete @ react-dom.development.js:24578
commitLayoutEffects_begin @ react-dom.development.js:24564
commitLayoutEffects @ react-dom.development.js:24502
commitRootImpl @ react-dom.development.js:26779
commitRoot @ react-dom.development.js:26638
performSyncWorkOnRoot @ react-dom.development.js:26073
flushSyncCallbacks @ react-dom.development.js:12009
flushSyncCallbacksOnlyInLegacyMode @ react-dom.development.js:11988
scheduleUpdateOnFiber @ react-dom.development.js:25438
enqueueSetState @ react-dom.development.js:13264
Component.setState @ react.development.js:354
keyChanged @ web.development.js:624
eval @ web.development.js:863
Report.js:382 Neil API.write OpenReport
SequentialQueue.js:102 Neil push request =  {command: 'OpenReport', data: {…}, successData: Array(1), failureData: Array(1)}
Log.js:61 [info] [Pusher] Attempting to subscribe to channel - {"channelName":"private-report-reportID-4548882972288752-fedb07a3eb09464e90c6d179634afdc5","eventName":"client-userIsTyping"}
Log.js:61 [info] [PusherAuthorizer] Attempting to authorize Pusher - {"channelName":"private-report-reportID-4548882972288752-fedb07a3eb09464e90c6d179634afdc5"}
Log.js:61 [info] Making API request - {"command":"AuthenticatePusher"}
Timing.js:46 Timing:development.new.expensify.switch_report.warm 366
Log.js:61 [info] Finished API request - {"command":"AuthenticatePusher","jsonCode":200,"requestID":"4cVwdP"}
Log.js:61 [info] [PusherAuthorizer] Pusher authenticated successfully - {"channelName":"private-report-reportID-4548882972288752-fedb07a3eb09464e90c6d179634afdc5"}
index.js:149 [Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive. See https://www.chromestatus.com/feature/5745543795965952
componentDidMount @ index.js:149
commitLayoutEffectOnFiber @ react-dom.development.js:23204
commitLayoutMountEffects_complete @ react-dom.development.js:24578
commitLayoutEffects_begin @ react-dom.development.js:24564
commitLayoutEffects @ react-dom.development.js:24502
commitRootImpl @ react-dom.development.js:26779
commitRoot @ react-dom.development.js:26638
performSyncWorkOnRoot @ react-dom.development.js:26073
flushSyncCallbacks @ react-dom.development.js:12009
flushSyncCallbacksOnlyInLegacyMode @ react-dom.development.js:11988
scheduleUpdateOnFiber @ react-dom.development.js:25438
enqueueSetState @ react-dom.development.js:13264
Component.setState @ react.development.js:354
setWithOnyxState @ web.development.js:2342
sendDataToConnection @ web.development.js:677
eval @ web.development.js:814
Log.js:61 [info] [Report] Handled onyxApiUpdate event sent by Pusher - [{"onyxMethod":"merge","key":"report_4548882972288752","value":{"lastReadTime":"2023-05-04 18:50:02.239"}}]
Log.js:61 [info] Finished API request - {"command":"OpenReport","jsonCode":200,"requestID":"JpqdCU"}
PersistedRequests.js:32 Neil persisted requests before remove = (2) [{…}, {…}]0: {command: 'OpenReport', data: {…}, successData: Array(1), failureData: Array(1)}command: "OpenReport"data: {reportID: '4548882972288752', emailList: '', appversion: '1.3.10-2', apiRequestType: 'write', pusherSocketID: '464095.159175', …}apiRequestType: "write"appversion: "1.3.10-2"canCancel: trueemailList: ""pusherSocketID: "464095.159175"reportID: "4548882972288752"shouldRetry: true[[Prototype]]: ObjectfailureData: [{…}]successData: [{…}][[Prototype]]: Object1: {command: 'OpenReport', data: {…}, successData: Array(1), failureData: Array(1)}command: "OpenReport"data: apiRequestType: "write"appversion: "1.3.10-2"canCancel: trueemailList: ""pusherSocketID: "464095.159175"reportID: "4548882972288752"shouldRetry: true[[Prototype]]: ObjectfailureData: [{…}]successData: [{…}][[Prototype]]: Objectlength: 2[[Prototype]]: Array(0)
PersistedRequests.js:36 Neil persisted requests after remove = []
SequentialQueue.js:77 Neil process finished
QueuedOnyxUpdates.js:30 Neil queuedOnyxUpdates =  (4) [{…}, {…}, {…}, {…}]
SequentialQueue.js:54 Neil flush
SequentialQueue.js:77 Neil process finished
QueuedOnyxUpdates.js:30 Neil queuedOnyxUpdates =  (4) [{…}, {…}, {…}, {…}]
2QueuedOnyxUpdates.js:22 Neil QueuedOnyxUpdates clear

So that's super interesting, thank you for pointing that out! The end result is that the SequentialQueue only processes one request but it still calls flush and process twice, which calls this finally block twice. Flush is called twice because every time we push a request we eventually call flush, and for the second request we call flush once the queue is ready here. I'll think about how to fix this, but it's an existing problem and probably not a blocker for this PR.

neil-marcellini · 2023-05-04T19:24:55Z

@aimane-chnaif @jasperhuangg Ok that's resolved now, we only call process and update Onyx when there are actually requests remaining to be processed. I tested and verified that the duplicate calls to OpenReport only result in Onyx.update in the finally block getting called once.

jasperhuangg · 2023-05-05T03:46:30Z

I've performed the back-end changes, they all work as expected! Ignore the Onyx error with creating a workspace, that's a different, unrelated error:

Screen.Recording.2023-05-04.at.8.44.26.PM.mov

jasperhuangg · 2023-05-05T03:48:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-05-04.at.8.44.26.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

aimane-chnaif · 2023-05-05T03:53:40Z

I've performed the back-end changes, they all work as expected!

oh great! I will also test in a few hrs against ngrok url you shared.

jasperhuangg · 2023-05-05T03:54:45Z

I've performed the back-end changes, they all work as expected!

oh great! I will also test in a few hrs against ngrok url you shared.

@aimane-chnaif cool, I was only able to test against Web, so feel free to update my comment above with tests on the other platforms, thanks!

aimane-chnaif · 2023-05-05T12:00:45Z

@jasperhuangg I tried with your ngrok url but stuck on login. I never received email with magic code.

neil-marcellini · 2023-05-05T18:22:36Z

Thanks so much @jasperhuangg!

OSBotify · 2023-05-05T18:28:35Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-05-05T20:01:56Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.11-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

aimane-chnaif

@neil-marcellini can you please add app issue link to Fixed Issues section?

neil-marcellini · 2023-05-08T21:25:09Z

Sorry which App issue?

aimane-chnaif · 2023-05-09T03:19:29Z

Sorry which App issue?

Nvm, you already answered to #12775 (comment)

OSBotify · 2023-05-09T04:04:31Z

🚀 Deployed to production by https://github.com/roryabraham in version: 1.3.12-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Nikhil-Vats · 2023-05-09T21:18:05Z

@neil-marcellini is the backend PR for this issue merged and deployed to staging? I think it might resolve another issue caused by the replay effect but cannot test without backend changes as you have mentioned above.

neil-marcellini · 2023-05-10T17:29:38Z

@Nikhil-Vats the backend PR is not on staging yet. We'll keep you updated in the tracking issue #12775

Nikhil-Vats · 2023-05-10T18:18:28Z

Thanks @neil-marcellini. I asked because I found out that the root cause of this issue #18492 is also same. The emojis appear correctly first but then disappear because of the pusher events received. Although what I didn't understand was why the pusher events are always out of order, the response from the first API call is always returned last due to which the emojis on the UI are wrong (only 1 emoji is added since the first AddEmojiReaction pusher event was received at the end and it has only 1 reaction).

marcaaron · 2023-05-12T18:27:42Z

src/libs/Middleware/SaveResponseInOnyx.js

@@ -13,23 +15,27 @@ function SaveResponseInOnyx(response, request) {
                return;
            }

+            // For most requests we can immediately update Onyx. For write requests we queue the updates and apply them after the sequential queue has flushed to prevent a replay effect in
+            // the UI. See https://github.com/Expensify/App/issues/12775 for more info.


fwiw it is easy for people to find linked issues by using git blame. usually there is no need to add a link to a github issue.

neil-marcellini added 6 commits March 24, 2023 10:46

Store pusherSocketID to send with requests

c53fa0e

Lint, export getPusherSocketID vs mutable export

4bc9d6f

Send socket id in requests to fix replay effect

9731a17

Create actions to queue onyx updates

237abd1

pusherSocketID is only needed in write requests

3e6f2a4

Queue then update Onyx after SequentialQueue flush

38a5653

neil-marcellini self-assigned this Mar 27, 2023

neil-marcellini mentioned this pull request Mar 28, 2023

[Tracking] "Replay effect" when sequential actions are taken offline, and user subsequently comes online #12775

Closed

Merge branch 'main' into neil-replay-effect

7c0433e

jasperhuangg self-requested a review April 10, 2023 15:15

neil-marcellini added 3 commits April 10, 2023 16:00

socket_id is only available once connected

b057930

Properly check apiRequestType

c6d10bd

Handle all updates before clearing queued updates

3c7e9f9

neil-marcellini changed the title ~~Neil replay effect~~ Fix replay effect Apr 25, 2023

Add file description comment per checklist

eb74861

neil-marcellini marked this pull request as ready for review April 25, 2023 22:20

neil-marcellini requested a review from a team as a code owner April 25, 2023 22:20

melvin-bot bot requested review from aimane-chnaif and cristipaval and removed request for a team April 25, 2023 22:20

jasperhuangg reviewed Apr 28, 2023

View reviewed changes

src/libs/API.js Outdated Show resolved Hide resolved

jasperhuangg reviewed Apr 28, 2023

View reviewed changes

src/libs/Middleware/SaveResponseInOnyx.js Outdated Show resolved Hide resolved

jasperhuangg requested changes Apr 28, 2023

View reviewed changes

src/libs/Middleware/SaveResponseInOnyx.js Show resolved Hide resolved

Small cleanup from review feedback

2fabf6e

Merge branch 'main' into neil-replay-effect

abc6a08

Process and update Onyx only if requests exist

6a42b9a

jasperhuangg approved these changes May 5, 2023

View reviewed changes

neil-marcellini merged commit a5e122c into main May 5, 2023

neil-marcellini deleted the neil-replay-effect branch May 5, 2023 18:22

OSBotify mentioned this pull request May 5, 2023

Deploy Checklist: New Expensify 2023-05-05 #18498

Closed

31 tasks

aimane-chnaif reviewed May 8, 2023

View reviewed changes

marcaaron reviewed May 12, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix replay effect #16545

Fix replay effect #16545

neil-marcellini commented Mar 27, 2023 •

edited

Loading

jasperhuangg commented Apr 10, 2023

MelvinBot commented Apr 25, 2023

neil-marcellini commented Apr 25, 2023

neil-marcellini commented Apr 27, 2023

aimane-chnaif commented Apr 27, 2023

jasperhuangg left a comment

neil-marcellini commented May 1, 2023

neil-marcellini commented May 3, 2023

aimane-chnaif commented May 3, 2023

neil-marcellini commented May 3, 2023

aimane-chnaif commented May 4, 2023

aimane-chnaif commented May 4, 2023

neil-marcellini commented May 4, 2023 •

edited

Loading

neil-marcellini commented May 4, 2023

neil-marcellini commented May 4, 2023 •

edited

Loading

jasperhuangg commented May 5, 2023 •

edited

Loading

jasperhuangg commented May 5, 2023 •

edited

Loading

aimane-chnaif commented May 5, 2023

jasperhuangg commented May 5, 2023

aimane-chnaif commented May 5, 2023

neil-marcellini commented May 5, 2023

OSBotify commented May 5, 2023

OSBotify commented May 5, 2023

aimane-chnaif left a comment

neil-marcellini commented May 8, 2023

aimane-chnaif commented May 9, 2023

OSBotify commented May 9, 2023

Nikhil-Vats commented May 9, 2023

neil-marcellini commented May 10, 2023

Nikhil-Vats commented May 10, 2023

marcaaron May 12, 2023

Fix replay effect #16545

Fix replay effect #16545

Conversation

neil-marcellini commented Mar 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Without backend changes

Offline tests

Without backend changes

With backend changes from the Web-Expensify PR

QA Steps

PR Author Checklist

Screenshots/Videos

Without backend changes

With backend changes from the Web-Expensify PR

jasperhuangg commented Apr 10, 2023

MelvinBot commented Apr 25, 2023

neil-marcellini commented Apr 25, 2023

neil-marcellini commented Apr 27, 2023

aimane-chnaif commented Apr 27, 2023

jasperhuangg left a comment

Choose a reason for hiding this comment

neil-marcellini commented May 1, 2023

neil-marcellini commented May 3, 2023

aimane-chnaif commented May 3, 2023

neil-marcellini commented May 3, 2023

aimane-chnaif commented May 4, 2023

aimane-chnaif commented May 4, 2023

neil-marcellini commented May 4, 2023 • edited Loading

neil-marcellini commented May 4, 2023

neil-marcellini commented May 4, 2023 • edited Loading

jasperhuangg commented May 5, 2023 • edited Loading

jasperhuangg commented May 5, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

aimane-chnaif commented May 5, 2023

jasperhuangg commented May 5, 2023

aimane-chnaif commented May 5, 2023

neil-marcellini commented May 5, 2023

OSBotify commented May 5, 2023

OSBotify commented May 5, 2023

aimane-chnaif left a comment

Choose a reason for hiding this comment

neil-marcellini commented May 8, 2023

aimane-chnaif commented May 9, 2023

OSBotify commented May 9, 2023

Nikhil-Vats commented May 9, 2023

neil-marcellini commented May 10, 2023

Nikhil-Vats commented May 10, 2023

marcaaron May 12, 2023

Choose a reason for hiding this comment

neil-marcellini commented Mar 27, 2023 •

edited

Loading

neil-marcellini commented May 4, 2023 •

edited

Loading

neil-marcellini commented May 4, 2023 •

edited

Loading

jasperhuangg commented May 5, 2023 •

edited

Loading

jasperhuangg commented May 5, 2023 •

edited

Loading