-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[No QA] Add constants for update field related change logs #16881
Conversation
Did I miss that many? 😅 |
@luacmartins Haha no I added some new ones! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now alphabetical! LGTM!
@hayata-suenaga or @luacmartins can one of you paste in the PR Reviewer checklist and merge? |
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.2.95-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.2.95-0 🚀
|
@hayata-suenaga please review
Details
Just adding a couple constants that were not reflected in @luacmartins's original add. Also, sorted everything to be alphabetical.
Fixed Issues
None, but related to https://github.com/Expensify/Expensify/issues/267615
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the [translation method](App/src/components/withLocalize.js
Line 60 in 4bd9940
App/src/components/withLocalize.js
Lines 60 to 68 in 4bd9940
Waiting for Copy
label for a copy review on the original GH to get the correct copy.[STYLE.md](https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#jsdocs)
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android