Fix zoom and slide on native for PDFView #17647

alexxxwork · 2023-04-19T09:27:30Z

Details

The carousel component doesn't swipe with single tap when displaying a PDF. User should be able to switch attachments with swipe and to zoom and pan pdf attachments.
This PR adds a callback to get scale from PDFView component to know if we are in a zoomed state.

Fixed Issues

$ #15988
PROPOSAL: #15988 (comment)

Tests

Go to any chat
Send Image, then send a pdf file
Preview image, slide right using fingers (not the right arrow slider)
Verify the pdf displays.
Slide left from pdf and slide back right.
Verify that attachments change smoothly
Pinch-zoom or double-tap to zoom pdf
Verify that you can move the document with a finger touch and drag
Verify that you're not able to switch to other attachment in zoomed state

Verify that no errors appear in the JS console

Offline tests

QA Steps

Go to any chat
Send Image, then send a pdf file
Preview image, slide right using fingers (not the right arrow slider)
Verify the pdf displays.
Slide left from pdf and slide back right.
Verify that attachments change smoothly
Pinch-zoom or double-tap to zoom pdf
Verify that you can move the document with a finger touch and drag
Verify that you're not able to switch to other attachment in zoomed state

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Rec.2023-04-19.13.56.41.mov

Mobile Web - Chrome

Screen_Recording_20230419_141833_Chrome.mp4

Mobile Web - Safari

Screen.Rec.2023-04-19.mp4

Desktop

Rec.2023-04-19.13.49.51.mov

iOS

Rec.2023-04-19.12.58.44.mov

Android

Screen_Recording_20230419_123557_New.Expensify.mp4

MelvinBot · 2023-04-19T09:27:36Z

@luacmartins @0xmiroslav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

Left a small comment.

src/components/AttachmentCarousel/index.js

0xmiros

It's a good idea to move onPress event from renderCell to renderItem but unfortunately it causes regression of prev/next arrow buttons visibility not changing when tap in these cases:

while loading pdf
on password protected pdf
on image

src/components/PDFView/index.native.js

src/components/AttachmentCarousel/index.js

Co-authored-by: Miroslav Stevanovic <[email protected]>

src/components/AttachmentCarousel/index.js

0xmiros · 2023-04-21T16:49:12Z

@alexxxwork let's add one more step:
9. Verify that you're not able to switch to other attachment in zoomed state

src/components/AttachmentView.js

Co-authored-by: Miroslav Stevanovic <[email protected]>

src/components/AttachmentView.js

0xmiros · 2023-04-24T02:27:11Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mchrome.mp4

Mobile Web - Safari

msafari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mp4

luacmartins · 2023-04-24T09:02:21Z

@alexxxwork just one last change requested - #17647 (comment)

alexxxwork · 2023-04-24T10:42:14Z

@alexxxwork just one last change requested - #17647 (comment)

@luacmartins Changes pushed.

0xmiros

@alexxxwork Please apply my suggested changes. We don't need hand cursor at all on non-touchable devices.

src/components/AttachmentView.js

Co-authored-by: Miroslav Stevanovic <[email protected]>

0xmiros

Latest version looks good.
Tested all possible cases.
There's dedicated issue #17720 for image zoomed case.
There are some known bugs below but they already happen on main so out of scope. I will report them in slack soon.

weird behavior on clicking left/right arrow on mChrome, similar to [HOLD for payment 2023-06-29] [$1000] mWeb - Attachment - Modify the carousel component to improve swiping navigation between attachments #17723 (comment)
resizing window on web hides Send button on attachment preview
scroll bar not fully covers image when zoomed
app freezes when click android device back button on mChrome

All yours @luacmartins

0xmiros · 2023-04-24T12:45:18Z

@luacmartins job2 seems running forever. can you please stop and re-trigger it?

OSBotify · 2023-04-24T14:58:13Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-04-25T06:08:53Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.5-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-04-26T05:50:53Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.5-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

hoangzinh · 2023-06-29T14:56:46Z

src/components/AttachmentView.js

            />
        );
+        return (
+            props.onPress ? (
+                <Pressable onPress={props.onPress} disabled={loadComplete} style={containerStyles}>


@alexxxwork do you mind to explain why do we need Pressable here? In another the words, can we remove the Pressable here? Thanks.

Sorry, completely missed this mention. If I remember this right, there was a specific case when arrows wouldn't hide/show if you press attachment before PDF loaded. So we use Pressable and disable it on PDF load complete.
cc: @0xmiroslav

alexxxwork added 2 commits April 19, 2023 04:30

Initial work

2515154

Remove redundant code

bf20612

alexxxwork requested a review from a team as a code owner April 19, 2023 09:27

melvin-bot bot requested review from 0xmiros and luacmartins and removed request for a team April 19, 2023 09:27

Merge branch 'main' into issue-15988

43dc6d6

alexxxwork mentioned this pull request Apr 19, 2023

[HOLD for payment 2023-05-03] [$2000] Sliding using fingers on android from pdf to image gets stuck and doesn't work the way how sliding from image to pdf works #15988

Closed

6 tasks

luacmartins reviewed Apr 19, 2023

View reviewed changes

src/components/AttachmentCarousel/index.js Outdated Show resolved Hide resolved

Fix comment in FlatList

4db1446

0xmiros reviewed Apr 20, 2023

View reviewed changes

src/components/PDFView/index.native.js Outdated Show resolved Hide resolved

src/components/AttachmentCarousel/index.js Outdated Show resolved Hide resolved

alexxxwork and others added 7 commits April 20, 2023 20:51

Update src/components/AttachmentCarousel/index.js

879868f

Co-authored-by: Miroslav Stevanovic <[email protected]>

Fix toggleZoomed func name

e64e030

Fix comment for updateZoomState

8124997

Remove redundant View

0f17713

Merge branch 'main' into issue-15988

925514f

Fix tap to show arrows

e990f9a

Minor fixes and lint

6dce5dd

alexxxwork requested a review from 0xmiros April 20, 2023 23:19

alexxxwork added 2 commits April 21, 2023 15:23

Merge branch 'main' into issue-15988

17e1339

Fix reset zoom state on page update

cbdb329

0xmiros reviewed Apr 21, 2023

View reviewed changes

src/components/AttachmentCarousel/index.js Outdated Show resolved Hide resolved

src/components/AttachmentCarousel/index.js Outdated Show resolved Hide resolved

alexxxwork added 3 commits April 21, 2023 20:57

Hide arrows when in a zoomed state

e82e1de

Add comments for debounce func

5a2752b

Minor style fix

2fe3955

alexxxwork added 3 commits April 21, 2023 22:11

Fix for mWeb onScrollBeginDrag to onScroll

c9013d0

Refactor solution to use Pressable in AttachmentView

439c667

Fix lin issues, remove debounce

31c1d7f

0xmiros reviewed Apr 21, 2023

View reviewed changes

src/components/AttachmentView.js Outdated Show resolved Hide resolved

alexxxwork and others added 2 commits April 22, 2023 02:36

Update src/components/AttachmentView.js

b49ce7c

Co-authored-by: Miroslav Stevanovic <[email protected]>

Fix a bug in upload pdf preview

a3e6026

0xmiros reviewed Apr 24, 2023

View reviewed changes

src/components/AttachmentView.js Outdated Show resolved Hide resolved

alexxxwork added 2 commits April 24, 2023 15:15

Remove Pressable from AttachmentView

68cb6b6

Fix remove redundant onPress in AttachmentView

fe44cee

0xmiros suggested changes Apr 24, 2023

View reviewed changes

src/components/AttachmentView.js Outdated Show resolved Hide resolved

src/components/AttachmentView.js Outdated Show resolved Hide resolved

src/components/AttachmentView.js Outdated Show resolved Hide resolved

src/components/AttachmentView.js Outdated Show resolved Hide resolved

alexxxwork and others added 3 commits April 24, 2023 16:57

Update src/components/AttachmentView.js

5536157

Co-authored-by: Miroslav Stevanovic <[email protected]>

Update src/components/AttachmentView.js

83cc726

Co-authored-by: Miroslav Stevanovic <[email protected]>

Fix web pointer regression, set onPress: undefined

f482778

0xmiros approved these changes Apr 24, 2023

View reviewed changes

luacmartins approved these changes Apr 24, 2023

View reviewed changes

luacmartins merged commit 30420a1 into Expensify:main Apr 24, 2023

luacmartins assigned alexxxwork Apr 24, 2023

0xmiros mentioned this pull request Apr 24, 2023

[HOLD for payment 2023-06-13] Weird behavior while dragging zoomed image in preview #17720

Closed

6 tasks

stephanieelliott mentioned this pull request Apr 25, 2023

[HOLD for payment 2023-06-29] [$1000] mWeb - Attachment - Modify the carousel component to improve swiping navigation between attachments #17723

Closed

6 tasks

OSBotify mentioned this pull request Apr 25, 2023

Deploy Checklist: New Expensify 2023-04-25 #17948

Closed

37 tasks

kbecciv mentioned this pull request Apr 25, 2023

mWeb - Chat - Zoom fails after pinch-zoom or double-tap on PDF and images #17973

Closed

6 tasks

aimane-chnaif mentioned this pull request May 3, 2023

[HOLD for payment 2023-05-23] [$1000] On increasing the screen size the user can see the previous image in the list #17760

Closed

6 tasks

robertKozik mentioned this pull request May 16, 2023

[Group 1][Accessible Pressable] Migrate PDFView #17009

Closed

fedirjh mentioned this pull request May 17, 2023

[$1000] Zoom view in the attachment preview is lost with 4 or more attachments #18614

Closed

6 tasks

hoangzinh reviewed Jun 29, 2023

View reviewed changes

hoangzinh mentioned this pull request Jun 30, 2023

Fix unable to scroll PDF files in preview #21714

Merged

57 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix zoom and slide on native for PDFView #17647

Fix zoom and slide on native for PDFView #17647

alexxxwork commented Apr 19, 2023 •

edited

Loading

MelvinBot commented Apr 19, 2023

luacmartins left a comment

0xmiros left a comment

0xmiros commented Apr 21, 2023

0xmiros commented Apr 24, 2023

luacmartins commented Apr 24, 2023

alexxxwork commented Apr 24, 2023 •

edited

Loading

0xmiros left a comment

0xmiros left a comment

0xmiros commented Apr 24, 2023

OSBotify commented Apr 24, 2023

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

hoangzinh Jun 29, 2023

alexxxwork Jul 3, 2023

Fix zoom and slide on native for PDFView #17647

Fix zoom and slide on native for PDFView #17647

Conversation

alexxxwork commented Apr 19, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

MelvinBot commented Apr 19, 2023

luacmartins left a comment

Choose a reason for hiding this comment

0xmiros left a comment

Choose a reason for hiding this comment

0xmiros commented Apr 21, 2023

0xmiros commented Apr 24, 2023

Reviewer Checklist

Screenshots/Videos

luacmartins commented Apr 24, 2023

alexxxwork commented Apr 24, 2023 • edited Loading

0xmiros left a comment

Choose a reason for hiding this comment

0xmiros left a comment

Choose a reason for hiding this comment

0xmiros commented Apr 24, 2023

OSBotify commented Apr 24, 2023

OSBotify commented Apr 25, 2023

OSBotify commented Apr 26, 2023

hoangzinh Jun 29, 2023

Choose a reason for hiding this comment

alexxxwork Jul 3, 2023

Choose a reason for hiding this comment

alexxxwork commented Apr 19, 2023 •

edited

Loading

alexxxwork commented Apr 24, 2023 •

edited

Loading